Merge pull request #325 from Iterable/test/MOB-1519-inapppresenter-tests

[MOB-1519] inapppresenter tests (part 1)

Author: roninopf

swift-sdk.xcodeproj/project.pbxproj

@@ -23,6 +23,7 @@
 		55B37FEE229F59290042F13A /* InAppPersistenceTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55B37FED229F59290042F13A /* InAppPersistenceTests.swift */; };
 		55B5498423973B5C00243E87 /* InboxSessionManagerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55B5498323973B5C00243E87 /* InboxSessionManagerTests.swift */; };
 		55B549862397462300243E87 /* InboxImpressionTrackerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55B549852397462300243E87 /* InboxImpressionTrackerTests.swift */; };
+		55CC257B2462064F00A77FD5 /* InAppPresenterTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55CC257A2462064F00A77FD5 /* InAppPresenterTests.swift */; };
 		55D54656239AE5750093ED1E /* LoggingInternal.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55D54655239AE5750093ED1E /* LoggingInternal.swift */; };
 		55E6F460238E066400808BCE /* DeferredDeepLinkTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55E6F45D238E066400808BCE /* DeferredDeepLinkTests.swift */; };
 		55E6F462238E066400808BCE /* DeepLinkTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 55E6F45E238E066400808BCE /* DeepLinkTests.swift */; };
@@ -289,6 +290,7 @@
 		55B37FED229F59290042F13A /* InAppPersistenceTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InAppPersistenceTests.swift; sourceTree = "<group>"; };
 		55B5498323973B5C00243E87 /* InboxSessionManagerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InboxSessionManagerTests.swift; sourceTree = "<group>"; };
 		55B549852397462300243E87 /* InboxImpressionTrackerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InboxImpressionTrackerTests.swift; sourceTree = "<group>"; };
+		55CC257A2462064F00A77FD5 /* InAppPresenterTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InAppPresenterTests.swift; sourceTree = "<group>"; };
 		55D54655239AE5750093ED1E /* LoggingInternal.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LoggingInternal.swift; sourceTree = "<group>"; };
 		55E6F45D238E066400808BCE /* DeferredDeepLinkTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DeferredDeepLinkTests.swift; sourceTree = "<group>"; };
 		55E6F45E238E066400808BCE /* DeepLinkTests.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DeepLinkTests.swift; sourceTree = "<group>"; };
@@ -745,6 +747,7 @@
 				5531CDAD22A9C992000D05E2 /* ClassExtensionsTests.swift */,
 				55B37FC0229620D20042F13A /* CommerceItemTests.swift */,
 				55E6F45E238E066400808BCE /* DeepLinkTests.swift */,
+				55CC257A2462064F00A77FD5 /* InAppPresenterTests.swift */,
 				55E6F45D238E066400808BCE /* DeferredDeepLinkTests.swift */,
 				551E5C0F234D485A005FEE9E /* DeprecatedFunctionsTests.swift */,
 				AC750A49234CD67900561902 /* InAppHelperTests.swift */,
@@ -1525,6 +1528,7 @@
 				551E5C10234D485A005FEE9E /* DeprecatedFunctionsTests.swift in Sources */,
 				ACED4C01213F50B30055A497 /* LoggingTests.swift in Sources */,
 				55B37FC42297135F0042F13A /* NotificationMetadataTests.swift in Sources */,
+				55CC257B2462064F00A77FD5 /* InAppPresenterTests.swift in Sources */,
 				AC4BA00224163D8F007359F1 /* IterableHtmlMessageViewControllerTests.swift in Sources */,
 				55B37FC822975A840042F13A /* InboxMessageViewModelTests.swift in Sources */,
 				55E6F462238E066400808BCE /* DeepLinkTests.swift in Sources */,

swift-sdk/Internal/InAppPresenter.swift

@@ -8,17 +8,18 @@ import UIKit
 class InAppPresenter {
     static var isPresenting = false
 
-    private let delayInterval: TimeInterval = 0.75
+    private let maxDelay: TimeInterval
 
     private let topViewController: UIViewController
     private let htmlMessageViewController: IterableHtmlMessageViewController
     private var delayTimer: Timer?
 
-    init(topViewController: UIViewController, htmlMessageViewController: IterableHtmlMessageViewController) {
+    init(topViewController: UIViewController, htmlMessageViewController: IterableHtmlMessageViewController, maxDelay: TimeInterval = 0.75) {
         ITBInfo()
 
         self.topViewController = topViewController
         self.htmlMessageViewController = htmlMessageViewController
+        self.maxDelay = maxDelay
 
         // shouldn't be necessary, but in case there's some kind of race condition
         // that leaves it hanging as true, it should be false at this point
@@ -38,7 +39,7 @@ class InAppPresenter {
 
         if #available(iOS 10.0, *) {
             DispatchQueue.main.async {
-                self.delayTimer = Timer.scheduledTimer(withTimeInterval: self.delayInterval, repeats: false) { _ in
+                self.delayTimer = Timer.scheduledTimer(withTimeInterval: self.maxDelay, repeats: false) { _ in
                     ITBInfo("delayTimer called")
 
                     self.delayTimer = nil

tests/swift-sdk-swift-tests/InAppPresenterTests.swift

@@ -0,0 +1,69 @@
+//
+//  Created by Jay Kim on 5/5/20.
+//  Copyright © 2020 Iterable. All rights reserved.
+//
+
+import UIKit
+import WebKit
+import XCTest
+
+@testable import IterableSDK
+
+class InAppPresenterTests: XCTestCase {
+    func testInAppPresenterDelegateExistence() {
+        let htmlMessageViewController = IterableHtmlMessageViewController(parameters: getEmptyParameters())
+        
+        let inAppPresenter = InAppPresenter(topViewController: UIViewController(),
+                                            htmlMessageViewController: htmlMessageViewController)
+        
+        // a "no-op" to suppress warning
+        _ = inAppPresenter.self
+        
+        XCTAssertNotNil(htmlMessageViewController.presenter)
+    }
+    
+    func testInAppPresenterIsPresentingOnInit() {
+        _ = InAppPresenter(topViewController: UIViewController(),
+                           htmlMessageViewController: getEmptyHtmlMessageViewController())
+        
+        XCTAssertFalse(InAppPresenter.isPresenting)
+    }
+    
+    func testInAppPresenterTimerFinished() {
+        let expectation1 = expectation(description: "delay timer executed")
+        
+        let topViewController = UIViewController()
+        let maxDelay = 0.75
+        let inAppPresenter = InAppPresenter(topViewController: topViewController,
+                                            htmlMessageViewController: getEmptyHtmlMessageViewController(),
+                                            maxDelay: maxDelay)
+        
+        inAppPresenter.show()
+        
+        XCTAssertTrue(InAppPresenter.isPresenting)
+        
+        DispatchQueue.main.asyncAfter(deadline: .now() + maxDelay + 0.1) {
+            XCTAssertFalse(InAppPresenter.isPresenting)
+            
+            expectation1.fulfill()
+        }
+        
+        wait(for: [expectation1], timeout: testExpectationTimeout)
+    }
+    
+    private func getEmptyParameters() -> IterableHtmlMessageViewController.Parameters {
+        return IterableHtmlMessageViewController.Parameters(html: "", isModal: false)
+    }
+    
+    private func getEmptyHtmlMessageViewController() -> IterableHtmlMessageViewController {
+        return IterableHtmlMessageViewController(parameters: getEmptyParameters())
+    }
+    
+    private func getEmptyHtmlInAppContent() -> IterableHtmlInAppContent {
+        return IterableHtmlInAppContent(edgeInsets: .zero, backgroundAlpha: 0.0, html: "")
+    }
+    
+    private func getEmptyInAppMessage() -> IterableInAppMessage {
+        return IterableInAppMessage(messageId: "wasd", campaignId: 1, content: getEmptyHtmlInAppContent())
+    }
+}