chore: do some TODOs

Author: ItsEmpa

src/main/kotlin/com/github/itsempa/nautilus/Nautilus.kt

@@ -58,7 +58,6 @@ object Nautilus {
             PositionLinkManager.init(feature)
         }
 
-        // TODO: figure out why this errors on startup
         NautilusRepoManager.initRepo()
 
         NautilusPreInitFinishedEvent.post()

src/main/kotlin/com/github/itsempa/nautilus/events/FishingEventUpdate.kt

@@ -3,7 +3,6 @@ package com.github.itsempa.nautilus.events
 import at.hannibal2.skyhanni.api.event.GenericSkyHanniEvent
 import com.github.itsempa.nautilus.data.fishingevents.FishingEvent
 
-// TODO: confirm that the generic works properly
 sealed class FishingEventUpdate<T : FishingEvent>(val event: T) : GenericSkyHanniEvent<T>(event.javaClass) {
     class Start<T : FishingEvent>(event: T) : FishingEventUpdate<T>(event)
     class End<T : FishingEvent>(event: T) : FishingEventUpdate<T>(event)

src/main/kotlin/com/github/itsempa/nautilus/features/misc/update/UpdateManager.kt

@@ -2,13 +2,12 @@ package com.github.itsempa.nautilus.features.misc.update
 
 import at.hannibal2.skyhanni.api.event.HandleEvent
 import at.hannibal2.skyhanni.config.commands.CommandCategory
-import at.hannibal2.skyhanni.events.minecraft.SkyHanniTickEvent
 import at.hannibal2.skyhanni.utils.ApiUtils
 import at.hannibal2.skyhanni.utils.DelayedRun
 import com.github.itsempa.nautilus.Nautilus
 import com.github.itsempa.nautilus.events.BrigadierRegisterEvent
 import com.github.itsempa.nautilus.utils.NautilusChat
-import com.github.itsempa.nautilus.utils.helpers.McClient
+import com.github.itsempa.nautilus.utils.helpers.McPlayer
 import me.owdding.ktmodules.Module
 import moe.nea.libautoupdate.GithubReleaseUpdateSource
 import moe.nea.libautoupdate.PotentialUpdate
@@ -56,10 +55,10 @@ object UpdateManager {
 
     // TODO: change this
     @HandleEvent
-    fun onTick(event: SkyHanniTickEvent) {
+    fun onTick() {
         if (checked) return
         if (!config.notifyUpdates) return
-        McClient.self.thePlayer ?: return
+        if (!McPlayer.exists) return
         checked = true
         checkUpdate()
     }

src/main/kotlin/com/github/itsempa/nautilus/mixins/transformers/MixinEntityFishHook.java

@@ -23,19 +23,4 @@ public boolean fixBobberLava(World instance, AxisAlignedBB aabb, Material materi
         return LavaBobberHook.fixBobberLava(instance, aabb);
     }
 
-    // TODO: figure out if its possible to use mixin extras
-    /*
-    @WrapOperation(
-        method = "onUpdate",
-        at = @At(
-            value = "INVOKE",
-            target = "Lnet/minecraft/world/World;isAABBInMaterial(Lnet/minecraft/util/AxisAlignedBB;Lnet/minecraft/block/material/Material;)Z"
-        )
-    )
-
-    public boolean fixBobberLava(World instance, AxisAlignedBB aabb, Material material, Operation<Boolean> original) {
-        if (!LavaBobberHook.isEnabled()) return original.call(instance, aabb, material);
-        return LavaBobberHook.fixBobberLava(instance, aabb);
-    }*/
-
 }

src/main/kotlin/com/github/itsempa/nautilus/utils/NautilusChat.kt

@@ -155,8 +155,7 @@ object NautilusChat {
     private fun getUniqueMessageIdForString(string: String): Int =
         uniqueMessageIdStorage.getOrPut(string, ::getUniqueMessageId)
 
-    // TODO: find a reason to use number?
-    private var lastUniqueMessageId = 223242
+    private var lastUniqueMessageId = 680545
 
     fun getUniqueMessageId() = lastUniqueMessageId++
 

src/main/kotlin/com/github/itsempa/nautilus/utils/NautilusUtilsFun.kt

@@ -1,7 +1,5 @@
 package com.github.itsempa.nautilus.utils
 
-// TODO: get a better file name
-
 @Suppress("NOTHING_TO_INLINE")
 inline fun <T : Comparable<T>> min(a: T, b: T): T = if (a < b) a else b