Remove builtin interface setup initialization

Author: J-Rios

README.md

@@ -72,12 +72,6 @@ hal/newdev
 
 /* ... */
 
-bool MINBASECLI_NEWDEV::hal_setup(const uint32_t baud_rate)
-{
-    // Specific device/framework interface initialization
-    // should be written here
-}
-
 bool MINBASECLI_NEWDEV::hal_setup(void* iface, const uint32_t baud_rate)
 {
     // Specific device/framework interface initialization

examples/espidf/basic_usage/main.cpp

@@ -157,7 +157,7 @@ void th_cli_interpreter(void* arg)
     bool command_received = false;
 
     // Setup Command Line Interface
-    Cli.setup();
+    Cli.setup(SIMPLECLI_DEFAULT_IFACE, SIMPLECLI_DEFAULT_BAUDS);
     ESP_LOGI(TAG, "Command Line Interface is ready");
     printf("\n\n");
 

examples/linux/basic_usage/src/main.cpp

@@ -62,7 +62,7 @@ int main()
     bool exit = false;
 
     // Setup Command Line Interface
-    Cli.setup();
+    Cli.setup(SIMPLECLI_DEFAULT_IFACE, SIMPLECLI_DEFAULT_BAUDS);
     printf("\nCommand Line Interface is ready\n\n");
 
     while(1)

examples/windows/basic_usage/main.cpp

@@ -65,7 +65,7 @@ int main()
     bool exit = false;
 
     // Setup Command Line Interface
-    Cli.setup();
+    Cli.setup(SIMPLECLI_DEFAULT_IFACE, SIMPLECLI_DEFAULT_BAUDS);
     printf("\nCommand Line Interface is ready\n\n");
 
     while(1)

src/hal/arduino/minbasecli_arduino.cpp

@@ -75,25 +75,15 @@ MINBASECLI_ARDUINO::MINBASECLI_ARDUINO()
 
 /* Specific Device/Framework HAL functions */
 
-/**
-  * @brief  Setup and initialize UART for CLI interface.
-  * @return If UART has been successfully initialized.
-  */
-bool MINBASECLI_ARDUINO::hal_setup(const uint32_t baud_rate)
-{
-    this->iface = iface;
-    _IFACE* _Serial = (_IFACE*)(&Serial);
-    _Serial->begin(baud_rate);
-    return true;
-}
-
 /**
   * @brief  Hardware Abstraction Layer setup CLI interface.
   * @return If CLI has been successfully initialized.
   */
 bool MINBASECLI_ARDUINO::hal_setup(void* iface, const uint32_t baud_rate)
 {
     this->iface = iface;
+    _IFACE* _Serial = (_IFACE*) this->iface;
+    _Serial->begin(baud_rate);
     return true;
 }
 

src/hal/arduino/minbasecli_arduino.h

@@ -60,15 +60,14 @@ class MINBASECLI_ARDUINO
     public:
         MINBASECLI_ARDUINO();
 
-    private:
-        void* iface;
-
     protected:
-        bool hal_setup(const uint32_t baud_rate);
         bool hal_setup(void* iface, const uint32_t baud_rate);
         size_t hal_iface_available();
         uint8_t hal_iface_read();
         void hal_iface_print(const uint8_t data_byte);
+
+    private:
+        void* iface;
 };
 
 /*****************************************************************************/

src/hal/avr/minbasecli_avr.cpp

@@ -71,25 +71,16 @@ MINBASECLI_AVR::MINBASECLI_AVR()
 
 /* Specific Device/Framework HAL Methods */
 
-/**
-  * @brief  Setup and initialize UART for CLI interface.
-  * @return If UART has been successfully initialized.
-  */
-bool MINBASECLI_AVR::hal_setup(const uint32_t baud_rate)
-{
-    _IFACE* _Serial = (_IFACE*) this->iface;
-    _Serial->setup(baud_rate);
-    return true;
-}
-
 /**
   * @brief  Hardware Abstraction Layer setup CLI interface.
   * @return If CLI has been successfully initialized.
   */
 bool MINBASECLI_AVR::hal_setup(void* iface, const uint32_t baud_rate)
 {
     this->iface = iface;
-    return hal_setup(baud_rate);
+    _IFACE* _Serial = (_IFACE*) this->iface;
+    _Serial->setup(baud_rate);
+    return true;
 }
 
 /**

src/hal/avr/minbasecli_avr.h

@@ -65,7 +65,6 @@ class MINBASECLI_AVR
         MINBASECLI_AVR();
 
     protected:
-        bool hal_setup(const uint32_t baud_rate);
         bool hal_setup(void* iface, const uint32_t baud_rate);
         size_t hal_iface_available();
         uint8_t hal_iface_read();

src/hal/espidf/minbasecli_espidf.cpp

@@ -91,26 +91,18 @@ MINBASECLI_ESPIDF::MINBASECLI_ESPIDF()
 
 /**
   * @brief  Initialize the Command Line Interface providing an interface.
+  * @param  iface CLI interface to use.
   */
-bool MINBASECLI_ESPIDF::hal_setup(const uint32_t baud_rate)
+bool MINBASECLI_ESPIDF::hal_setup(void* iface, const uint32_t baud_rate)
 {
+    this->iface = iface;
     if (uart_setup(baud_rate) == false)
         return false;
     if (launch_stdin_read_thread() == false)
         return false;
     return true;
 }
 
-/**
-  * @brief  Initialize the Command Line Interface providing an interface.
-  * @param  iface CLI interface to use.
-  */
-bool MINBASECLI_ESPIDF::hal_setup(void* iface, const uint32_t baud_rate)
-{
-    this->iface = iface;
-    return hal_setup(baud_rate);
-}
-
 size_t MINBASECLI_ESPIDF::hal_iface_available()
 {
     return (this->th_rx_read_head - this->th_rx_read_tail);

src/hal/espidf/minbasecli_espidf.h

@@ -66,7 +66,6 @@ class MINBASECLI_ESPIDF
         MINBASECLI_ESPIDF();
 
     protected:
-        bool hal_setup(const uint32_t baud_rate);
         bool hal_setup(void* iface, const uint32_t baud_rate);
         size_t hal_iface_available();
         uint8_t hal_iface_read();