phpstan updates

Author: J-T-McC

src/Commands/ListCommand.php

@@ -12,19 +12,19 @@ class ListCommand extends BaseCommand
 
     protected $description = 'List currently available deployments';
 
-    public function handle()
+    public function handle(): void
     {
         ConsoleOutput::line('');
         ConsoleOutput::alert('Available Deployments');
 
-        $deployments = AtomicDeployment::select(
+        $deployments = AtomicDeployment::query()->select([
             'id',
             'commit_hash',
             'deployment_path',
             'deployment_link',
             'deployment_status',
             'created_at',
-        )->get()->map(function ($deployment) {
+        ])->get()->map(function (AtomicDeployment $deployment) {
             $deployment->append('is_currently_deployed');
             $deployment->deployment_status = DeploymentStatus::getNameFromValue($deployment->deployment_status);
 

src/Helpers/ConsoleOutput.php

@@ -6,10 +6,11 @@
 
 /**
  * @method static void line(string $string)
+ * @method static void warn(string $string)
  * @method static void alert(string $string)
  * @method static void error(string $string)
  * @method static void info(string $string)
- * @method static void table(string $string)
+ * @method static void table(array $titles, array $rows)
  */
 class ConsoleOutput
 {

src/Interfaces/DeploymentInterface.php

@@ -23,4 +23,10 @@ public function getLink();
     public function getModel();
 
     public function updateStatus(int $status);
+
+    public function isDeployed(): bool;
+
+    public function getDirectoryName(): string;
+
+    public function createDirectory();
 }

src/Models/AtomicDeployment.php

@@ -18,6 +18,11 @@
  *
  * @property-read bool $has_deployment
  * @property-read bool $is_currently_deployed
+ * @property string $commit_hash
+ * @property int $deployment_status
+ * @property string $build_path
+ * @property string $deployment_path
+ * @property string $deployment_link
  */
 class AtomicDeployment extends Model
 {

src/Services/AtomicDeploymentService.php

@@ -5,6 +5,7 @@
 namespace JTMcC\AtomicDeployments\Services;
 
 use Closure;
+use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Pluralizer;
 use JTMcC\AtomicDeployments\Events\DeploymentFailed;
@@ -310,13 +311,15 @@ public function cleanBuilds(int $limit): void
             ->limit($limit)
             ->pluck('id');
 
-        $buildsToRemove = AtomicDeployment::whereNotIn('id', $buildIDs)->get();
+        /* @var Collection<AtomicDeployment> $buildsToRemove */
+        $buildsToRemove = AtomicDeployment::query()->whereNotIn('id', $buildIDs)->get();
 
         $countOfBuildsToRemove = $buildsToRemove->count();
 
         Output::info('Found '.$countOfBuildsToRemove.' '.Pluralizer::plural('folder', $countOfBuildsToRemove).' to be removed');
 
         foreach ($buildsToRemove as $deployment) {
+
             if ($deployment->is_currently_deployed) {
                 Output::warn('Current linked path has appeared in the directory cleaning logic');
                 Output::warn('This either means you currently have an old build deployed or there is a problem with your deployment data');
@@ -328,6 +331,7 @@ public function cleanBuilds(int $limit): void
             Output::info("Deleting {$deployment->commit_hash}");
 
             if (! $this->isDryRun()) {
+                // @phpstan-ignore-next-line
                 $deployment->delete();
                 Output::info('Deployment deleted');
             } else {

src/Services/Deployment.php

@@ -94,21 +94,15 @@ public function getCurrentPath(): string
     }
 
     /**
-     * @return string
-     *
      * @throws ExecuteFailedException
      */
-    public function getDirectoryName()
+    public function getDirectoryName(): string
     {
-        switch ($this->directoryNaming) {
-            case 'datetime':
-                return Carbon::now()->format('Y-m-d_H-i-s');
-            case 'rand':
-                return Str::random(5).time();
-            case 'git':
-            default:
-                return Exec::getGitHash();
-        }
+        return match ($this->directoryNaming) {
+            'datetime' => Carbon::now()->format('Y-m-d_H-i-s'),
+            'rand' => Str::random(5).time(),
+            default => Exec::getGitHash(),
+        };
     }
 
     /**