Improved fix for issue #95:

- Separated creation and initialization of the ribbon framework. Constructor will now only perform non UI/handle related initialization of the framework
- Load() will now call HandleNeeded before passing the parent form's handle to FFramework.Initialize. That way, recreating the window handle of the form no longer causes issues
- ApplicationModes are now restored when recreating the window handle

Author: SaschaSchaefer

Lib/UIRibbon.pas

@@ -656,10 +656,6 @@ constructor TUIRibbon.Create(AOwner: TComponent);
   end;
 
   Parent := ParentForm; // Make the form the parent of the ribbon control.
-
-  if csDesigning in ComponentState then
-    exit; // Initializing the ribbon doesn't work in design time, so exit here.
-
   LoadFramework;
 end;
 
@@ -1024,8 +1020,19 @@ procedure TUIRibbon.Load();
   Inst: THandle;
   lForm: TCustomForm;
 begin
+  // Don't try to load the framework at design time
+  if csDesigning in ComponentState then
+    exit;
+
+  if (not Available) then
+    Height := 0;
+
   if (Available) and (inherited Visible) and not (FLoaded) then
   begin
+    //Load the framework, using the parent form's handle
+    FLoaded := True;
+    HandleNeeded;
+    FFramework.Initialize(GetParentForm(Self.Owner as TControl).Handle, Self);
     // Load mapper for mapping between commands and VCL actions
     fRibbonMapper := TRibbonMarkupElementList.LookupListByResourceName(FResourceName);
     if Assigned(fRibbonMapper) then
@@ -1037,9 +1044,9 @@ procedure TUIRibbon.Load();
       Inst := FResourceInstance;
     try
       FFramework.LoadUI(Inst, PChar(FResourceName + '_RIBBON'));
-      FLoaded := True;
     except
       on E: EOleException do begin
+        FLoaded := False;
         E.Message := Format(sErrorLoadingRibbonRessource, [Self.ResourceName, e.Message, e.ErrorCode]);
         raise;
       end;
@@ -1049,6 +1056,10 @@ procedure TUIRibbon.Load();
     if roAutoPreserveState in Options then
       LoadRibbonSettings();
 
+    // Restore potential old application mode settings. Certain situations (e.g. RecreateWnd) will recreate the ribbon with the default modes, so we need to reapply them here.
+    if fApplicationModes <> [] then
+      Set_ApplicationModes(fApplicationModes);
+
     lForm := GetParentForm(Self);
     // Set the background color for the form if not yet defined. Use the same
     // color as the ribbon bar, just a bit more brightened, if themes are enabled.
@@ -1070,31 +1081,27 @@ procedure TUIRibbon.LoadFramework;
 var
   Intf: IUnknown;
 begin
+  // Don't try to load the framework at design time
   if (csDesigning in ComponentState) then
     exit;
-  FAvailable := Succeeded(CoCreateInstance(CLSID_UIRibbonFramework, nil,
-      CLSCTX_INPROC_SERVER or CLSCTX_LOCAL_SERVER, IUnknown, Intf));
-  if (not FAvailable) then
-    Height := 0
-  else
-  begin
-    FFramework := Intf as IUIFramework;
-    FFramework.Initialize(GetParentForm(Self.Owner as TControl).Handle, Self);
-  end;
+
+  FAvailable := Succeeded(CoCreateInstance(CLSID_UIRibbonFramework, nil, CLSCTX_INPROC_SERVER or CLSCTX_LOCAL_SERVER, IUnknown, Intf));
+  FFramework := Intf as IUIFramework;
 end;
 
 procedure TUIRibbon.CreateWnd;
 begin
   inherited;
-  LoadFramework(); // Always force reload of framework, see issue #95
-  Load();
+  Load;
 end;
 
 procedure TUIRibbon.DestroyWnd;
 begin
   inherited;
   if Assigned(FFramework) then
     FFramework := nil;
+  if (csRecreating in ControlState) then
+    LoadFramework;
   FCommands.Clear;
   fLoaded := False;
 end;