Skip to content

Commit 9b4b5de

Browse files
author
Joachim Marder
committed
Removed dependency on RC.exe, it is no longer needed.
1 parent 097e737 commit 9b4b5de

File tree

5 files changed

+15
-54
lines changed

5 files changed

+15
-54
lines changed

Designer/Bin/RibbonDesigner.exe

-173 KB
Binary file not shown.

Designer/Classes/Settings.pas

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ TSettings = class
1414
strict private
1515
FSettingsFilename: String;
1616
FRibbonCompilerPath: String;
17-
FResourceCompilerPath: String;
17+
_FResourceCompilerPath: String; // No longer needed
1818
FDelphiCompilerPath: String;
1919
private
2020
constructor Create(const Dummy: Integer); overload;
@@ -32,7 +32,6 @@ TSettings = class
3232
class property Instance: TSettings read FInstance;
3333

3434
property RibbonCompilerPath: String read FRibbonCompilerPath write FRibbonCompilerPath;
35-
property ResourceCompilerPath: String read FResourceCompilerPath write FResourceCompilerPath;
3635
property DelphiCompilerPath: String read FDelphiCompilerPath write FDelphiCompilerPath;
3736
end;
3837

@@ -87,10 +86,6 @@ constructor TSettings.Create(const Dummy: Integer);
8786
FRibbonCompilerPath := TPath.Combine(SdkPath, 'UICC.exe');
8887
if (not TFile.Exists(FRibbonCompilerPath)) then
8988
FRibbonCompilerPath := '';
90-
91-
FResourceCompilerPath := TPath.Combine(SdkPath, 'RC.exe');
92-
if (not TFile.Exists(FResourceCompilerPath)) then
93-
FResourceCompilerPath := '';
9489
end;
9590
end;
9691

@@ -114,13 +109,6 @@ constructor TSettings.Create(const Dummy: Integer);
114109
if (BdsPath <> '') then
115110
begin
116111
BdsPath := TPath.Combine(BdsPath, 'bin');
117-
if (FResourceCompilerPath = '') then
118-
begin
119-
FResourceCompilerPath := TPath.Combine(BdsPath, 'RC.exe');
120-
if (not TFile.Exists(FResourceCompilerPath)) then
121-
FResourceCompilerPath := '';
122-
end;
123-
124112
if (FDelphiCompilerPath = '') then
125113
begin
126114
FDelphiCompilerPath := TPath.Combine(BdsPath, 'DCC32.exe');
@@ -182,8 +170,6 @@ procedure TSettings.Load;
182170
begin
183171
if (Name = SN_RIBBON_COMPILER) and FileExists(Value) then
184172
FRibbonCompilerPath := Value
185-
else if (Name = SN_RESOURCE_COMPILER) and FileExists(Value) then
186-
FResourceCompilerPath := Value
187173
else if (Name = SN_DELPHI_COMPILER) and FileExists(Value) then
188174
FDelphiCompilerPath := Value;
189175
end;
@@ -217,7 +203,7 @@ procedure TSettings.Save;
217203
Writer.Indent := True;
218204
Writer.WriteStartElement(EN_SETTINGS);
219205
SaveSetting(SN_RIBBON_COMPILER, FRibbonCompilerPath);
220-
SaveSetting(SN_RESOURCE_COMPILER, FResourceCompilerPath);
206+
SaveSetting(SN_RESOURCE_COMPILER, _FResourceCompilerPath);
221207
SaveSetting(SN_DELPHI_COMPILER, FDelphiCompilerPath);
222208
Writer.WriteEndElement;
223209
Xml := Writer.AsXml;
@@ -236,8 +222,7 @@ procedure TSettings.Save;
236222

237223
function TSettings.ToolsAvailable: Boolean;
238224
begin
239-
Result := (FRibbonCompilerPath <> '') and (FResourceCompilerPath <> '')
240-
and (FDelphiCompilerPath <> '');
225+
Result := (FRibbonCompilerPath <> '') and (FDelphiCompilerPath <> '');
241226
end;
242227

243228
end.

Designer/FSettings.dfm

Lines changed: 8 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,16 @@ object FormSettings: TFormSettings
3030
Height = 13
3131
Caption = 'Ribbon Compiler'
3232
end
33-
object Label2: TLabel
34-
Left = 12
35-
Top = 51
36-
Width = 89
37-
Height = 13
38-
Caption = 'Resource Compiler'
39-
end
4033
object Label3: TLabel
4134
Left = 12
42-
Top = 78
35+
Top = 63
4336
Width = 145
4437
Height = 13
4538
Caption = 'Delphi Command Line Compiler'
4639
end
47-
object EditRibbonCompiler: TButtonedEdit
40+
object EditDelphiCompiler: TButtonedEdit
4841
Left = 163
49-
Top = 21
42+
Top = 60
5043
Width = 370
5144
Height = 21
5245
Images = ImageList
@@ -56,33 +49,21 @@ object FormSettings: TFormSettings
5649
RightButton.Visible = True
5750
TabOrder = 0
5851
OnChange = EditPathChange
59-
OnRightButtonClick = EditRibbonCompilerRightButtonClick
60-
end
61-
object EditResourceCompiler: TButtonedEdit
62-
Left = 163
63-
Top = 48
64-
Width = 370
65-
Height = 21
66-
Enabled = False
67-
RightButton.HotImageIndex = 1
68-
RightButton.ImageIndex = 0
69-
RightButton.PressedImageIndex = 1
70-
RightButton.Visible = True
71-
TabOrder = 1
52+
OnRightButtonClick = EditDelphiCompilerRightButtonClick
7253
end
73-
object EditDelphiCompiler: TButtonedEdit
54+
object EditRibbonCompiler: TButtonedEdit
7455
Left = 163
75-
Top = 75
56+
Top = 22
7657
Width = 370
7758
Height = 21
7859
Images = ImageList
7960
RightButton.HotImageIndex = 1
8061
RightButton.ImageIndex = 0
8162
RightButton.PressedImageIndex = 1
8263
RightButton.Visible = True
83-
TabOrder = 2
64+
TabOrder = 1
8465
OnChange = EditPathChange
85-
OnRightButtonClick = EditDelphiCompilerRightButtonClick
66+
OnRightButtonClick = EditRibbonCompilerRightButtonClick
8667
end
8768
end
8869
object ButtonOk: TButton

Designer/FSettings.pas

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,13 @@ interface
2121
TFormSettings = class(TForm)
2222
GroupBoxPaths: TGroupBox;
2323
Label1: TLabel;
24-
EditRibbonCompiler: TButtonedEdit;
25-
Label2: TLabel;
26-
EditResourceCompiler: TButtonedEdit;
2724
EditDelphiCompiler: TButtonedEdit;
2825
Label3: TLabel;
2926
ImageList: TImageList;
3027
ButtonOk: TButton;
3128
ButtonCancel: TButton;
3229
OpenDialog: TOpenDialog;
30+
EditRibbonCompiler: TButtonedEdit;
3331
procedure EditPathChange(Sender: TObject);
3432
procedure EditRibbonCompilerRightButtonClick(Sender: TObject);
3533
procedure EditDelphiCompilerRightButtonClick(Sender: TObject);
@@ -57,7 +55,6 @@ constructor TFormSettings.Create(const Settings: TSettings);
5755
inherited Create(nil);
5856
FSettings := Settings;
5957
EditRibbonCompiler.Text := FSettings.RibbonCompilerPath;
60-
EditResourceCompiler.Text := FSettings.ResourceCompilerPath;
6158
EditDelphiCompiler.Text := FSettings.DelphiCompilerPath;
6259
UpdateControls;
6360
end;
@@ -90,18 +87,15 @@ procedure TFormSettings.FormClose(Sender: TObject; var Action: TCloseAction);
9087
if (ModalResult = mrOk) then
9188
begin
9289
FSettings.RibbonCompilerPath := EditRibbonCompiler.Text;
93-
FSettings.ResourceCompilerPath := EditResourceCompiler.Text;
9490
FSettings.DelphiCompilerPath := EditDelphiCompiler.Text;
9591
FSettings.Save;
9692
end;
9793
end;
9894

9995
procedure TFormSettings.UpdateControls;
10096
begin
101-
EditResourceCompiler.Text := IncludeTrailingPathDelimiter(ExtractFilePath(EditRibbonCompiler.Text)) + 'RC.exe';
10297
ButtonOk.Enabled :=
10398
TFile.Exists(EditRibbonCompiler.Text) and
104-
TFile.Exists(EditResourceCompiler.Text) and
10599
TFile.Exists(EditDelphiCompiler.Text);
106100
end;
107101

Designer/RibbonDesigner.dproj

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,15 @@
3030
<Base>true</Base>
3131
</PropertyGroup>
3232
<PropertyGroup Condition="'$(Base)'!=''">
33+
<VerInfo_Release>2</VerInfo_Release>
3334
<VerInfo_MajorVer>2</VerInfo_MajorVer>
3435
<Manifest_File>$(BDS)\bin\default_app.manifest</Manifest_File>
35-
<VerInfo_Build>70</VerInfo_Build>
36+
<VerInfo_Build>72</VerInfo_Build>
3637
<DCC_Namespace>Vcl;Vcl.Imaging;Vcl.Touch;Vcl.Samples;Vcl.Shell;System;Xml;Data;Datasnap;Web;Soap;Winapi;System.Win;$(DCC_Namespace)</DCC_Namespace>
3738
<VerInfo_Locale>1033</VerInfo_Locale>
3839
<SanitizedProjectName>RibbonDesigner</SanitizedProjectName>
3940
<VerInfo_IncludeVerInfo>true</VerInfo_IncludeVerInfo>
40-
<VerInfo_Keys>CompanyName=Erik van Bilsen AudioVisuality;FileDescription=Ribbon Designer;FileVersion=2.0.0.70;InternalName=;LegalCopyright=© 2011 Erik van Bilsen, Joachim Marder e.K.;LegalTrademarks=;OriginalFilename=;ProductName=;ProductVersion=2.0;Comments=</VerInfo_Keys>
41+
<VerInfo_Keys>CompanyName=;FileDescription=Ribbon Designer;FileVersion=2.0.2.72;InternalName=;LegalCopyright=© 2011 Erik van Bilsen, Joachim Marder e.K.;LegalTrademarks=;OriginalFilename=;ProductName=;ProductVersion=2.0;Comments=</VerInfo_Keys>
4142
<DCC_UnitSearchPath>..\Lib;$(DCC_UnitSearchPath)</DCC_UnitSearchPath>
4243
<DCC_DependencyCheckOutputName>RibbonDesigner.exe</DCC_DependencyCheckOutputName>
4344
<DCC_ImageBase>00400000</DCC_ImageBase>

0 commit comments

Comments
 (0)