fix(NO_STD): touchups needed for rebase of current master

Author: JBenda

inkcpp/runner_impl.h

@@ -273,7 +273,14 @@ class runner_impl
 			_threadDone.forget();
 		}
 
-		void set(size_t index, const ip_t& value) { _threadDone.set(index, value); }
+		void set(size_t index, const ip_t& value)
+		{
+			if (index >= _threadDone.capacity()) {
+				inkAssert(index == _threadDone.capacity(), "Threads should only be created incremental");
+				_threadDone.resize(_threadDone.capacity() * 1.5);
+			}
+			_threadDone.set(index, value);
+		}
 
 		const ip_t& get(size_t index) const { return _threadDone.get(index); }
 

inkcpp_test/Fixes.cpp

@@ -169,6 +169,7 @@ SCENARIO(
 		}
 	}
 }
+
 SCENARIO("Casting during redefinition is too strict _ #134", "[fixes]")
 {
 	GIVEN("story with problematic text")
@@ -248,4 +249,48 @@ SCENARIO("Using knot visit count as condition _ #139", "[fixes]")
 			}
 		}
 	}
-}
+}
+
+SCENARIO("Provoke thread array expension _ #142", "[fixes]")
+{
+	GIVEN("story with 15 threads in one know")
+	{
+		std::unique_ptr<story> ink{story::from_file(INK_TEST_RESOURCE_DIR "142_many_threads.bin")};
+		runner                 thread = ink->new_runner();
+		WHEN("just go to choice")
+		{
+			std::string content = thread->getall();
+			REQUIRE(content == "At the top\n");
+			THEN("expect to see 15 choices")
+			{
+				REQUIRE(thread->num_choices() == 15);
+				const char options[] = "abcdefghijklmno";
+				for (const char* c = options; *c; ++c) {
+					CHECK(thread->get_choice(c - options)->text()[0] == *c);
+				}
+			}
+		}
+		WHEN("choose 5 options")
+		{
+			std::string content = thread->getall();
+			for (int i = 0; i < 5; ++i) {
+				REQUIRE_FALSE(thread->can_continue());
+				thread->choose(i);
+				content += thread->getall();
+			}
+			REQUIRE(
+			    content
+			    == "At the top\na\nAt the top\nc\nAt the top\ne\nAt the top\ng\nAt the top\ni\nAt the "
+			       "top\n"
+			);
+			THEN("only 11 choices are left")
+			{
+				REQUIRE(thread->num_choices() == 10);
+				const char* options = "bdfhjklmno";
+				for (const char* c = options; *c; ++c) {
+					CHECK(thread->get_choice(c - options)->text()[0] == *c);
+				}
+			}
+		}
+	}
+}

inkcpp_test/ink/142_many_threads.ink

@@ -0,0 +1,95 @@
+-> top
+
+=== top ===
+At the top
+<- thread_a
+<- thread_b
+<- thread_c
+<- thread_d
+<- thread_e
+<- thread_f
+<- thread_g
+<- thread_h
+<- thread_i
+<- thread_j
+<- thread_k
+<- thread_l
+<- thread_m
+<- thread_n
+<- thread_o
+-> DONE
+
+= thread_a
+* [a]
+    a
+    -> top
+
+= thread_b
+* [b]
+    b
+    -> top
+
+= thread_c
+* [c]
+    c
+    -> top
+
+= thread_d
+* [d]
+    d
+    -> top
+
+= thread_e
+* [e]
+    e
+    -> top
+
+= thread_f
+* [f]
+    f
+    -> top
+
+= thread_g
+* [g]
+    g
+    -> top
+
+= thread_h
+* [h]
+    h
+    -> top
+
+= thread_i
+* [i]
+    i
+    -> top
+
+= thread_j
+* [j]
+    j
+    -> top
+
+= thread_k
+* [k]
+    k
+    -> top
+
+= thread_l
+* [l]
+    l
+    -> top
+
+= thread_m
+* [m]
+    m
+    -> top
+
+= thread_n
+* [n]
+    n
+    -> top
+
+= thread_o
+* [o]
+    o
+    -> top