build: improve cpp-std.js to detect Electron versions

Author: JCMais

README.md

@@ -62,7 +62,6 @@
   - [Electron / NW.js](#electron--nwjs)
     - [NW.js (aka node-webkit)](#nwjs-aka-node-webkit)
     - [Electron (aka atom-shell)](#electron-aka-atom-shell)
-    - [Electron \>= 11 / NW.js \>= 0.50](#electron--11--nwjs--050)
   - [Building on Linux](#building-on-linux)
   - [Building on macOS](#building-on-macos)
     - [Xcode \>= 10 | macOS \>= Mojave](#xcode--10--macos--mojave)
@@ -276,7 +275,7 @@ Features: AsynchDNS, IDN, IPv6, Largefile, NTLM, NTLM_WB, SSL, libz, brotli, TLS
 
 If there is no prebuilt binary available that matches your system, or if the installation fails, then you will need an environment capable of compiling Node.js addons, which means:
 - [python 3.x](https://www.python.org/downloads/) installed
-- updated C++ compiler able to compile C++11, or if building Electron >= 11 / NW.js >= 0.50, C++17 (see the [Electron >= 11 / NW.js >= 0.50](#electron--11--nwjs--050) section below).
+- updated C++ compiler able to compile C++17 (C++20 for Electron >= v32).
 
 If you don't want to use the prebuilt binary even if it works on your system, you can pass a flag when installing:
 > With `npm`
@@ -372,19 +371,6 @@ target_arch = x64
 dist_url = https://atom.io/download/atom-shell
 ```
 
-#### Electron >= 11 / NW.js >= 0.50
-
-If you are building for Electron >= 11 or NW.js >= 0.50 you need to set the build process to use the C++17 std, you can do that by passing the variable `node_libcurl_cpp_std=c++17`. The way you do that depends if you are using `npm` or `yarn`:
-
-> If using `npm`:
-```sh
-npm install node-libcurl --node_libcurl_cpp_std=c++17 <...other args...>
-```
-> If using `yarn`:
-```sh
-npm_config_node_libcurl_cpp_std=c++17 <...other args...> yarn add node-libcurl
-```
-
 ### Building on Linux
 
 To build the addon on linux based systems you must have:

binding.gyp

@@ -11,7 +11,7 @@
     'curl_static_build%': 'false',
     'curl_config_bin%': 'node <(module_root_dir)/scripts/curl-config.js',
     'node_libcurl_no_setlocale%': 'false',
-    'node_libcurl_cpp_std%': '<!(node <(module_root_dir)/scripts/cpp-std.js)',
+    'node_libcurl_cpp_std%': '<!(node <(module_root_dir)/scripts/cpp-std.js <(node_root_dir))',
     'macos_universal_build%': 'false',
   },
   'targets': [

scripts/cpp-std.js

@@ -4,13 +4,48 @@
  * This source code is licensed under the MIT license found in the
  * LICENSE file in the root directory of this source tree.
  */
+const isGreaterOrEqual = (a, b) => {
+  return a.localeCompare(b, undefined, { numeric: true }) >= 0
+}
+
 if (process.env.NODE_LIBCURL_CPP_STD) {
   console.log(process.env.NODE_LIBCURL_CPP_STD)
 } else {
-  if (process.versions.modules && parseInt(process.versions.modules) >= 88) {
+  // e.g: '/Users/jcm/.electron-gyp/32.2.6'
+  const nodeRootDir = process.argv[2]
+
+  // detect electron related env vars coming from
+  // npm flags, e.g: npm_config_runtime
+  // we could also use node-abi here!
+  const isElectron =
+    process.env['npm_config_runtime'] === 'electron' ||
+    nodeRootDir.includes('electron-gyp')
+  const electronVersion = isElectron
+    ? process.env['npm_config_target'] ?? nodeRootDir.split('/').pop()
+    : null
+
+  if (isElectron) {
+    if (isGreaterOrEqual(electronVersion, '32.0.0')) {
+      console.log('c++20')
+    } else if (isGreaterOrEqual(electronVersion, '13.0.0')) {
+      console.log('c++17')
+    } else {
+      console.log('c++98')
+    }
+  }
+
+  // https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json
+  // https://github.com/nodejs/node/blob/main/doc/abi_version_registry.json
+  // 129 === Node.js v23
+  if (process.versions.modules && parseInt(process.versions.modules) >= 129) {
+    console.log('c++20')
+  } else if (
+    process.versions.modules &&
+    parseInt(process.versions.modules) >= 88
+  ) {
     // 88 === Node.js v15
     console.log('c++17')
   } else {
-    console.log('c++11')
+    console.log('c++98')
   }
 }