Tidied up after review.

Author: odlomax

src/atlas/interpolation/method/cubedsphere/CubedSphereBilinear.cc

@@ -6,14 +6,12 @@
  */
 
 #include "atlas/interpolation/method/cubedsphere/CubedSphereBilinear.h"
-#include <variant>
 #include "atlas/functionspace/NodeColumns.h"
 #include "atlas/grid/CubedSphereGrid.h"
 #include "atlas/interpolation/method/MethodFactory.h"
 #include "atlas/interpolation/method/cubedsphere/CellFinder.h"
 #include "atlas/parallel/omp/omp.h"
 #include "atlas/util/CoordinateEnums.h"
-#include "eckit/utils/Overloaded.h"
 
 namespace atlas {
 namespace interpolation {

src/tests/interpolation/test_interpolation_cubedsphere.cc

@@ -13,7 +13,6 @@
 #include "atlas/functionspace/PointCloud.h"
 #include "atlas/grid/Distribution.h"
 #include "atlas/grid/Grid.h"
-#include "atlas/grid/Iterator.h"
 #include "atlas/grid/Partitioner.h"
 #include "atlas/interpolation/Interpolation.h"
 #include "atlas/mesh/Mesh.h"
@@ -69,28 +68,6 @@ double dotProd(const Field& a, const Field& b) {
     return prod;
 }
 
-CASE("temporary const lvalue reference test") {
-
-    const auto grid = CubedSphereInterpolationFixture{}.sourceGrid_;
-
-    auto iterator = grid.lonlat().begin();
-    const auto begin = iterator;
-    for (idx_t i = 0; i < grid.size(); ++i) {
-
-        // This does not dangle, because C++ makes no sense!
-        const auto& lonLat = *(begin + i);
-        const auto refLonLat = *iterator;
-        ++iterator;
-
-        EXPECT_APPROX_EQ(lonLat.lon(), refLonLat.lon(), 1e-14);
-        EXPECT_APPROX_EQ(lonLat.lat(), refLonLat.lat(), 1e-14);
-
-        // Only now, *(begin + i), do you have my permission to die.
-    }
-
-
-}
-
 CASE("cubedsphere_to_cubedsphere_interpolation") {
 
     // Check that interpolation scheme correctly maps a cubedsphere on to itself.