Skip to content

Commit c4cb0ce

Browse files
committed
Only request data if user is logged in and admin, only allow API access to admins
1 parent 2d01d96 commit c4cb0ce

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

octoprint_netconnectd/__init__.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,9 @@ def get_api_commands(self):
6464
reset=[]
6565
)
6666

67+
def is_api_adminonly(self):
68+
return True
69+
6770
def on_api_get(self, request):
6871
try:
6972
wifis = self._get_wifi_list()

octoprint_netconnectd/static/js/netconnectd.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -298,13 +298,14 @@ $(function() {
298298
});
299299
};
300300

301-
self.onBeforeBinding = function() {
302-
self.settings = self.settingsViewModel.settings;
303-
self.requestData();
301+
self.onUserLoggedIn = function(user) {
302+
if (user.admin) {
303+
self.requestData();
304+
}
304305
};
305306

306-
self.onDataUpdaterReconnect = function() {
307-
self.requestData();
307+
self.onBeforeBinding = function() {
308+
self.settings = self.settingsViewModel.settings;
308309
};
309310

310311
self.onSettingsShown = function() {

0 commit comments

Comments
 (0)