Skip to content

Commit d92a6f5

Browse files
authored
changes supporting ai-runner upgrade to comfystream 0.0.4 (yondonfu#56)
* set comfystream as default conda env add ffmpeg6, use conda-forge dockerfile cleanup
1 parent 91d897c commit d92a6f5

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

docker/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ RUN bash -c "source $NVM_DIR/nvm.sh && \
2323
ENV NODE_PATH="$NVM_DIR/v$NODE_VERSION/lib/node_modules" \
2424
PATH="$NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH"
2525

26-
RUN conda init bash
2726

2827
# Create the supervisor configuration file for ComfyUI and ComfyStream
2928
COPY docker/supervisord.conf /etc/supervisor/conf.d/supervisord.conf

docker/Dockerfile.base

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,15 @@ RUN mkdir -p /workspace/comfystream && \
2727
wget "https://repo.anaconda.com/miniconda/Miniconda3-${CONDA_VERSION}-Linux-x86_64.sh" -O /tmp/miniconda.sh && \
2828
bash /tmp/miniconda.sh -b -p /workspace/miniconda3 && \
2929
eval "$(/workspace/miniconda3/bin/conda shell.bash hook)" && \
30-
conda create -n comfystream python="${PYTHON_VERSION}" -y && \
31-
rm /tmp/miniconda.sh && \
32-
conda run -n comfystream --no-capture-output pip install aiortc aiohttp requests tqdm pyyaml --root-user-action=ignore
30+
conda create -n comfystream python="${PYTHON_VERSION}" ffmpeg=6 -c conda-forge -y && \
31+
rm /tmp/miniconda.sh && echo 'export LD_LIBRARY_PATH=/workspace/miniconda3/envs/comfystream/lib:$LD_LIBRARY_PATH' >> ~/.bashrc
3332

3433
# Clone ComfyUI
35-
ADD --link https://github.com/comfyanonymous/ComfyUI.git /workspace/ComfyUI
34+
RUN git clone https://github.com/comfyanonymous/ComfyUI.git /workspace/ComfyUI
3635

3736
# Copy only files needed for setup
38-
COPY --link ./src/comfystream/scripts /workspace/comfystream/src/comfystream/scripts
39-
COPY --link ./configs /workspace/comfystream/configs
40-
41-
# Run setup_nodes (cached unless setup_nodes.py or nodes/ changes)
42-
RUN conda run -n comfystream --no-capture-output --cwd /workspace/comfystream python src/comfystream/scripts/setup_nodes.py --workspace /workspace/ComfyUI
37+
COPY ./src/comfystream/scripts /workspace/comfystream/src/comfystream/scripts
38+
COPY ./configs /workspace/comfystream/configs
4339

4440
# Copy ComfyStream files into ComfyUI
4541
COPY . /workspace/comfystream
@@ -52,14 +48,24 @@ COPY ./test/example-512x512.png /workspace/ComfyUI/input
5248
RUN conda run -n comfystream --no-capture-output --cwd /workspace/ComfyUI pip install -r requirements.txt --root-user-action=ignore
5349

5450
# Install ComfyStream requirements
55-
RUN conda run -n comfystream --no-capture-output --cwd /workspace/comfystream pip install -r requirements.txt --root-user-action=ignore
56-
RUN conda run -n comfystream --no-capture-output --cwd /workspace/comfystream pip install . --root-user-action=ignore
5751
RUN ln -s /workspace/comfystream /workspace/ComfyUI/custom_nodes/comfystream
52+
RUN conda run -n comfystream --no-capture-output --cwd /workspace/comfystream pip install -e . --root-user-action=ignore
5853
RUN conda run -n comfystream --no-capture-output --cwd /workspace/comfystream python install.py --workspace /workspace/ComfyUI
54+
55+
# Run setup_nodes
56+
RUN conda run -n comfystream --no-capture-output --cwd /workspace/comfystream python src/comfystream/scripts/setup_nodes.py --workspace /workspace/ComfyUI
57+
58+
# Install additional dependencies
5959
RUN conda run -n comfystream --no-capture-output pip install --upgrade tensorrt-cu12-bindings tensorrt-cu12-libs --root-user-action=ignore
6060

6161
# Configure no environment activation by default
6262
RUN conda config --set auto_activate_base false && \
6363
conda init bash
6464

65+
# Set comfystream environment as default
66+
#TODO if this dockerfile will support other pipelines, we need to not always activate comfystream
67+
RUN echo "source /workspace/miniconda3/etc/profile.d/conda.sh && conda activate comfystream" >> /conda_activate.sh && \
68+
chmod +x /conda_activate.sh
69+
ENV BASH_ENV=/conda_activate.sh
70+
6571
WORKDIR /workspace/comfystream

0 commit comments

Comments
 (0)