Add context menu for each Unity objects in built-in inspector.

JLChnToZ · JLChnToZ · commit fa1e8c1db7b1 · 2023-03-09T15:10:48.000+08:00
Fix property/field setters on copy value mode.
diff --git a/Editor/UInspectorPlus/Helpers.cs b/Editor/UInspectorPlus/Helpers.cs
@@ -404,11 +404,9 @@ private static int CountLines(this string str) {
 
         internal static bool AssignValue(MemberInfo info, object target, object value, params object[] index) {
             try {
-                var fieldInfo = info as FieldInfo;
-                var propertyInfo = info as PropertyInfo;
-                if (fieldInfo != null && !fieldInfo.IsInitOnly && !fieldInfo.IsLiteral)
+                if (info is FieldInfo fieldInfo && !fieldInfo.IsInitOnly && !fieldInfo.IsLiteral)
                     fieldInfo.SetValue(target, value);
-                else if (propertyInfo != null && propertyInfo.CanWrite)
+                else if (info is PropertyInfo propertyInfo && propertyInfo.CanWrite)
                     propertyInfo.SetValue(target, value, index);
                 else
                     return false;
@@ -419,23 +417,19 @@ internal static bool AssignValue(MemberInfo info, object target, object value, p
         }
 
         internal static bool IsReadOnly(this MemberInfo info) {
-            var fieldInfo = info as FieldInfo;
-            if (fieldInfo != null)
+            if (info is FieldInfo fieldInfo)
                 return fieldInfo.IsInitOnly || fieldInfo.IsLiteral;
-            var propertyInfo = info as PropertyInfo;
-            if (propertyInfo != null)
+            if (info is PropertyInfo propertyInfo)
                 return !propertyInfo.CanWrite;
             return false;
         }
 
         internal static bool FetchValue(this MemberInfo info, object target, out object value, params object[] index) {
             value = null;
             try {
-                var fieldInfo = info as FieldInfo;
-                var propertyInfo = info as PropertyInfo;
-                if (fieldInfo != null)
+                if (info is FieldInfo fieldInfo)
                     value = fieldInfo.GetValue(target);
-                else if (propertyInfo != null && propertyInfo.CanRead)
+                else if (info is PropertyInfo propertyInfo && propertyInfo.CanRead)
                     value = propertyInfo.GetValue(target, index);
                 else
                     return false;
@@ -547,6 +541,16 @@ public static IEnumerable<Type> LooseGetTypes(this Assembly assembly) {
         [MenuItem("Window/JLChnToZ/Inspector+")]
         public static void ShowInspectorPlus() => EditorWindow.GetWindow(typeof(InspectorPlus));
 
+        [MenuItem("CONTEXT/Object/Open Inspector+...", false, int.MaxValue)]
+        public static void ShowInspectorPlus(MenuCommand command) => InspectorChildWindow.Open(
+            command.context,
+            EditorPrefs.GetBool("inspectorplus_props", true),
+            EditorPrefs.GetBool("inspectorplus_private", true),
+            EditorPrefs.GetBool("inspectorplus_obsolete", false),
+            EditorPrefs.GetBool("inspectorplus_methods", true),
+            true, null
+        );
+
         public static void PrintExceptionsWithInner(Exception ex) {
             do {
                 Debug.LogException(ex);
diff --git a/Editor/UInspectorPlus/InspectorChildWindow.cs b/Editor/UInspectorPlus/InspectorChildWindow.cs
@@ -1,6 +1,7 @@
 ﻿using UnityEngine;
 using UnityEditor;
 using System;
+using UnityObject = UnityEngine.Object;
 
 namespace JLChnToZ.EditorExtensions.UInspectorPlus {
     internal class InspectorChildWindow: EditorWindow {
@@ -14,6 +15,7 @@ internal class InspectorChildWindow: EditorWindow {
         private bool showPrivate;
         private bool showObsolete;
         private bool showMethods;
+        private Rect menuButtonRect;
 
         public static void Open(object target, bool showProps, bool showPrivate, bool showObsolete, bool showMethods, bool updateProps, MethodPropertyDrawer parent) =>
             CreateInstance<InspectorChildWindow>().InternalOpen(target, target.GetType(), showProps, showPrivate, showObsolete, showMethods, updateProps, parent);
@@ -25,14 +27,14 @@ private void InternalOpen(object target, Type targetType, bool showProps, bool s
             titleContent = new GUIContent($"{target ?? targetType} - Inspector+");
             if (target == null && targetType.ContainsGenericParameters) {
                 resolver = new TypeResolverGUI(targetType);
-                this.showProps = showProps;
-                this.showPrivate = showPrivate;
-                this.showObsolete = showObsolete;
-                this.showMethods = showMethods;
             } else {
                 drawer = InspectorDrawer.GetDrawer(target, targetType, true, showProps, showPrivate, showObsolete, showMethods);
                 drawer.OnRequireRedraw += Repaint;
             }
+            this.showProps = showProps;
+            this.showPrivate = showPrivate;
+            this.showObsolete = showObsolete;
+            this.showMethods = showMethods;
             this.parent = parent;
             this.updateProps = updateProps;
             ShowUtility();
@@ -58,10 +60,28 @@ private void OnGUI() {
                 return;
             }
             GUILayout.BeginHorizontal(EditorStyles.toolbar);
-            updateProps = GUILayout.Toggle(updateProps, "Update Props", EditorStyles.toolbarButton);
-            GUILayout.Space(8);
             drawer.searchText = Helper.ToolbarSearchField(drawer.searchText ?? string.Empty);
             GUILayout.FlexibleSpace();
+            if (drawer.target is UnityObject uObject) {
+                if (GUILayout.Button("Ping", EditorStyles.toolbarButton, GUILayout.ExpandWidth(false)))
+                    EditorGUIUtility.PingObject(uObject);
+                if (GUILayout.Button("Select", EditorStyles.toolbarButton, GUILayout.ExpandWidth(false)))
+                    Selection.activeObject = uObject;
+                if (GUILayout.Button(EditorGUIUtility.IconContent("TreeEditor.Trash", "Destroy"),
+                    EditorStyles.toolbarButton, GUILayout.ExpandWidth(false)) && EditorUtility.DisplayDialog(
+                        "Destroy object",
+                        $"Destroy {uObject.GetType()} {uObject.name} (Instance ID: {uObject.GetInstanceID()})?",
+                        "Yes", "No"
+                    )) {
+                    DestroyImmediate(uObject);
+                    Close();
+                }
+                GUILayout.Space(8);
+            }
+            if (GUILayout.Button(EditorGUIUtility.IconContent("_Menu", "Menu"), EditorStyles.toolbarButton, GUILayout.ExpandWidth(false)))
+                OpenMenu(menuButtonRect);
+            if (Event.current.type == EventType.Repaint)
+                menuButtonRect = GUILayoutUtility.GetLastRect();
             GUILayout.EndHorizontal();
             scrollPos = GUILayout.BeginScrollView(scrollPos);
             EditorGUILayout.Space();
@@ -78,6 +98,34 @@ private void OnGUI() {
             GUILayout.EndScrollView();
         }
 
+        private void OpenMenu(Rect position) {
+            var menu = new GenericMenu();
+            menu.AddItem(new GUIContent("Update Properties"), updateProps, () => {
+                updateProps = !updateProps;
+            });
+            menu.AddItem(new GUIContent("Show Properties"), showProps, () => {
+                showProps = !showProps;
+                RefreshDrawer();
+                EditorPrefs.SetBool("inspectorplus_props", showProps);
+            });
+            menu.AddItem(new GUIContent("Show Methods"), showMethods, () => {
+                showMethods = !showMethods;
+                RefreshDrawer();
+                EditorPrefs.SetBool("inspectorplus_methods", showMethods);
+            });
+            menu.AddItem(new GUIContent("Show Private Members"), showPrivate, () => {
+                showPrivate = !showPrivate;
+                RefreshDrawer();
+                EditorPrefs.SetBool("inspectorplus_private", showPrivate);
+            });
+            menu.AddItem(new GUIContent("Show Obsolete Members"), showObsolete, () => {
+                showObsolete = !showObsolete;
+                RefreshDrawer();
+                EditorPrefs.SetBool("inspectorplus_obsolete", showObsolete);
+            });
+            menu.DropDown(position);
+        }
+
         private void OnDestroy() => drawer?.Dispose();
 
         private void OnInspectorUpdate() {
@@ -86,6 +134,16 @@ private void OnInspectorUpdate() {
             UpdateValues();
         }
 
+        private void RefreshDrawer() {
+            if (drawer == null) return;
+            var target = drawer.target;
+            if (target.IsInvalid()) return;
+            drawer.Dispose();
+            drawer = InspectorDrawer.GetDrawer(target, target.GetType(), true, showProps, showPrivate, showObsolete, showMethods);
+            drawer.OnRequireRedraw += Repaint;
+            UpdateValues();
+        }
+
         private void UpdateValues() {
             if (drawer == null) {
                 if (resolver == null) Close();
diff --git a/Editor/UInspectorPlus/InspectorDrawer.cs b/Editor/UInspectorPlus/InspectorDrawer.cs
@@ -218,8 +218,7 @@ private void DrawRequestRefs() {
             foreach (var drawer in MethodPropertyDrawer.drawerRequestingReferences)
                 if (drawer.requiredType.IsAssignableFrom(targetType) &&
                     GUILayout.Button($"Assign this object to {drawer.name}")) {
-                    drawer.Value = target;
-                    drawer.SetDirty();
+                    drawer.TryApplyValue(target);
                     removal = drawer;
                 }
             if (removal != null) MethodPropertyDrawer.drawerRequestingReferences.Remove(removal);
diff --git a/Editor/UInspectorPlus/MethodPropertyDrawer.cs b/Editor/UInspectorPlus/MethodPropertyDrawer.cs
@@ -366,6 +366,12 @@ public void Draw(bool readOnly, Rect? rect = null) {
         public bool UpdateIfChanged() {
             if (!Changed)
                 return false;
+            return TryApplyValue(rawValue);
+        }
+
+        public bool TryApplyValue(object newValue) {
+            rawValue = newValue;
+            hasGetValue = true;
             if (Helper.AssignValue(memberInfo, target, Value, indexParams))
                 return true;
             UpdateValue();
@@ -445,8 +451,7 @@ private bool DrawAssignButton(Rect? rect) {
                         GUI.Button(rect.Value, EditorGUIUtility.IconContent("Linked"), EditorStyles.miniLabel) :
                         GUILayout.Button(EditorGUIUtility.IconContent("Linked"), EditorStyles.miniLabel, GUILayout.ExpandWidth(false))
                     ) {
-                        drawer.Value = rawValue;
-                        drawer.SetDirty();
+                        drawer.TryApplyValue(rawValue);
                         finishedDrawer = drawer;
                     }
                 }
@@ -768,9 +773,9 @@ private void ShowMenu(Rect position) {
                     case PropertyType.Unknown:
                     case PropertyType.Type:
                         menu.AddItem(new GUIContent("Mode/Construct"), grabValueMode == 2, GrabValueMode, 2);
-                        menu.AddItem(new GUIContent("Mode/From Opened Inspectors"), grabValueMode == 3, GrabValueMode, 3);
                         break;
                 }
+                menu.AddItem(new GUIContent("Mode/From Opened Inspectors"), grabValueMode == 3, GrabValueMode, 3);
             }
             if (currentType == PropertyType.Enum)
                 menu.AddItem(new GUIContent("Multiple Selection"), masked, ChangeMultiSelect, !masked);
