Skip to content

Commit 339ddc6

Browse files
authored
Merge pull request #2 from JLDC/fix-results
Fix double call issue to results
2 parents 40455a9 + cd9b069 commit 339ddc6

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,4 +158,6 @@ cython_debug/
158158
# and can be added to the global gitignore or merged into this file. For a more nuclear
159159
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
160160
#.idea/
161-
.vscode
161+
.vscode
162+
163+
pipeline.md

model_confidence_set/core.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -251,14 +251,14 @@ def results(self, as_dataframe: bool = True) -> Union[dict, pd.DataFrame]:
251251

252252
idx = np.concatenate([self.excluded, self.included]).astype(int) - 1
253253

254-
self.results = {
254+
self.results_dict = {
255255
"pvalues": self.pvalues,
256256
"status": np.where(self.pvalues >= self.alpha, "included", "excluded"),
257257
"models": self.model_names[idx],
258258
}
259259
if as_dataframe:
260-
df = pd.DataFrame(self.results)
260+
df = pd.DataFrame(self.results_dict)
261261
df.index = df.pop("models")
262262
return df
263263
else:
264-
return self.results
264+
return self.results_dict

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
setup(
1111
name="model-confidence-set",
12-
version="0.1.2",
12+
version="0.1.3",
1313
license="MIT",
1414
description="model-confidence-set provides a Python implementation of the Model Confidence Set (MCS) procedure (Hansen, Lunde, and Nason, 2011), a statistical method for comparing and selecting models based on their performance.",
1515
long_description=long_description,

0 commit comments

Comments
 (0)