Skip to content

Commit 545a586

Browse files
committed
Fixed delete folder bugs
1 parent 363607f commit 545a586

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

OpenNote/openNote/controllers/folderController.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,14 @@ openNote.controller("folderController", function( $scope,
188188
if(!confirm)
189189
return;
190190

191-
var parrentFolderID = $scope.currentFolder.parrentFolderID;
191+
var parentFolderID = $scope.currentFolder.parentFolderID;
192192
storageService.deleteFolder($scope.currentFolder, function(){
193193
$rootScope.$emit("reloadListView", {});
194194

195-
if(!parrentFolderID)
195+
if(!parentFolderID)
196196
$location.url("/folder/");
197197
else
198-
$location.url("/folder/"+parrentFolderID);
198+
$location.url("/folder/"+parentFolderID);
199199

200200
$scope.$apply();
201201
});
@@ -206,7 +206,7 @@ openNote.controller("folderController", function( $scope,
206206
* Listen to changed folder events to see if its the current open folder
207207
*/
208208
$rootScope.$on("changedFolder", function(event, request) {
209-
if(request.folder.parrentFolderID==$scope.currentFolder.id || $scope.currentFolder.id==request.oldParrentFolderID){//does the change effect us?
209+
if(request.folder.parentFolderID==$scope.currentFolder.id || $scope.currentFolder.id==request.oldparentFolderID){//does the change effect us?
210210
$scope.loadCurrentFolder();//reload
211211
}
212212
});

OpenNote/openNote/services/storageService.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,18 +154,17 @@ openNote.service("storageService", function ($rootScope) {
154154
* @param folder - the folder doc to delete
155155
* @param callback - callback when the given folder has been removed
156156
*/
157-
this.deleteFolder = function(folder,callback){
158-
self.loadFolderContents(folder.id, function (results) {
157+
this.deleteFolder = function(folder,callback){//TODO test
158+
self.loadFolderContents(folder._id, function (results) {
159159
results.rows.filter(self.noteFilter).forEach(function(note){
160160
localDatabase.remove(note.doc);
161161
});
162162

163163
results.rows.filter(self.folderFilter).forEach(function(subFolder){
164164
self.deleteFolder(subFolder);
165165
});
166+
localDatabase.remove(folder).then(callback);
166167
});
167-
168-
localDatabase.remove(folder.doc).then(callback);
169168
};
170169

171170

0 commit comments

Comments
 (0)