Skip to content

Commit 6278d6e

Browse files
committed
Fixed tag bug. Tags were getting confused with MD headers
1 parent 04358b7 commit 6278d6e

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

build/webpack.common.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const glob = require("glob");
22

33
module.exports = {
4-
entry: glob.sync("./openNote/**/*.js"),
4+
entry: glob.sync("./openNote/**/*.js"),//Emulate loading all them sequentually via script tags as one did in 2015
55
output: {
66
filename: "./openNote.bundle.js"
77
},

index.html

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<!DOCTYPE html>
2-
<html ng-app="openNote"> <!-- manifest="openNote.appcache" -->
2+
<html ng-app="openNote" manifest="openNote.appcache" -->
33
<head>
44
<meta charset="UTF-8">
55
<meta name="description" content="description">
@@ -11,14 +11,11 @@
1111

1212
<title>OpenNote</title>
1313

14-
<!--[if IE]>
15-
<script src="http://html5shiv.googlecode.com/svn/trunk/html5.js"></script>
16-
<![endif]-->
17-
1814
<!-- Style -->
1915
<link rel="stylesheet" type="text/css" href="node_modules/bootstrap/dist/css/bootstrap.min.css">
2016
<link rel="stylesheet" href="node_modules/alertify/themes/alertify.core.css">
2117
<link rel="stylesheet" href="node_modules/codemirror/lib/codemirror.css">
18+
<link rel="stylesheet" href="node_modules/codemirror/theme/material.css">
2219

2320
<!-- Theme -->
2421
<link rel="stylesheet" type="text/css" href="openNote/style/invert/light/alertify.css">
@@ -34,6 +31,6 @@
3431
<div id="menu" class="ng-hide fadeIn" ng-show="showMenu" ng-include="'openNote/partials/navBarPartial.html'"></div>
3532
<div class="col-lg-2 col-md-3 col-sm-4 col-xs-12" ng-include="'openNote/partials/tagListPartial.html'"></div>
3633
<div class="col-lg-10 col-md-9 col-sm-8 col-xs-12" ng-view> </div>
37-
<div id="copyRight" class="col-xs-12 fadeOutDirective">&#169; 2017 Jacob Liscom - Version {{version}}</div>
34+
<div id="copyRight" class="col-xs-12 fadeOutDirective">&#169; 2018 Jacob Liscom - Version {{version}}</div>
3835
</body>
3936
</html>

openNote/controllers/noteController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ openNote.controller("noteController", function($scope,
9797
$timeout(function() {//trick to wait for page to rerender with text area
9898
$scope.editor = CodeMirror.fromTextArea(document.getElementById("note-editor"), {
9999
mode: "markdown",
100-
//theme: "material", FIXME
100+
theme: "material",
101101
lineNumbers: true
102102
});
103103

openNote/services/tagService.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import openNote from "../openNote.js";
22
openNote.service("tagService", function ($rootScope,storageService) {
33
var service = this;
4-
var tagRegex = /(?:\ |^|\n|>)(#[^\ <\n]*)/ig;
4+
var tagRegex = /(?:\ |^|\n|>)(#[^\ <\n]+)/ig;
55

66
/**
77
* Bind handlers to the root scope
@@ -21,7 +21,7 @@ openNote.service("tagService", function ($rootScope,storageService) {
2121
});
2222

2323
$rootScope.$on("noteDeleted", function(event, note) {
24-
deleteTagsFromMap(note._id);
24+
deleteTagsFromMap(note._id,function(){});
2525
});
2626
};
2727

openNote/style/invert/style.less

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,7 @@ img {
160160
}
161161

162162

163+
163164
.box{
164165
width: 250px;
165166
height: 150px;
@@ -298,3 +299,8 @@ img {
298299
color: @copyRightColor;
299300
padding-left: 50px;
300301
}
302+
303+
// Note partial
304+
.notePartial .CodeMirror{
305+
border-radius:0 0 4px 4px;/*round the corners*/
306+
}

0 commit comments

Comments
 (0)