Skip to content

Commit 7712b36

Browse files
committed
Abstracted tag service. Fix tag bug
1 parent c598901 commit 7712b36

File tree

8 files changed

+8427
-406
lines changed

8 files changed

+8427
-406
lines changed

.jshintrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"esversion":6,
2+
"esversion":5,
33
"node": true,
44
"undef": true,
55
"unused": true,
@@ -10,5 +10,5 @@
1010
"devel":true,
1111
"jquery":true,
1212
"jasmine": true,
13-
"predef": [ "angular","alertify","", "PouchDB","inject","CodeMirror" ]
13+
"predef": [ "angular","alertify","", "PouchDB","inject","CodeMirror"]
1414
}

openNote/controllers/folderController.js

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,15 @@ openNote.controller("folderController", ["$scope",
33
"$rootScope",
44
"$location",
55
"$routeParams",
6+
"tagService",
67
"storageService",
78
"config",
89
"$timeout",
910
function($scope,
1011
$rootScope,
1112
$location,
1213
$routeParams,
14+
tagService,
1315
storageService,
1416
config,
1517
$timeout) {
@@ -194,15 +196,17 @@ openNote.controller("folderController", ["$scope",
194196
return;
195197

196198
var parentFolderID = $scope.currentFolder.parentFolderID;
197-
storageService.deleteFolder($scope.currentFolder, function() {
198-
$rootScope.$emit("reloadListView", {});
199+
tagService.deleteFolder($scope.currentFolder).then(function(){ // This needs to be done synchronously instead of an event because its possible for the storage service delete loop to get ahead and destoy the notes before the tag service has a change to delete them.
200+
storageService.deleteFolder($scope.currentFolder, function() {
201+
$rootScope.$emit("reloadListView", {});
199202

200-
if (!parentFolderID)
201-
$location.url("/folder/");
202-
else
203-
$location.url("/folder/" + parentFolderID);
203+
if (!parentFolderID)
204+
$location.url("/folder/");
205+
else
206+
$location.url("/folder/" + parentFolderID);
204207

205-
$scope.$apply();
208+
$scope.$apply();
209+
});
206210
});
207211
});
208212
};

openNote/controllers/noteController.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,6 @@ openNote.controller("noteController", ["$scope",
8686
* Take us into edit mode
8787
*/
8888
var activateEditMode = function() {
89-
//FIXME
90-
91-
9289
$scope.editMode = true;
9390

9491
if ($scope.note._id)
@@ -106,9 +103,16 @@ openNote.controller("noteController", ["$scope",
106103
$scope.editor = CodeMirror.fromTextArea(document.getElementById("note-editor"), {
107104
mode: "markdown",
108105
theme: "material",
109-
lineNumbers: true
106+
lineNumbers: true,
107+
indentUnit: 4
110108
});
111109

110+
// var resize = function() {
111+
// $(".CodeMirror").css({"height": ($(window).height()*0.75 )+ "px"});
112+
// };
113+
// window.onresize = resize;
114+
// resize();
115+
112116
});
113117

114118
};

openNote/controllers/settings/databaseController.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ openNote.controller("databaseController", ["$scope",
4242

4343
storageService.destroyDatabase(function() {
4444
$rootScope.$emit("reloadListView", {});
45+
$rootScope.$emit("tagsUpdated");
4546
window.location.href = '#/';
4647
$rootScope.$apply();
4748
alertify.success("Database deleted");
@@ -54,6 +55,7 @@ openNote.controller("databaseController", ["$scope",
5455
*/
5556
$scope.cleanOrphans = function() {
5657
storageService.cleanOrphans();
58+
//TODO implement tagService.cleanOrphans()
5759
alertify.log("Finding and removing orphans");
5860
};
5961

0 commit comments

Comments
 (0)