Skip to content

Commit 96c7001

Browse files
committed
Merge branch 'Fox-Working'
2 parents dbe2a55 + af28b28 commit 96c7001

File tree

6 files changed

+28
-16
lines changed

6 files changed

+28
-16
lines changed

Gruntfile.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,14 @@
11
module.exports = function(grunt) {
22
//Initializing the configuration object
33
grunt.initConfig({
4+
compress: {
5+
main: {
6+
options: {
7+
archive: "version.zip"
8+
},
9+
src: ["OpenNote/**/*"]
10+
}
11+
},
412
jshint: {
513
options:{
614
},
@@ -138,6 +146,7 @@ module.exports = function(grunt) {
138146
grunt.loadNpmTasks("grunt-karma");
139147
grunt.loadNpmTasks("grunt-shell");
140148
grunt.loadNpmTasks("grunt-manifest");
149+
grunt.loadNpmTasks("grunt-contrib-compress");
141150

142151
//Task definition
143152
//css

OpenNote/openNote/controllers/folderController.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,14 +188,14 @@ openNote.controller("folderController", function( $scope,
188188
if(!confirm)
189189
return;
190190

191-
var parrentFolderID = $scope.currentFolder.parrentFolderID;
191+
var parentFolderID = $scope.currentFolder.parentFolderID;
192192
storageService.deleteFolder($scope.currentFolder, function(){
193193
$rootScope.$emit("reloadListView", {});
194194

195-
if(!parrentFolderID)
195+
if(!parentFolderID)
196196
$location.url("/folder/");
197197
else
198-
$location.url("/folder/"+parrentFolderID);
198+
$location.url("/folder/"+parentFolderID);
199199

200200
$scope.$apply();
201201
});
@@ -206,7 +206,7 @@ openNote.controller("folderController", function( $scope,
206206
* Listen to changed folder events to see if its the current open folder
207207
*/
208208
$rootScope.$on("changedFolder", function(event, request) {
209-
if(request.folder.parrentFolderID==$scope.currentFolder.id || $scope.currentFolder.id==request.oldParrentFolderID){//does the change effect us?
209+
if(request.folder.parentFolderID==$scope.currentFolder.id || $scope.currentFolder.id==request.oldparentFolderID){//does the change effect us?
210210
$scope.loadCurrentFolder();//reload
211211
}
212212
});
@@ -236,9 +236,8 @@ openNote.controller("folderController", function( $scope,
236236
$scope.currentFolderContents=results.rows;
237237

238238
//Do they have anything to display?
239-
if(!$scope.currentFolder._id && !$scope.currentFolderContents){
239+
if(!$scope.currentFolder._id && !$scope.currentFolderContents.length)
240240
alertify.alert("It looks like you dont have any folders. You can create one using the \"New Folder\" button in the top right of the page. If you need to pull your remote notes <a href='#/settings/database'>click here</a>.");
241-
}
242241

243242
$scope.$apply();
244243
});

OpenNote/openNote/openNote.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ openNote.value("config", {
77
* Get current version
88
*/
99
getVersion: function(){
10-
return "17.02.00";
10+
return "17.02.01";
1111
},
1212

1313
/**

OpenNote/openNote/services/storageService.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,18 +154,17 @@ openNote.service("storageService", function ($rootScope) {
154154
* @param folder - the folder doc to delete
155155
* @param callback - callback when the given folder has been removed
156156
*/
157-
this.deleteFolder = function(folder,callback){
158-
self.loadFolderContents(folder.id, function (results) {
157+
this.deleteFolder = function(folder,callback){//TODO test
158+
self.loadFolderContents(folder._id, function (results) {
159159
results.rows.filter(self.noteFilter).forEach(function(note){
160160
localDatabase.remove(note.doc);
161161
});
162162

163163
results.rows.filter(self.folderFilter).forEach(function(subFolder){
164164
self.deleteFolder(subFolder);
165165
});
166+
localDatabase.remove(folder).then(callback);
166167
});
167-
168-
localDatabase.remove(folder.doc).then(callback);
169168
};
170169

171170

OpenNote/openNote/services/tagService.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,21 @@
11
openNote.service("tagService", function ($rootScope,storageService) {
22
var service = this;
3-
var tagRegex = /(?:\ |^|\n)(#[^\ <\n]*)/ig;
3+
var tagRegex = /(?:\ |^|\n|>)(#[^\ <\n]*)/ig;
44

55
/**
66
* Bind handlers to the root scope
77
*/
88
this.bindHandlers = function(){
99
$rootScope.$on("noteSaved", function(event, note) {
1010
deleteTagsFromMap(note._id,function(){
11-
var results = note.note.match(tagRegex);
12-
if(!results||!results.length)
11+
var matches;
12+
var output = [];
13+
while ((matches = tagRegex.exec(note.note)))
14+
output.push(matches[1]);
15+
16+
if(!output.length)
1317
return;
14-
addTagsToMap(results,note._id);
18+
addTagsToMap(output,note._id);
1519
});
1620
});
1721

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "OpenNote",
3-
"version": "17.02.00",
3+
"version": "17.02.01",
44
"description": "",
55
"main": "Gruntfile.js",
66
"author": "Jacob Liscom",
@@ -13,6 +13,7 @@
1313
"grunt-cli": "^0.1.13",
1414
"grunt-contrib-watch": "^0.6.1",
1515
"grunt-contrib-jshint": "^1.0.0",
16+
"grunt-contrib-compress": "^1.1.1",
1617
"grunt-karma": "^0.8.3",
1718
"phantomjs": "^1.9.7-5",
1819
"karma-phantomjs-launcher": "^0.1.4",

0 commit comments

Comments
 (0)