Merge pull request #16 from JMLamodiere/integration_infra_sociable

Use overlapping sociable tests

Author: JMLamodiere

.travis.yml

@@ -29,6 +29,7 @@ branches:
     - integration_infra_medium_domain
     - integration_infra_medium_domain_wiremock
     - integration_infra_medium_domain_no_di
+    - integration_infra_sociable
 
 before_install:
   - make preinstall

README.md

@@ -30,6 +30,11 @@ decoupling HTTP tests with the library being used for HTTP calls.
    [(see Pull Request)](https://github.com/JMLamodiere/tdd-demo-forumphp2020/pull/15)
    removes [Dependency Injection Container](https://www.loosecouplings.com/2011/01/dependency-injection-using-di-container.html)
    usage and manually build tested classes instead.
+1. [integration_infra_sociable](https://github.com/JMLamodiere/tdd-demo-forumphp2020/tree/integration_infra_sociable) branch
+   [(see Pull Request)](https://github.com/JMLamodiere/tdd-demo-forumphp2020/pull/16)
+   replaces medium sized tests with [Overlapping Sociable Tests](https://www.jamesshore.com/v2/blog/2018/testing-without-mocks#sociable-tests)
+   to allow easily test and evolve individual behaviours (ex : class serialization) while still being able to
+   split/merge/refactor classes inside some class clusters by not checking specific calls between them.
 1. (todo...)
 
 ## API documentation

docs/openapi.yml

@@ -1,6 +1,8 @@
 openapi: 3.0.3
 info:
   title: TDD Demo ForumPHP 2020
+  description: |
+    See [JMLamodiere/tdd-demo-forumphp2020](https://github.com/JMLamodiere/tdd-demo-forumphp2020/blob/main/README.md) on GitHub.
 
   version: 1.0.0
 

features/bootstrap/FeatureContext.php

@@ -1,6 +1,9 @@
 <?php
 
 use App\Infrastructure\Database\PostgresRunningSessionRepository;
+use App\Infrastructure\Database\PostgresRunningSessionRepositoryTest;
+use App\Infrastructure\Http\CurrentConditionDeserializerTest;
+use App\Infrastructure\Symfony\Serializer\RegisterRunningSessionDeserializerTest;
 use Behat\Behat\Context\Context;
 use Doctrine\DBAL\Connection;
 use PHPUnit\Framework\Assert;
@@ -41,31 +44,7 @@ public function resetState()
     public function currentTemperatureIs($temperature)
     {
         $uri = '/currentconditions/v1/623?apikey='.$this->accuweatherApiKey;
-        $body = <<<EOD
-[{
-	"LocalObservationDateTime": "2020-10-17T17:50:00+02:00",
-	"EpochTime": 1602949800,
-	"WeatherText": "Mostly cloudy",
-	"WeatherIcon": 6,
-	"HasPrecipitation": false,
-	"PrecipitationType": null,
-	"IsDayTime": true,
-	"Temperature": {
-		"Metric": {
-			"Value": $temperature,
-			"Unit": "C",
-			"UnitType": 17
-		},
-		"Imperial": {
-			"Value": 55.0,
-			"Unit": "F",
-			"UnitType": 18
-		}
-	},
-	"MobileLink": "http://m.accuweather.com/en/fr/paris/623/current-weather/623?lang=en-us",
-	"Link": "http://www.accuweather.com/en/fr/paris/623/current-weather/623?lang=en-us"
-}]
-EOD;
+        $body = CurrentConditionDeserializerTest::createBody($temperature);
 
         $this->wireMock->stubFor(WireMock::get(WireMock::urlEqualTo($uri))
             ->willReturn(WireMock::aResponse()
@@ -78,16 +57,10 @@ public function currentTemperatureIs($temperature)
      */
     public function iRegisterARunningSessionWith($id, $distance, $shoes)
     {
-        $request = Request::create('/runningsessions/'.$id, 'PUT', [], [], [], [], <<<EOD
-{
-  "id": $id,
-  "distance": $distance,
-  "shoes": "$shoes"
-}
-EOD
-);
+        $body = RegisterRunningSessionDeserializerTest::createBody($id, $distance, $shoes);
+        $request = Request::create('/runningsessions/'.$id, 'PUT', [], [], [], [], $body);
 
-        $this->response = $this->kernel->handle($request); //, HttpKernelInterface::MASTER_REQUEST, false);
+        $this->response = $this->kernel->handle($request);
     }
 
     /**
@@ -96,15 +69,10 @@ public function iRegisterARunningSessionWith($id, $distance, $shoes)
     public function aRunningSessionShouldBeAddedWith($id, $distance, $shoes, $temperature)
     {
         Assert::assertEquals(201, $this->response->getStatusCode());
-
-        $row = $this->dbal->fetchAssociative(
-            'SELECT distance, shoes, temperature_celcius '
-            .' FROM '.PostgresRunningSessionRepository::TABLE_NAME
-            .' WHERE ID = :id', [':id' => $id]);
-
-        Assert::assertIsArray($row, 'No session found with this id');
-        Assert::assertEquals($distance, $row['distance']);
-        Assert::assertEquals($shoes, $row['shoes']);
-        Assert::assertEquals($temperature, $row['temperature_celcius']);
+        PostgresRunningSessionRepositoryTest::thenRunningSessionTableShouldContain($this->dbal, $id, [
+            'distance' => $distance,
+            'shoes' => $shoes,
+            'temperature_celcius' => $temperature,
+        ]);
     }
 }

src/Infrastructure/Http/CurrentConditionDeserializer.php

@@ -4,15 +4,17 @@
 
 namespace App\Infrastructure\Http;
 
-use Psr\Http\Message\ResponseInterface;
 use Webmozart\Assert\Assert;
 
 class CurrentConditionDeserializer
 {
-    public function deserialize(ResponseInterface $response): float
+    /**
+     * @throws \InvalidArgumentException
+     * @throws \JsonException
+     */
+    public function deserialize(string $body): float
     {
-        $content = $response->getBody()->getContents();
-        $data = json_decode($content, true, 512, JSON_THROW_ON_ERROR);
+        $data = json_decode($body, true, 512, JSON_THROW_ON_ERROR);
 
         Assert::isArray($data, 'Data root should be array');
         Assert::notEmpty($data, 'Data root should not be empty');

src/Infrastructure/Http/RestWeatherProvider.php

@@ -39,7 +39,7 @@ public function getCurrentCelciusTemperature(): float
         }
 
         try {
-            return $this->serializer->deserialize($response);
+            return $this->serializer->deserialize($response->getBody()->getContents());
         } catch (\Exception $previous) {
             throw new CannotGetCurrentTemperature('Cannot decode current condition', 0, $previous);
         }

src/Infrastructure/Symfony/Controller/RunningSessionController.php

@@ -6,7 +6,7 @@
 
 use App\Application\Command\RegisterRunningSessionHandler;
 use App\Infrastructure\Symfony\Serializer\RegisterRunningSessionDeserializer;
-use App\Infrastructure\Symfony\Serializer\RunningSessionNormalizer;
+use App\Infrastructure\Symfony\Serializer\RunningSessionSerializer;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
@@ -17,16 +17,16 @@
 class RunningSessionController extends AbstractController
 {
     private RegisterRunningSessionDeserializer $commandDeserializer;
-    private RunningSessionNormalizer $responseNormalizer;
+    private RunningSessionSerializer $responseSerializer;
     private RegisterRunningSessionHandler $registerRunningSessionHandler;
 
     public function __construct(
         RegisterRunningSessionDeserializer $commandDeserializer,
-        RunningSessionNormalizer $responseNormalizer,
+        RunningSessionSerializer $responseSerializer,
         RegisterRunningSessionHandler $registerRunningSessionHandler
     ) {
         $this->commandDeserializer = $commandDeserializer;
-        $this->responseNormalizer = $responseNormalizer;
+        $this->responseSerializer = $responseSerializer;
         $this->registerRunningSessionHandler = $registerRunningSessionHandler;
     }
 
@@ -40,6 +40,12 @@ public function put(string $id, Request $request): Response
 
         $session = $this->registerRunningSessionHandler->handle($command);
 
-        return new JsonResponse($this->responseNormalizer->normalize($session), Response::HTTP_CREATED);
+        return new JsonResponse(
+            $this->responseSerializer->serialize($session),
+            Response::HTTP_CREATED,
+            [],
+            //json is already encoded by serializer
+            true
+        );
     }
 }

src/Infrastructure/Symfony/Serializer/RunningSessionNormalizer.php renamed to src/Infrastructure/Symfony/Serializer/RunningSessionSerializer.php

@@ -6,15 +6,20 @@
 
 use App\Domain\RunningSession;
 
-class RunningSessionNormalizer
+class RunningSessionSerializer
 {
-    public function normalize(RunningSession $session): array
+    /**
+     * @throws \JsonException
+     */
+    public function serialize(RunningSession $session): string
     {
-        return [
+        $data = [
             'id' => $session->getId(),
             'distance' => $session->getDistance(),
             'shoes' => $session->getShoes(),
             'temperatureCelcius' => $session->getMetricTemperature(),
         ];
+
+        return json_encode($data, JSON_THROW_ON_ERROR);
     }
 }

tests/Application/Command/RegisterRunningSessionHandlerTest.php

@@ -5,6 +5,7 @@
 namespace App\Application\Command;
 
 use App\Domain\RunningSession;
+use App\Domain\RunningSessionFactory;
 use App\Domain\RunningSessionRepository;
 use App\Domain\WeatherProvider;
 use PHPUnit\Framework\TestCase;
@@ -45,7 +46,7 @@ public function testTheRunningSessionIRegisterIsEnrichedWithCurrentWeatherData()
         ));
 
         //Then (Assert)
-        $this->thenARunningSessionShouldBeAdded(new RunningSession(
+        $this->thenARunningSessionShouldBeAdded(RunningSessionFactory::create(
             12,
             125.7,
             'shoes',

tests/Domain/RunningSessionFactory.php

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Domain;
+
+class RunningSessionFactory
+{
+    public static function create(
+        int $id = 9,
+        float $distance = 999.1,
+        string $shoes = 'shoes_value_not_used',
+        float $metricTemperature = 98.76
+    ): RunningSession {
+        return new RunningSession($id, $distance, $shoes, $metricTemperature);
+    }
+}