Merge pull request #22 from JMLamodiere/fix_accuweather_in_doc

be more specific about using AccuWeather in Infra and fix README

Author: JMLamodiere

README.md

@@ -81,11 +81,11 @@ Pre-requisites (see [composer.json](composer.json)) :
 - ext-pgsql
 - [Symfony local web server](https://symfony.com/doc/current/setup/symfony_server.html)
 
-Create an account on [OpenWeatherMap](https://home.openweathermap.org/api_keys) and copy your api key:
+Create an App on [AccuWeather](https://developer.accuweather.com/) and copy your API Key:
 
 ```
 # in /.env.dev.local
-OPENWEATHER_API_KEY=xxx
+ACCUWEATHER_API_KEY=xxx
 ```
 
 Start local dev environment with:

config/services.yaml

@@ -38,7 +38,7 @@ services:
         arguments:
             -   base_uri: '%env(ACCUWEATHER_BASE_URI)%'
 
-    App\Infrastructure\Http\RestWeatherProvider:
+    App\Infrastructure\Http\HttpAccuWeatherProvider:
         arguments:
             $client: '@guzzle.accuweather'
             $apiKey: '%env(ACCUWEATHER_API_KEY)%'

src/Infrastructure/Http/RestWeatherProvider.php renamed to src/Infrastructure/Http/HttpAccuWeatherProvider.php

@@ -9,8 +9,9 @@
 use GuzzleHttp\Client;
 use GuzzleHttp\Exception\GuzzleException;
 
-class RestWeatherProvider implements WeatherProvider
+class HttpAccuWeatherProvider implements WeatherProvider
 {
+    // See https://developer.accuweather.com/accuweather-current-conditions-api/apis
     public const CURRENT_CONDITION_URI = 'currentconditions/v1/%d?apikey=%s';
     public const LOCATION_KEY_PARIS = 623;
 

tests/Infrastructure/Http/RestWeatherProviderTest.php renamed to tests/Infrastructure/Http/HttpAccuWeatherProviderTest.php

@@ -12,9 +12,9 @@
 /**
  * @group integration
  */
-class RestWeatherProviderTest extends TestCase
+class HttpAccuWeatherProviderTest extends TestCase
 {
-    private RestWeatherProvider $provider;
+    private HttpAccuWeatherProvider $provider;
     private WireMock $wireMock;
     private string $currentConditionUri;
 
@@ -25,7 +25,7 @@ protected function setUp(): void
         $host = 'wiremock';
         $port = '8080';
 
-        $this->provider = new RestWeatherProvider(
+        $this->provider = new HttpAccuWeatherProvider(
             // See https://docs.guzzlephp.org/en/stable/quickstart.html#creating-a-client
             new Client(['base_uri' => "http://$host:$port/"]),
             $accuweatherApiKey,