remove Dependency Injection Container usage in Integration Tests

Author: JMLamodiere

.travis.yml

@@ -28,6 +28,7 @@ branches:
     - bad_tests
     - integration_infra_medium_domain
     - integration_infra_medium_domain_wiremock
+    - integration_infra_medium_domain_no_di
 
 before_install:
   - make preinstall

README.md

@@ -9,6 +9,8 @@ For a bit of theory, see [De CRUD à DDD, comment Meetic a sauvé son legacy](ht
 
 ## Steps by step refactoring
 
+:warning: **Warning** : Only steps 1 & 2 are really considered *bad*. Next steps just show different testing styles.
+
 1. [bad_implementation](https://github.com/JMLamodiere/tdd-demo-forumphp2020/tree/bad_implementation) branch
 contains :
     - Architecture mistakes according to [Hexagonal architecture](https://alistair.cockburn.us/hexagonal-architecture/) (aka Port & Adapters)
@@ -24,6 +26,10 @@ Many obscure changes are required in the tests, proving they do not help much du
 [(see Pull Request)](https://github.com/JMLamodiere/tdd-demo-forumphp2020/pull/14)
 only replaces [Guzzle MockHandler](https://docs.guzzlephp.org/en/stable/testing.html) with [Wiremock](#wiremock),
 decoupling HTTP tests with the library being used for HTTP calls.
+1. [integration_infra_medium_domain_no_di](https://github.com/JMLamodiere/tdd-demo-forumphp2020/tree/integration_infra_medium_domain_no_di) branch
+   [(see Pull Request)](https://github.com/JMLamodiere/tdd-demo-forumphp2020/pull/15)
+   removes [Dependency Injection Container](https://www.loosecouplings.com/2011/01/dependency-injection-using-di-container.html)
+   usage and manually build tested classes instead.
 1. (todo...)
 
 ## API documentation

tests/Infrastructure/Database/PostgresRunningSessionRepositoryTest.php

@@ -6,21 +6,27 @@
 
 use App\Domain\RunningSession;
 use Doctrine\DBAL\Connection;
-use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use Doctrine\DBAL\DriverManager;
+use PHPUnit\Framework\TestCase;
 
 /**
  * @group integration
  */
-class PostgresRunningSessionRepositoryTest extends KernelTestCase
+class PostgresRunningSessionRepositoryTest extends TestCase
 {
     private Connection $dbal;
     private PostgresRunningSessionRepository $repository;
 
     protected function setUp(): void
     {
-        self::bootKernel();
-        $this->dbal = self::$container->get('doctrine.dbal.default_connection');
-        $this->repository = self::$container->get(PostgresRunningSessionRepository::class);
+        //see https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#getting-a-connection
+        $connectionParams = [
+            // Same as .env.test
+            'url' => 'postgres://forumphp:forumphp@database:5432/forumphp?sslmode=disable&charset=utf8',
+        ];
+        $this->dbal = DriverManager::getConnection($connectionParams);
+
+        $this->repository = new PostgresRunningSessionRepository($this->dbal);
         $this->resetState();
     }
 

tests/Infrastructure/Http/RestWeatherProviderTest.php

@@ -5,25 +5,34 @@
 namespace App\Infrastructure\Http;
 
 use App\Domain\CannotGetCurrentTemperature;
-use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
+use GuzzleHttp\Client;
+use PHPUnit\Framework\TestCase;
 use WireMock\Client\WireMock;
 
-class RestWeatherProviderTest extends KernelTestCase
+class RestWeatherProviderTest extends TestCase
 {
     private RestWeatherProvider $provider;
     private WireMock $wireMock;
     private string $currentConditionUri;
 
     protected function setUp(): void
     {
-        self::bootKernel();
-
-        $this->provider = self::$container->get(RestWeatherProvider::class);
-
-        $this->wireMock = self::$container->get(WireMock::class);
+        $accuweatherApiKey = 'myApiKey';
+        // See docker-compose.yml
+        $host = 'wiremock';
+        $port = '8080';
+
+        $this->provider = new RestWeatherProvider(
+            // See https://docs.guzzlephp.org/en/stable/quickstart.html#creating-a-client
+            new Client(['base_uri' => "http://$host:$port/"]),
+            $accuweatherApiKey,
+            new CurrentConditionDeserializer()
+        );
+
+        // See docker-compose.yml
+        $this->wireMock = WireMock::create($host, $port);
         self::assertTrue($this->wireMock->isAlive(), 'Wiremock should be alive');
 
-        $accuweatherApiKey = self::$container->getParameter('accuweather.apikey');
         $this->currentConditionUri = '/currentconditions/v1/623?apikey='.$accuweatherApiKey;
     }
 

tests/Infrastructure/Symfony/Controller/RunningSessionControllerTest.php

@@ -7,26 +7,33 @@
 use App\Application\Command\RegisterRunningSession;
 use App\Application\Command\RegisterRunningSessionHandler;
 use App\Domain\RunningSession;
+use App\Infrastructure\Symfony\Serializer\RegisterRunningSessionDeserializer;
+use App\Infrastructure\Symfony\Serializer\RunningSessionNormalizer;
+use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Prophecy\PhpUnit\ProphecyTrait;
 use Prophecy\Prophecy\ObjectProphecy;
-use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 
-class RunningSessionControllerTest extends KernelTestCase
+class RunningSessionControllerTest extends TestCase
 {
     use ProphecyTrait;
 
     /** @var ObjectProphecy|RegisterRunningSessionHandler */
     private $registerRunningSessionHandler;
 
+    private RunningSessionController $controller;
+
     protected function setUp(): void
     {
-        self::bootKernel();
-
         $this->registerRunningSessionHandler = $this->prophesize(RegisterRunningSessionHandler::class);
-        self::$container->set(RegisterRunningSessionHandler::class, $this->registerRunningSessionHandler->reveal());
+
+        $this->controller = new RunningSessionController(
+            new RegisterRunningSessionDeserializer(),
+            new RunningSessionNormalizer(),
+            $this->registerRunningSessionHandler->reveal()
+        );
     }
 
     public function testPutRouteSendsCommandToHandlerAndDisplayItsResult()
@@ -35,7 +42,7 @@ public function testPutRouteSendsCommandToHandlerAndDisplayItsResult()
         $this->givenHandlerResponseIs(new RunningSession(42, 5.5, 'Adadis Turbo2', 37.2));
 
         //When (Act)
-        $response = $this->whenISendThisRequest(Request::create('/runningsessions/42', 'PUT', [], [], [], [], <<<EOD
+        $response = $this->whenISendThisRequest('42', Request::create('uri_not_used', 'method_not_used', [], [], [], [], <<<EOD
 {
   "id": 42,
   "distance": 5.5,
@@ -63,9 +70,9 @@ private function givenHandlerResponseIs(RunningSession $handlerResponse)
             ->willReturn($handlerResponse);
     }
 
-    private function whenISendThisRequest(Request $request): Response
+    private function whenISendThisRequest(string $id, Request $request): Response
     {
-        return self::$kernel->handle($request);
+        return $this->controller->put($id, $request);
     }
 
     private function thenThisCommandHasBeenSentToHandler(RegisterRunningSession $expectedCommand)