v1.1.1 fixes for Chrome

Author: JNavas2

Chrome/manifest.json

@@ -12,17 +12,10 @@
     "96": "images/icon-96.png",
     "128": "images/icon-128.png"
   },
-  "web_accessible_resources": [
-    {
-      "resources": ["whats_new.json"],
-      "matches": ["<all_urls>"]
-    }
-  ],
   "permissions": [
     "activeTab",
     "storage",
-    "scripting",
-    "offscreen"
+    "scripting"
   ],
   "background": {
     "service_worker": "service_worker.js"

Chrome/offscreen.html

@@ -1,37 +1,40 @@
-Send the current page by your system’s email app (mailto:), Gmail® or Outlook®—with the page title, selected text, and URL—easily.
+Send the current page by your system’s email app (mailto), Gmail® or Outlook®—with the page title, selected text, and URL—easily.
 
 OVERVIEW  
 Page Mail is a simple yet powerful extension that lets you quickly compose an email message containing:  
 - The current page’s title  
 - Any text you’ve selected  
 - The page URL  
 
-Perfect for sharing articles, research, or anything you find online—right from your browser! Supports Email link handler (mailto:), Gmail® and Outlook®.
+Perfect for sharing articles, research, or anything you find online—right from your browser! Supports Email link handler (mailto), Gmail® and Outlook®.
+
+WHAT'S NEW
+- 1.1.1: Fix zombie window issue with Thunderbird
+- 1.1.0: Fix blank popup issue.
 
 FEATURES  
-- One-click sharing: Click the extension button to open your system’s Email link handler (mailto:), Gmail® or Outlook® with the page details pre-filled.  
+- One-click sharing: Click the extension button to open your system’s Email link handler (mailto), Gmail® or Outlook® with the page details pre-filled.  
 - Keyboard shortcut: Use Ctrl+Alt+P (customizable) to open the extension popup.  
 - Selected text support: Highlight text on a page to include it in your email.  
 - Custom subject prefix: Personalize your email subject line via the options page.  
 - Syncs across devices: Your subject prefix and service choice can be saved with your browser account.
 
 USAGE  
-1. Choose your email provider (Email link handler [mailto:], Gmail® or Outlook®) in Options.  
+1. Choose your email provider (Email link handler [mailto], Gmail® or Outlook®) in Options.  
 2. (Optional) Highlight text on the page to include it in your email.  
 3. Open the popup by clicking the extension icon or using Ctrl+Alt+P (customizable in browser's extension manager).  
 4. You must initiate sending from the new message popup.
 
 OPTIONS  
 - Access the options page via the onboarding page, the extension’s context menu, or browser add-on manager.  
 - Set a subject prefix (e.g., “FYI: ”) to be added to every email subject.  
-- Choose Email link handler (mailto:), Gmail® or Outlook® as your preferred provider.  
+- Choose Email link handler (mailto), Gmail® or Outlook® as your preferred provider.  
 - Settings can sync with your browser account.
 
-CONFIGURING mailto:  
-When you select Email link handler (mailto:) in Page Mail’s options, the extension uses browser’s configured handler for `mailto:` links. This can be your operating system’s default email app or a webmail service (like Gmail or Outlook.com).
+CONFIGURING mailto  
+When you select Email link handler (mailto) in Page Mail’s options, the extension uses browser’s configured handler for `mailto` links. This can be your operating system’s default email app or a webmail service (like Gmail or Outlook.com).
 
-To change your mailto: handler in browser, see:  
-[How do I change my web browser's default email client for mailto links?](https://support.procore.com/faq/how-do-i-change-my-web-browsers-default-email-client-for-mailto-links)
+To change your mailto handler in browser, see: https://support.procore.com/faq/how-do-i-change-my-web-browsers-default-email-client-for-mailto-links
 
 PRIVACY & PERMISSIONS  
 - Page Mail does not collect or transmit any personal data.
@@ -45,15 +48,15 @@ COMPATIBILITY
 
 KNOWN ISSUES & LIMITATIONS  
 - The extension cannot access special pages (e.g., about:, chrome:, edge:).  
-- You must be logged in to your selected email service (Email link handler [mailto:], Gmail® or Outlook®) in the browser for Page Mail to work properly.  
+- You must be logged in to your selected email service (Email link handler [mailto], Gmail® or Outlook®) in the browser for Page Mail to work properly.  
 - The amount of selected text you can include is limited by the maximum URL length supported by browsers and email providers. Large selections may be truncated or fail to open in the email composer.
 
 FAQ  
 Q: Can I change the keyboard shortcut?  
 A: Yes! Use the browser's extension manager.
 
 Q: Does this work with other email providers?  
-A: It supports Email link handler (mailto:) in addition to Gmail® and Outlook®.
+A: It supports Email link handler (mailto) in addition to Gmail® and Outlook®.
 
 Q: Is my browsing data sent anywhere?  
 A: No. The extension only opens your chosen email service with data you see; nothing is sent to third parties.

Chrome/offscreen.js

@@ -4,37 +4,22 @@
   Handles background actions, including opening compose windows with user options.
 */
 
-const ext = typeof browser !== "undefined" ? browser : chrome;
-const OFFSCREEN_DOCUMENT_PATH = '/offscreen.html';
-
-// A helper function to find if an offscreen document is already open
-async function hasOffscreenDocument() {
-    const contexts = await ext.runtime.getContexts({
-        contextTypes: ['OFFSCREEN_DOCUMENT'],
-        documentUrls: [ext.runtime.getURL(OFFSCREEN_DOCUMENT_PATH)]
-    });
-    return contexts.length > 0;
-}
+console.log("Page Mail Service Worker starting up...");
 
-// A helper function to create and use the offscreen document for mailto: links
-async function openMailtoInOffscreen(mailtoUrl) {
-    if (await hasOffscreenDocument()) {
-        await ext.offscreen.closeDocument();
-    }
-    
-    // Uses the CLIPBOARD reason as it is the most appropriate for triggering external actions
-    await ext.offscreen.createDocument({
-        url: OFFSCREEN_DOCUMENT_PATH + '#' + encodeURIComponent(mailtoUrl),
-        reasons: ['CLIPBOARD'], 
-        justification: 'To reliably open mailto: links from a service worker without leaving a blank window.',
-    });
-}
+const ext = typeof browser !== "undefined" ? browser : chrome;
 
-// Core function to open the selected email service's compose window
+/**
+ * Core function to open the selected email service's compose window.
+ * Uses script injection for mailto: to ensure compatibility with Windows 11.
+ */
 async function openComposeWindow() {
+    console.log("Toolbar button clicked - initializing Page Mail...");
     try {
         const [tab] = await ext.tabs.query({ active: true, currentWindow: true });
-        if (!tab) throw new Error("No active tab found.");
+        if (!tab) {
+            console.error("No active tab found.");
+            return;
+        }
 
         let selectedText = "";
         try {
@@ -46,38 +31,24 @@ async function openComposeWindow() {
             if (results && results[0] && results[0].result) {
                 selectedText = results[0].result;
             }
-        } catch {
-            // If the script fails (e.g., on restricted chrome:// pages), 
-            // open the error page in a full tab for better reliability on Windows 11.
-            await ext.tabs.create({
-                url: ext.runtime.getURL("error.html")
-            });
+        } catch (e) {
+            // If the script fails (e.g., on restricted pages), show the error page
+            console.warn("Scripting blocked on this page. Opening error page.", e);
+            await ext.tabs.create({ url: ext.runtime.getURL("error.html") });
             return;
         }
 
         // Retrieve user preferences from storage
-        const data = await new Promise((resolve, reject) => {
-            ext.storage.sync.get(
-                ['subjectPrefix', 'emailService', 'selectedTextPos', 'blankLine'],
-                (result) => {
-                    if (ext.runtime && ext.runtime.lastError) {
-                        reject(ext.runtime.lastError);
-                    } else {
-                        resolve(result);
-                    }
-                }
-            );
-        });
-        
+        const data = await ext.storage.sync.get(['subjectPrefix', 'emailService', 'selectedTextPos', 'blankLine']);
+
         const prefix = data.subjectPrefix || "";
-        const service = data.emailService || "mailto"; // Matches options.html values
+        const service = data.emailService || "mailto";
         const selectedTextPos = data.selectedTextPos || "above";
         const blankLine = !!data.blankLine;
 
         let link = tab.url;
         let body = "";
-        
-        // Construct email body based on selection and placement settings
+
         if (selectedText && selectedText.trim()) {
             if (selectedTextPos === "above") {
                 body = selectedText + (blankLine ? "\n\n" : "\n") + link;
@@ -97,11 +68,10 @@ async function openComposeWindow() {
         } else if (service === "mailto") {
             composeUrl = `mailto:?subject=${encodeURIComponent(subject)}&body=${encodeURIComponent(body)}`;
         } else {
-            // Gmail is the fallback service
             composeUrl = `https://mail.google.com/mail/?view=cm&fs=1&su=${encodeURIComponent(subject)}&body=${encodeURIComponent(body)}`;
         }
 
-        // Execution logic: Web-based vs System-based
+        // Execution logic
         if (service === "gmail" || service === "outlook") {
             // Webmail requires a popup window
             await ext.windows.create({
@@ -110,19 +80,29 @@ async function openComposeWindow() {
                 width: 800,
                 height: 600
             });
-        } else { 
-            // mailto: uses the offscreen document to prevent the "empty window" bug
-            await openMailtoInOffscreen(composeUrl);
+        } else {
+            // FIXED: Inject the mailto trigger directly into the active tab
+            // This treats the link as a user-initiated action from the page context.
+            console.log("Injecting mailto trigger into active tab...");
+            await ext.scripting.executeScript({
+                target: { tabId: tab.id },
+                func: (url) => {
+                    const link = document.createElement('a');
+                    link.href = url;
+                    document.body.appendChild(link);
+                    link.click();
+                    document.body.removeChild(link);
+                },
+                args: [composeUrl]
+            });
         }
     } catch (error) {
-        console.error("Page Mail: Failed to open compose window:", error);
-        await ext.tabs.create({
-            url: ext.runtime.getURL("error.html")
-        });
+        console.error("Page Mail Error:", error);
+        await ext.tabs.create({ url: ext.runtime.getURL("error.html") });
     }
 }
 
-// Event Listeners
+// Event Listeners (Must be at the top level)
 ext.action.onClicked.addListener(openComposeWindow);
 
 ext.commands.onCommand.addListener((command) => {
@@ -133,8 +113,6 @@ ext.commands.onCommand.addListener((command) => {
 
 ext.runtime.onInstalled.addListener((details) => {
     if (details.reason === "install" || details.reason === "update") {
-        ext.tabs.create({
-            url: ext.runtime.getURL("onboarding.html")
-        });
+        ext.tabs.create({ url: ext.runtime.getURL("onboarding.html") });
     }
 });