Fix #23024: Set foreground color for feedback warning label (patch by Larsossum, modified)

This fixes an issue where a dark colour theme would use a light-coloured
foreground when we set the background colour to a light colour.

git-svn-id: https://josm.openstreetmap.de/svn/trunk@18782 0c6e7542-c601-0410-84e7-c038aed88b3b

Author: taylor.smock

src/org/openstreetmap/josm/gui/io/UploadTextComponentValidator.java

@@ -48,7 +48,7 @@ protected void feedbackWarning(String msg) {
         super.feedbackWarning(msg);
         if (!Objects.equals(msg, feedback.getText())) {
             feedback.setText(msg);
-            feedback.setForeground(null);
+            feedback.setForeground(WARNING_FOREGROUND);
             feedback.setBackground(WARNING_BACKGROUND);
             feedback.setBorder(WARNING_BORDER);
         }

src/org/openstreetmap/josm/gui/widgets/AbstractTextComponentValidator.java

@@ -45,6 +45,8 @@ public abstract class AbstractTextComponentValidator extends ChangeNotifier
 
     protected static final Color WARNING_COLOR = new NamedColorProperty(marktr("Input validation: warning"), new Color(0xFFA500)).get();
     protected static final Border WARNING_BORDER = BorderFactory.createLineBorder(WARNING_COLOR, 1);
+    protected static final Color WARNING_FOREGROUND = new NamedColorProperty(
+            marktr("Input validation: warning foreground"), Color.BLACK).get();
     protected static final Color WARNING_BACKGROUND = new NamedColorProperty(
             marktr("Input validation: warning background"), new Color(0xFFEDCC)).get();