Skip to content

Commit 0db6844

Browse files
committed
Refactor: change function behavior
BREAKING CHANGE: rules are now functions where input and config are passed immediatelly
1 parent e9805dc commit 0db6844

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

lib/questions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const questions = (config) => {
4141
name: 'description',
4242
message: 'Enter your commit message:',
4343
validate: (input) => {
44-
const warnings = ruleWarningMessages(input);
44+
const warnings = ruleWarningMessages(input, config);
4545

4646
return warnings || true;
4747
},

lib/rules/ruleWarningMessages.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
import entries from 'object.entries';
2-
import getConfig from '../getConfig';
32
import rules from './availableRules';
43

5-
const config = getConfig();
6-
7-
const ruleWarningMessages = (input) => {
4+
const ruleWarningMessages = (input, config) => {
85
let warningMessage = '';
6+
97
const configRuleEntries = entries(config.rules);
108

119
configRuleEntries.forEach((rule) => {

test/rules/ruleWarningMessages.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,15 @@
11
import test from 'ava';
2+
23
import ruleWaringMessages from '../../lib/rules/ruleWarningMessages';
34

45
test('ruleWarningMessages', (t) => {
5-
const messages = ruleWaringMessages('input.');
6+
const config = {
7+
rules: {
8+
'max-char': 72,
9+
'min-char': 10,
10+
'end-with-dot': false,
11+
},
12+
};
13+
const messages = ruleWaringMessages('input.', config);
614
t.deepEqual(messages, 'The commit message has to be at least 10 character.\nThe commit message can not end with a dot\n');
715
});

0 commit comments

Comments
 (0)