Feat: change emoji default to false

BREAKING CHANGE: changed the default to false

Author: JPeer264

.sgcrc_default

@@ -1,4 +1,9 @@
 {
+  "questions": {
+    "scope": false,
+    "moreInfo": true
+  },
+  "emojies": false,
   "types": [
     {
       "emoji": ":wrench:",

lib/questions.js

@@ -6,8 +6,7 @@ const choices = (config) => {
   const choicesList = [];
 
   config.types.forEach((type) => {
-    const isEmojies = config.emojies === undefined ? true : config.emojies;
-    const emoji = isEmojies && type.emoji ? `${type.emoji} ` : '';
+    const emoji = config.emojies && type.emoji ? `${type.emoji} ` : '';
     const configType = type.type;
     const description = type.description || '';
 

test/cli.js

@@ -14,7 +14,7 @@ test('should print the right version', async (t) => {
 });
 
 // make serial due to dynamic process.chdir switching
-test.serial('should fail on non git repository', async (t) => {
+test('should fail on non git repository', async (t) => {
   // assume that the homedir is not a git repo
   process.chdir(homedir());
 

test/fixtures/.sgcrc

@@ -3,6 +3,7 @@
     "scope": false,
     "moreInfo": true
   },
+  "emojies": false,
   "types": [
     {
       "emoji": ":emo:",

test/getConfig.js

@@ -54,11 +54,13 @@ test('read config from package.json', (t) => {
   fs.renameSync(path.join(cwd, 'package.json'), path.join(cwd, `package.json.${randomString}-${datetime}.back`));
   fs.writeFileSync(path.join(cwd, 'package.json'), JSON.stringify(packageJson));
 
-  t.deepEqual(getConfig(), sgcrc);
+  const config = getConfig();
 
   // revert local package
   fs.removeSync(path.join(cwd, 'package.json'));
   fs.renameSync(path.join(cwd, `package.json.${randomString}-${datetime}.back`), path.join(cwd, 'package.json'));
+
+  t.deepEqual(config, sgcrc);
 });
 
 test('read global config', (t) => {

test/questions.js

@@ -32,16 +32,16 @@ test.after.always(() => {
 
 test('choices are rendered without emojis', (t) => {
   const sgc = getConfig(path.join(fixtures, '.sgcrc'));
-
-  sgc.emojies = false;
-
   const choicesList = choices(sgc);
 
   t.deepEqual(choicesList, withoutEmoji);
 });
 
 test('choices are rendered with emojis (default)', (t) => {
   const sgc = getConfig(path.join(fixtures, '.sgcrc'));
+
+  sgc.emojies = true;
+
   const choicesList = choices(sgc);
 
   t.deepEqual(choicesList, withEmoji);