Refactor: change function behavior

BREAKING CHANGE: rules are now functions where input and config are passed immediatelly

Author: JPeer264

lib/rules/availableRules.js

@@ -1,29 +1,28 @@
-import getConfig from '../getConfig';
-
-const configuration = getConfig();
-
 const rules = {
-  endWithDot: {
-    message: 'The commit message can not end with a dot',
-    check: (input) => {
+  endWithDot: input => ({
+    message: () => 'The commit message can not end with a dot',
+    check: () => {
       if (input[input.length - 1] === '.') return false;
+
       return true;
     },
-  },
-  maxChar: {
-    message: `The commit message is not allowed to be longer as ${configuration.rules['max-char']}. Consider writing a body.`,
-    check: (input) => {
-      if (input.length > configuration.rules['max-char']) return false;
+  }),
+  maxChar: (input, config) => ({
+    message: () => `The commit message is not allowed to be longer as ${config.rules['max-char']}. Consider writing a body.`,
+    check: () => {
+      if (input.length > config.rules['max-char']) return false;
+
       return true;
     },
-  },
-  minChar: {
-    message: `The commit message has to be at least ${configuration.rules['min-char']} character.`,
-    check: (input) => {
-      if (input.length < configuration.rules['min-char']) return false;
+  }),
+  minChar: (input, config) => ({
+    message: () => `The commit message has to be at least ${config.rules['min-char']} character.`,
+    check: () => {
+      if (input.length < config.rules['min-char']) return false;
+
       return true;
     },
-  },
+  }),
 };
 
 export default rules;

lib/rules/ruleWarningMessages.js

@@ -2,17 +2,17 @@ import entries from 'object.entries';
 import getConfig from '../getConfig';
 import rules from './availableRules';
 
-const configuration = getConfig();
+const config = getConfig();
 
 const ruleWarningMessages = (input) => {
   let warningMessage = '';
-  const configRuleEntries = entries(configuration.rules);
+  const configRuleEntries = entries(config.rules);
 
   configRuleEntries.forEach((rule) => {
     const camelCaseRuleName = (rule[0]).replace(/-([a-z])/g, g => (g[1].toUpperCase()));
-    const ruleIs = rules[camelCaseRuleName].check(input);
+    const ruleIs = rules[camelCaseRuleName](input, config).check();
 
-    if (!ruleIs) warningMessage += `${rules[camelCaseRuleName].message}\n`;
+    if (!ruleIs) warningMessage += `${rules[camelCaseRuleName](input, config).message()}\n`;
   });
 
   return warningMessage;

test/rules/availableRules.js

@@ -1,23 +1,36 @@
 import test from 'ava';
+
 import rules from '../../lib/rules/availableRules';
 
 test('rules endWithDot', (t) => {
-  const endWithDot = rules.endWithDot.check('input with dot.');
-  const endWithoutDot = rules.endWithDot.check('input with dot');
-  t.deepEqual(endWithDot, false);
-  t.deepEqual(endWithoutDot, true);
+  const rulesObj = {
+    'end-with-dot': false,
+  };
+  const endWithDot = rules.endWithDot('input with dot.', { rules: rulesObj }).check();
+  const endWithoutDot = rules.endWithDot('input with dot', { rules: rulesObj }).check();
+
+  t.false(endWithDot);
+  t.true(endWithoutDot);
 });
 
 test('rules minChar', (t) => {
-  const notMinChar = rules.minChar.check('less');
-  const minChar = rules.minChar.check('this are more than 10 characters');
-  t.deepEqual(notMinChar, false);
-  t.deepEqual(minChar, true);
+  const rulesObj = {
+    'min-char': 10,
+  };
+  const notMinChar = rules.minChar('less', { rules: rulesObj }).check();
+  const minChar = rules.minChar('this are more than 10 characters', { rules: rulesObj }).check();
+
+  t.false(notMinChar);
+  t.true(minChar);
 });
 
 test('rules mxChar', (t) => {
-  const moreThanMaxChar = rules.maxChar.check('this are more than 72 characters, believe me or not but the value moreThanMaxChar will be false ;-P');
-  const lessThanMaxChar = rules.maxChar.check('this are less than 72 characters');
-  t.deepEqual(moreThanMaxChar, false);
-  t.deepEqual(lessThanMaxChar, true);
+  const rulesObj = {
+    'max-char': 72,
+  };
+  const moreThanMaxChar = rules.maxChar('this are more than 72 characters, believe me or not but the value moreThanMaxChar will be false ;-P', { rules: rulesObj }).check();
+  const lessThanMaxChar = rules.maxChar('this are less than 72 characters', { rules: rulesObj }).check();
+
+  t.false(moreThanMaxChar);
+  t.true(lessThanMaxChar);
 });