Add SonarCloud integration and improve complexity checking

CI/tooling updates:
- Add SonarCloud scan job to CI workflow
- Add sonar-project.properties configuration
- Improve ci_complexity to use whitelist comparison
- Update whitelizard.txt with current complexity warnings
- Fix pyrefly to only check src/ (not tests/)

The complexity check now:
1. Runs lizard to find complexity violations
2. Compares against whitelizard.txt whitelist
3. Only fails if NEW violations are found
4. Allows existing technical debt to be tracked separately

Author: JRedeker

.github/scripts/ci-utils.sh

@@ -46,11 +46,42 @@ ci_typecheck() {
 
 ci_complexity() {
   _header "📊 COMPLEXITY" "" "CCN ≤ 10 | NLOC ≤ 50 | Params ≤ 6"
-  if ! uv run lizard src/ -C 10 -L 50 -a 6 -w; then
-    _warn "⚠️ COMPLEXITY WARNING" "" "Some functions exceed thresholds"
+
+  # Create temp files for comparison
+  local tmp_current tmp_whitelist tmp_raw
+  tmp_current=$(mktemp)
+  tmp_whitelist=$(mktemp)
+  tmp_raw=$(mktemp)
+
+  # Run lizard and capture output (suppress uv build messages)
+  uv run lizard src/ -C 10 -L 50 -a 6 -w > "$tmp_raw" 2>&1 || true
+
+  # Extract just the warning lines and sort
+  grep "^src/" "$tmp_raw" | sort > "$tmp_current" || true
+  rm -f "$tmp_raw"
+
+  if [ ! -s "$tmp_current" ]; then
+    rm -f "$tmp_current" "$tmp_whitelist"
+    _success "✅ COMPLEXITY PASSED"
+    return 0
+  fi
+
+  # Get whitelisted warnings (skip comments and empty lines)
+  grep "^src/" whitelizard.txt | sort > "$tmp_whitelist" 2>/dev/null || true
+
+  # Find new warnings not in whitelist
+  local new_warnings
+  new_warnings=$(comm -23 "$tmp_current" "$tmp_whitelist")
+
+  rm -f "$tmp_current" "$tmp_whitelist"
+
+  if [ -n "$new_warnings" ]; then
+    echo "$new_warnings"
+    _error "❌ NEW COMPLEXITY VIOLATIONS" "" "Add to whitelizard.txt or refactor"
     return 1
   fi
-  _success "✅ COMPLEXITY PASSED"
+
+  _success "✅ COMPLEXITY PASSED (whitelisted warnings only)"
 }
 
 ci_test() {

.github/workflows/ci.yml

@@ -77,6 +77,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Full history for SonarCloud
       - name: Install gum
         run: |
           sudo mkdir -p /etc/apt/keyrings
@@ -88,7 +90,31 @@ jobs:
           enable-cache: true
       - run: uv python install ${{ env.PYTHON_VERSION }}
       - run: uv sync --dev
-      - run: source .github/scripts/ci-utils.sh && ci_test
+      - name: Run tests with coverage
+        run: uv run pytest --cov=src/jdo --cov-report=xml --cov-branch -q
+      - name: Upload coverage artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: coverage.xml
+          retention-days: 1
+
+  sonarcloud:
+    name: "📊 SonarCloud"
+    runs-on: ubuntu-latest
+    needs: test
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0  # Full history for blame information
+      - name: Download coverage artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: coverage-report
+      - name: SonarCloud Scan
+        uses: SonarSource/sonarqube-scan-action@v5
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
 
   roadmap:
     name: "📋 Roadmap"

pyproject.toml

@@ -171,7 +171,7 @@ docstring-code-format = true
 # NOTE: pyrefly has known false positives with SQLModel/SQLAlchemy - check runtime if unsure
 [tool.pyrefly]
 python-version = "3.11.0"
-project-includes = ["src", "tests"]
+project-includes = ["src"]
 search-path = ["src"]
 
 [tool.pyrefly.errors]

sonar-project.properties

@@ -0,0 +1,27 @@
+# SonarCloud configuration
+# Docs: https://docs.sonarsource.com/sonarqube-cloud/
+
+# Project identification
+sonar.projectKey=JRedeker_jdo
+sonar.organization=jredeker
+
+# Project metadata
+sonar.projectName=jdo
+sonar.projectVersion=0.1.0
+
+# Source code location
+sonar.sources=src
+sonar.tests=tests
+
+# Python configuration
+sonar.python.version=3.11
+
+# Coverage report path (generated by pytest-cov)
+sonar.python.coverage.reportPaths=coverage.xml
+
+# Exclusions
+sonar.exclusions=**/migrations/**,**/__pycache__/**
+sonar.test.exclusions=**/tests/**
+
+# Encoding
+sonar.sourceEncoding=UTF-8

whitelizard.txt

@@ -1,10 +1,36 @@
 # Whitelist for pre-existing complexity warnings
 # These functions exceed thresholds but are acceptable for now
+# Format matches exact lizard output for comparison
 
-src/jdo/commands/handlers.py:54: warning: execute has 36 NLOC, 7 CCN, 226 token, 3 PARAM, 56 length, 0 ND
-src/jdo/commands/handlers.py:196: warning: execute has 40 NLOC, 9 CCN, 255 token, 3 PARAM, 61 length, 0 ND
-src/jdo/commands/handlers.py:313: warning: execute has 39 NLOC, 6 CCN, 199 token, 3 PARAM, 59 length, 0 ND
-src/jdo/commands/handlers.py:1242: warning: _show_analysis_with_options has 55 NLOC, 4 CCN, 308 token, 5 PARAM, 75 length, 0 ND
-src/jdo/db/session.py:166: warning: check_and_generate_recurring_instances has 26 NLOC, 7 CCN, 182 token, 2 PARAM, 55 length, 0 ND
-src/jdo/db/session.py:223: warning: generate_next_instance_for_recurring has 26 NLOC, 7 CCN, 161 token, 3 PARAM, 53 length, 0 ND
-src/jdo/widgets/chat_message.py:59: warning: __init__ has 15 NLOC, 2 CCN, 98 token, 7 PARAM, 26 length, 0 ND
+src/jdo/screens/chat.py:461: warning: _handle_command has 27 NLOC, 7 CCN, 161 token, 2 PARAM, 54 length, 0 ND
+src/jdo/screens/chat.py:555: warning: _apply_modification_request has 41 NLOC, 9 CCN, 199 token, 2 PARAM, 59 length, 0 ND
+src/jdo/screens/chat.py:804: warning: _save_pending_entity has 39 NLOC, 7 CCN, 203 token, 1 PARAM, 51 length, 0 ND
+src/jdo/screens/chat.py:939: warning: _do_ai_streaming has 40 NLOC, 7 CCN, 248 token, 2 PARAM, 59 length, 0 ND
+src/jdo/commands/handlers.py:61: warning: execute has 43 NLOC, 8 CCN, 263 token, 3 PARAM, 66 length, 0 ND
+src/jdo/commands/handlers.py:233: warning: execute has 40 NLOC, 9 CCN, 255 token, 3 PARAM, 61 length, 0 ND
+src/jdo/commands/handlers.py:350: warning: execute has 40 NLOC, 6 CCN, 208 token, 3 PARAM, 60 length, 0 ND
+src/jdo/commands/handlers.py:901: warning: execute has 40 NLOC, 3 CCN, 143 token, 3 PARAM, 51 length, 0 ND
+src/jdo/commands/handlers.py:1291: warning: execute has 49 NLOC, 5 CCN, 196 token, 3 PARAM, 63 length, 0 ND
+src/jdo/commands/handlers.py:1399: warning: execute has 55 NLOC, 7 CCN, 241 token, 3 PARAM, 73 length, 0 ND
+src/jdo/commands/handlers.py:1510: warning: execute has 33 NLOC, 4 CCN, 145 token, 3 PARAM, 51 length, 0 ND
+src/jdo/commands/handlers.py:1673: warning: _show_dashboard has 60 NLOC, 5 CCN, 317 token, 2 PARAM, 69 length, 0 ND
+src/jdo/commands/handlers.py:1831: warning: _handle_at_risk_abandon has 50 NLOC, 5 CCN, 208 token, 3 PARAM, 61 length, 0 ND
+src/jdo/commands/handlers.py:2050: warning: _show_analysis_with_options has 55 NLOC, 11 CCN, 308 token, 5 PARAM, 75 length, 0 ND
+src/jdo/commands/handlers.py:2240: warning: execute has 84 NLOC, 11 CCN, 344 token, 3 PARAM, 109 length, 0 ND
+src/jdo/ai/tools.py:337: warning: _register_time_coaching_tools has 9 NLOC, 1 CCN, 39 token, 1 PARAM, 112 length, 0 ND
+src/jdo/db/persistence.py:184: warning: save_task has 28 NLOC, 4 CCN, 205 token, 2 PARAM, 56 length, 0 ND
+src/jdo/db/persistence.py:351: warning: save_recurring_commitment has 42 NLOC, 5 CCN, 298 token, 2 PARAM, 78 length, 0 ND
+src/jdo/db/task_history_service.py:41: warning: log_event has 28 NLOC, 1 CCN, 120 token, 9 PARAM, 48 length, 0 ND
+src/jdo/db/session.py:174: warning: check_and_generate_recurring_instances has 26 NLOC, 7 CCN, 182 token, 2 PARAM, 55 length, 0 ND
+src/jdo/db/session.py:231: warning: generate_next_instance_for_recurring has 26 NLOC, 7 CCN, 161 token, 3 PARAM, 53 length, 0 ND
+src/jdo/widgets/data_panel.py:371: warning: _render_list_item has 35 NLOC, 7 CCN, 237 token, 3 PARAM, 54 length, 0 ND
+src/jdo/widgets/data_panel.py:889: warning: _render_integrity has 35 NLOC, 3 CCN, 340 token, 1 PARAM, 52 length, 0 ND
+src/jdo/widgets/data_panel.py:959: warning: _render_cleanup has 42 NLOC, 7 CCN, 320 token, 1 PARAM, 54 length, 0 ND
+src/jdo/widgets/chat_message.py:67: warning: __init__ has 17 NLOC, 2 CCN, 108 token, 7 PARAM, 28 length, 0 ND
+src/jdo/integrity/service.py:129: warning: mark_commitment_at_risk has 60 NLOC, 5 CCN, 304 token, 5 PARAM, 92 length, 0 ND
+src/jdo/integrity/service.py:222: warning: recover_commitment has 45 NLOC, 9 CCN, 247 token, 4 PARAM, 78 length, 0 ND
+src/jdo/integrity/service.py:327: warning: calculate_integrity_metrics has 53 NLOC, 3 CCN, 319 token, 2 PARAM, 82 length, 0 ND
+src/jdo/integrity/service.py:410: warning: detect_risks has 45 NLOC, 4 CCN, 252 token, 2 PARAM, 73 length, 0 ND
+src/jdo/integrity/service.py:525: warning: _calculate_streak_weeks has 51 NLOC, 14 CCN, 315 token, 2 PARAM, 79 length, 0 ND
+src/jdo/integrity/service.py:605: warning: _calculate_estimation_accuracy has 33 NLOC, 8 CCN, 237 token, 2 PARAM, 66 length, 0 ND
+src/jdo/app.py:613: warning: on_hierarchy_view_item_selected has 53 NLOC, 8 CCN, 288 token, 2 PARAM, 62 length, 0 ND