Fixed tests that were failing in Firefox due to class names in stack traces

Author: JamesMessinger

test/specs/ono-extend.spec.js

@@ -58,7 +58,11 @@ describe("Ono.extend()", () => {
     expect(error).to.be.an.instanceOf(ValidationError);
     expect(error.name).to.equal("ValidationError");
     expect(error.message).to.equal("Error #42: Invalid emailAddress");
-    expect(error.stack).to.satisfy(compareStacks(["createValidationError"]));
+    expect(error.stack).to.satisfy(compareStacks(
+      host.error.stack.includesClassNames
+        ? ["ValidationError", "createValidationError"]
+        : ["createValidationError"]
+    ));
     expect(error).to.satisfy(compareKeys("name", "message", "stack", "toJSON", "errorNumber", "fieldName"));
 
     expect(error.toJSON()).to.satisfy(comparePOJO({
@@ -106,7 +110,9 @@ describe("Ono.extend()", () => {
     expect(error.name).to.equal("ServerError");
     expect(error.message).to.equal("HTTP 500: A server error occurred");
     expect(error.stack).to.satisfy(compareStacks(
-      ["createServerError"],
+      host.error.stack.includesClassNames
+        ? ["ServerError", "createServerError"]
+        : ["createServerError"],
       ["createOriginalError"],
     ));
     expect(error).to.satisfy(compareKeys("name", "message", "stack", "toJSON", "method", "url"));

test/utils/host.js

@@ -58,12 +58,20 @@ module.exports = Object.assign({}, host, {
        * Safari normally includes the function name, but not with code coverage instrumentation.
        */
       includesFunctionNames: sampleError.stack.includes("getSampleError") && !host.browser.safari,
+
+      /**
+       * Indicates whether the stack traces include error class names
+       *
+       * As of April 2020, only Firefox does this
+       */
+      includesClassNames: sampleError.stack.includes("CustomError"),
     }
   },
 });
 
 function getSampleError () {
-  return new Error("THIS IS THE MESSAGE");
+  class CustomError extends Error {}
+  return new CustomError("THIS IS THE MESSAGE");
 }
 
 function hasKey (error, key) {