Skip to content

Commit 00f76fe

Browse files
committed
added some test cases
1 parent 18904dd commit 00f76fe

File tree

4 files changed

+8
-14
lines changed

4 files changed

+8
-14
lines changed

src/main/java/net/sf/jsqlparser/expression/operators/relational/OldOracleJoinBinaryExpression.java

100755100644
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ public abstract class OldOracleJoinBinaryExpression extends BinaryExpression imp
2727

2828
private int oldOracleJoinSyntax = NO_ORACLE_JOIN;
2929

30+
@Override
3031
public void setOldOracleJoinSyntax(int oldOracleJoinSyntax) {
3132
this.oldOracleJoinSyntax = oldOracleJoinSyntax;
3233
if (oldOracleJoinSyntax < 0 || oldOracleJoinSyntax > 2) {
@@ -39,6 +40,7 @@ public String toString() {
3940
return (isNot() ? "NOT " : "") + getLeftExpression() + (oldOracleJoinSyntax == ORACLE_JOIN_RIGHT ? "(+)" : "") + " " + getStringExpression() + " " + getRightExpression() + (oldOracleJoinSyntax == ORACLE_JOIN_LEFT ? "(+)" : "");
4041
}
4142

43+
@Override
4244
public int getOldOracleJoinSyntax() {
4345
return oldOracleJoinSyntax;
4446
}

src/main/java/net/sf/jsqlparser/statement/select/PivotXml.java

100755100644
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ public class PivotXml extends Pivot {
3030
private SelectBody inSelect;
3131
private boolean inAny = false;
3232

33+
@Override
3334
public void accept(PivotVisitor pivotVisitor) {
3435
pivotVisitor.visit(this);
3536
}

src/main/javacc/net/sf/jsqlparser/parser/JSqlParserCC.jj

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -773,20 +773,6 @@ FunctionItem FunctionItem():
773773
}
774774

775775

776-
777-
/* List<Column> PivotForColumn():
778-
{
779-
List<Column> columns = new ArrayList<Column>();
780-
Column column;
781-
}
782-
{
783-
column = Column()
784-
{
785-
columns.add(column);
786-
return columns;
787-
}
788-
}*/
789-
790776
List<Column> PivotForColumns():
791777
{
792778
List<Column> columns = new ArrayList<Column>();

src/test/java/net/sf/jsqlparser/test/select/SelectTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -799,6 +799,11 @@ public void testOracleJoin3() throws JSQLParserException {
799799
String stmt = "SELECT * FROM tabelle1, tabelle2 WHERE tabelle1.a(+) > tabelle2.b";
800800
assertSqlCanBeParsedAndDeparsed(stmt);
801801
}
802+
803+
public void testOracleJoin3_1() throws JSQLParserException {
804+
String stmt = "SELECT * FROM tabelle1, tabelle2 WHERE tabelle1.a > tabelle2.b(+)";
805+
assertSqlCanBeParsedAndDeparsed(stmt);
806+
}
802807

803808
public void testOracleJoin4() throws JSQLParserException {
804809
String stmt = "SELECT * FROM tabelle1, tabelle2 WHERE tabelle1.a(+) = tabelle2.b AND tabelle1.b(+) IN ('A', 'B')";

0 commit comments

Comments
 (0)