#modify net.sf.jsqlparser.statement.insert.Insert Method:toString() if itemsList and useSelectBrackets together not null will error

#modify PlainSelect.getStringList change sql append to StringBuilder

Author: [email protected]

src/main/java/net/sf/jsqlparser/statement/insert/Insert.java

@@ -197,17 +197,19 @@ public String toString() {
 
         if (itemsList != null) {
             sql.append(itemsList);
+        }else {
+            if (useSelectBrackets) {
+                sql.append("(");
+            }
+            if (select != null) {
+                sql.append(select);
+            }
+            if (useSelectBrackets) {
+                sql.append(")");
+            }
         }
 
-        if (useSelectBrackets) {
-            sql.append("(");
-        }
-        if (select != null) {
-            sql.append(select);
-        }
-        if (useSelectBrackets) {
-            sql.append(")");
-        }
+
 
         if (useDuplicate){
             sql.append(" ON DUPLICATE KEY UPDATE ");

src/main/java/net/sf/jsqlparser/statement/select/PlainSelect.java

@@ -407,25 +407,29 @@ public static String getStringList(List<?> list) {
      * @return comma separated list of the elements in the list
      */
     public static String getStringList(List<?> list, boolean useComma, boolean useBrackets) {
-        String ans = "";
+        StringBuilder ans=new StringBuilder();
+//        String ans = "";
         String comma = ",";
         if (!useComma) {
             comma = "";
         }
         if (list != null) {
             if (useBrackets) {
-                ans += "(";
+                ans.append("(");
+//                ans += "(";
             }
 
             for (int i = 0; i < list.size(); i++) {
-                ans += "" + list.get(i) + ((i < list.size() - 1) ? comma + " " : "");
+                ans.append(list.get(i)).append(((i < list.size() - 1) ? comma + " " : ""));
+//                ans += "" + list.get(i) + ((i < list.size() - 1) ? comma + " " : "");
             }
 
             if (useBrackets) {
-                ans += ")";
+                ans.append(")");
+//                ans += ")";
             }
         }
 
-        return ans;
+        return ans.toString();
     }
 }