Skip to content

Commit 62cf81d

Browse files
committed
Merge pull request #219 from georgekankava/staging/useless-parentheses-around-expressions-should-be-removed-to-prevent-any-misunderstanding-fix-1
multiple code improvements 1
2 parents bcfa257 + e6becde commit 62cf81d

File tree

6 files changed

+7
-7
lines changed

6 files changed

+7
-7
lines changed

src/main/java/net/sf/jsqlparser/expression/operators/relational/ExistsExpression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void accept(ExpressionVisitor expressionVisitor) {
5151
}
5252

5353
public String getStringExpression() {
54-
return ((not) ? "NOT " : "") + "EXISTS";
54+
return (not ? "NOT " : "") + "EXISTS";
5555
}
5656

5757
@Override

src/main/java/net/sf/jsqlparser/expression/operators/relational/InExpression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ private String getLeftExpressionString() {
9797

9898
@Override
9999
public String toString() {
100-
return (leftExpression == null ? leftItemsList : getLeftExpressionString()) + " " + ((not) ? "NOT " : "") + "IN " + rightItemsList + "";
100+
return (leftExpression == null ? leftItemsList : getLeftExpressionString()) + " " + (not ? "NOT " : "") + "IN " + rightItemsList + "";
101101
}
102102

103103
@Override

src/main/java/net/sf/jsqlparser/expression/operators/relational/IsNullExpression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,6 @@ public void accept(ExpressionVisitor expressionVisitor) {
5252

5353
@Override
5454
public String toString() {
55-
return leftExpression + " IS " + ((not) ? "NOT " : "") + "NULL";
55+
return leftExpression + " IS " + (not ? "NOT " : "") + "NULL";
5656
}
5757
}

src/main/java/net/sf/jsqlparser/expression/operators/relational/LikeExpression.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public void accept(ExpressionVisitor expressionVisitor) {
4646

4747
@Override
4848
public String getStringExpression() {
49-
return ((not) ? "NOT " : "") + (caseInsensitive?"ILIKE":"LIKE");
49+
return (not ? "NOT " : "") + (caseInsensitive?"ILIKE":"LIKE");
5050
}
5151

5252
@Override

src/main/java/net/sf/jsqlparser/statement/select/Fetch.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,6 @@ public void setFetchParamFirst(boolean b) {
6565

6666
@Override
6767
public String toString() {
68-
return " FETCH " + (isFetchParamFirst ? "FIRST" : "NEXT") + " " + (fetchJdbcParameter ? "?" : rowCount + "") + " "+ fetchParam + " ONLY";
68+
return " FETCH " + (isFetchParamFirst ? "FIRST" : "NEXT") + " " + (fetchJdbcParameter ? "?" : Long.toString(rowCount)) + " " + fetchParam + " ONLY";
6969
}
7070
}

src/main/java/net/sf/jsqlparser/statement/select/Limit.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,10 +90,10 @@ public String toString() {
9090
if (limitNull) {
9191
retVal += " LIMIT NULL";
9292
} else if (rowCount >= 0 || rowCountJdbcParameter) {
93-
retVal += " LIMIT " + (rowCountJdbcParameter ? "?" : rowCount + "");
93+
retVal += " LIMIT " + (rowCountJdbcParameter ? "?" : Long.toString(rowCount));
9494
}
9595
if (offset > 0 || offsetJdbcParameter) {
96-
retVal += " OFFSET " + (offsetJdbcParameter ? "?" : offset + "");
96+
retVal += " OFFSET " + (offsetJdbcParameter ? "?" : Long.toString(offset));
9797
}
9898
return retVal;
9999
}

0 commit comments

Comments
 (0)