removed some changes

Author: wumpz

src/main/java/net/sf/jsqlparser/schema/Column.java

@@ -22,12 +22,11 @@
 package net.sf.jsqlparser.schema;
 
 import net.sf.jsqlparser.expression.*;
-import net.sf.jsqlparser.statement.select.*;
 
 /**
  * A column. It can have the table name it belongs to.
  */
-public class Column implements SelectItem, Expression, MultiPartName {
+public final class Column implements Expression, MultiPartName {
 
     private Table table;
     private String columnName;
@@ -62,21 +61,18 @@ public void setColumnName(String string) {
 
     @Override
     public String getFullyQualifiedName() {
-        String fqn = "";
+        StringBuilder fqn = new StringBuilder();
 
         if (table != null) {
-            fqn += table.getFullyQualifiedName();
+            fqn.append(table.getFullyQualifiedName());
         }
-        if (!fqn.isEmpty()) {
-            fqn += ".";
+        if (fqn.length()>0) {
+            fqn.append('.');
         }
-
-
         if (columnName != null) {
-            fqn += columnName;
+            fqn.append(columnName);
         }
-
-        return fqn;
+        return fqn.toString();
     }
 
     @Override
@@ -88,9 +84,4 @@ public void accept(ExpressionVisitor expressionVisitor) {
     public String toString() {
         return getFullyQualifiedName();
     }
-
-    @Override
-    public void accept(SelectItemVisitor selectItemVisitor) {
-        selectItemVisitor.visit(this);
-    }
 }

src/main/java/net/sf/jsqlparser/schema/Server.java

@@ -23,7 +23,7 @@
 
 import java.util.regex.*;
 
-public class Server implements MultiPartName {
+public final class Server implements MultiPartName {
     public static final Pattern SERVER_PATTERN = Pattern.compile("\\[([^\\]]+?)(?:\\\\([^\\]]+))?\\]");
 
     private String serverName;

src/main/java/net/sf/jsqlparser/statement/select/AllColumns.java

@@ -26,10 +26,9 @@
 /**
  * All the columns (as in "SELECT * FROM ...")
  */
-public class AllColumns extends Column implements SelectItem {
+public class AllColumns implements SelectItem {
 
     public AllColumns() {
-        super("*");
     }
 
     @Override
@@ -39,6 +38,6 @@ public void accept(SelectItemVisitor selectItemVisitor) {
 
     @Override
     public String toString() {
-        return getColumnName();
+        return "*";
     }
 }

src/main/java/net/sf/jsqlparser/statement/select/AllTableColumns.java

@@ -24,16 +24,34 @@
 /**
  * All the columns of a table (as in "SELECT TableName.* FROM ...")
  */
-
 import net.sf.jsqlparser.schema.*;
 
-public class AllTableColumns extends Column implements SelectItem {
-    public AllTableColumns(Table table) {
-        super(table, "*");
-    }
+public class AllTableColumns implements SelectItem {
+
+	private Table table;
+
+	public AllTableColumns() {
+	}
+
+	public AllTableColumns(Table tableName) {
+		this.table = tableName;
+	}
+
+	public Table getTable() {
+		return table;
+	}
+
+	public void setTable(Table table) {
+		this.table = table;
+	}
+
+	@Override
+	public void accept(SelectItemVisitor selectItemVisitor) {
+		selectItemVisitor.visit(this);
+	}
 
-    @Override
-    public void accept(SelectItemVisitor selectItemVisitor) {
-        selectItemVisitor.visit(this);
-    }
+	@Override
+	public String toString() {
+		return table + ".*";
+	}
 }

src/main/java/net/sf/jsqlparser/statement/select/SelectItemVisitor.java

@@ -21,11 +21,9 @@
  */
 package net.sf.jsqlparser.statement.select;
 
-import net.sf.jsqlparser.schema.*;
-
 public interface SelectItemVisitor {
 
-	void visit(Column column);
+	void visit(AllColumns allColumns);
 
 	void visit(AllTableColumns allTableColumns);
 

src/main/java/net/sf/jsqlparser/util/AddAliasesVisitor.java

@@ -63,11 +63,6 @@ public void visit(SetOperationList setOpList) {
 		}
 	}
 
-	@Override
-	public void visit(Column column) {
-		throw new UnsupportedOperationException("Not supported yet.");
-	}
-
 	@Override
 	public void visit(AllTableColumns allTableColumns) {
 		throw new UnsupportedOperationException("Not supported yet.");
@@ -117,4 +112,9 @@ public void setPrefix(String prefix) {
 	public void visit(WithItem withItem) {
 		throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
 	}
+
+	@Override
+	public void visit(AllColumns allColumns) {
+		throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
+	}
 }

src/main/java/net/sf/jsqlparser/util/ConnectExpressionsVisitor.java

@@ -22,7 +22,6 @@
 package net.sf.jsqlparser.util;
 
 import net.sf.jsqlparser.expression.*;
-import net.sf.jsqlparser.schema.*;
 import net.sf.jsqlparser.statement.select.*;
 
 import java.util.*;
@@ -38,7 +37,7 @@
 public abstract class ConnectExpressionsVisitor implements SelectVisitor, SelectItemVisitor {
 
 	private String alias = "expr";
-	private List<SelectExpressionItem> itemsExpr = new LinkedList<SelectExpressionItem>();
+	private final List<SelectExpressionItem> itemsExpr = new LinkedList<SelectExpressionItem>();
 
 	public ConnectExpressionsVisitor() {
 	}
@@ -94,12 +93,12 @@ public void visit(WithItem withItem) {
 	}
 
 	@Override
-    public void visit(Column column) {
+	public void visit(AllTableColumns allTableColumns) {
 		throw new UnsupportedOperationException("Not supported yet.");
 	}
 
 	@Override
-	public void visit(AllTableColumns allTableColumns) {
+	public void visit(AllColumns allColumns) {
 		throw new UnsupportedOperationException("Not supported yet.");
 	}
 

src/main/java/net/sf/jsqlparser/util/deparser/SelectDeParser.java

@@ -348,4 +348,9 @@ public void visit(LateralSubSelect lateralSubSelect) {
 	public void visit(ValuesList valuesList) {
 		buffer.append(valuesList.toString());
 	}
+
+	@Override
+	public void visit(AllColumns allColumns) {
+		buffer.append('*');
+	}
 }

src/test/java/net/sf/jsqlparser/test/select/SelectTest.java

@@ -161,7 +161,7 @@ public void testOperationsWithSigns() throws JSQLParserException  {
 		assertTrue(sub.getRightExpression() instanceof SignedExpression);
 
 		SignedExpression sexpr = (SignedExpression) sub.getRightExpression();
-		assertEquals("-", sexpr.getSign());
+		assertEquals('-', sexpr.getSign());
 		assertEquals("1", sexpr.getExpression().toString());
     }