Skip to content

Commit 8bff2c9

Browse files
committed
some minor additions to named parameters
1 parent 284ec72 commit 8bff2c9

File tree

3 files changed

+32
-50
lines changed

3 files changed

+32
-50
lines changed

src/main/java/net/sf/jsqlparser/expression/JdbcNamedParameter.java

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -19,36 +19,18 @@
1919
* <http://www.gnu.org/licenses/lgpl-2.1.html>.
2020
* #L%
2121
*/
22-
/*
23-
* Copyright (C) 2013 JSQLParser.
24-
*
25-
* This library is free software; you can redistribute it and/or
26-
* modify it under the terms of the GNU Lesser General Public
27-
* License as published by the Free Software Foundation; either
28-
* version 2.1 of the License, or (at your option) any later version.
29-
*
30-
* This library is distributed in the hope that it will be useful,
31-
* but WITHOUT ANY WARRANTY; without even the implied warranty of
32-
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
33-
* Lesser General Public License for more details.
34-
*
35-
* You should have received a copy of the GNU Lesser General Public
36-
* License along with this library; if not, write to the Free Software
37-
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
38-
* MA 02110-1301 USA
39-
*/
4022
package net.sf.jsqlparser.expression;
4123

4224
/**
4325
*
4426
* @author aud
4527
*/
4628
public class JdbcNamedParameter implements Expression {
47-
48-
private String name;
49-
50-
/**
51-
* The name of the function, i.e. "MAX"
29+
30+
private String name;
31+
32+
/**
33+
* The name of the parameter
5234
*
5335
* @return the name of the parameter
5436
*/
@@ -67,6 +49,6 @@ public void accept(ExpressionVisitor expressionVisitor) {
6749

6850
@Override
6951
public String toString() {
70-
return ":"+name;
52+
return ":" + name;
7153
}
7254
}

src/main/java/net/sf/jsqlparser/util/deparser/ExpressionDeParser.java

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -96,12 +96,12 @@ public void visit(Between between) {
9696

9797
}
9898

99-
@Override
100-
public void visit(EqualsTo equalsTo) {
101-
visitOldOracleJoinBinaryExpression(equalsTo, " = ");
102-
}
99+
@Override
100+
public void visit(EqualsTo equalsTo) {
101+
visitOldOracleJoinBinaryExpression(equalsTo, " = ");
102+
}
103103

104-
@Override
104+
@Override
105105
public void visit(Division division) {
106106
visitBinaryExpression(division, " / ");
107107

@@ -117,25 +117,25 @@ public void visitOldOracleJoinBinaryExpression(OldOracleJoinBinaryExpression exp
117117
if (expression.isNot()) {
118118
buffer.append(" NOT ");
119119
}
120-
expression.getLeftExpression().accept(this);
120+
expression.getLeftExpression().accept(this);
121121
if (expression.getOldOracleJoinSyntax() == EqualsTo.ORACLE_JOIN_RIGHT) {
122122
buffer.append("(+)");
123123
}
124124
buffer.append(operator);
125-
expression.getRightExpression().accept(this);
125+
expression.getRightExpression().accept(this);
126126
if (expression.getOldOracleJoinSyntax() == EqualsTo.ORACLE_JOIN_LEFT) {
127127
buffer.append("(+)");
128128
}
129129
}
130130

131131
@Override
132132
public void visit(GreaterThan greaterThan) {
133-
visitOldOracleJoinBinaryExpression(greaterThan, " > ");
133+
visitOldOracleJoinBinaryExpression(greaterThan, " > ");
134134
}
135135

136136
@Override
137137
public void visit(GreaterThanEquals greaterThanEquals) {
138-
visitOldOracleJoinBinaryExpression(greaterThanEquals, " >= ");
138+
visitOldOracleJoinBinaryExpression(greaterThanEquals, " >= ");
139139

140140
}
141141

@@ -145,9 +145,9 @@ public void visit(InExpression inExpression) {
145145
inExpression.getLeftItemsList().accept(this);
146146
} else {
147147
inExpression.getLeftExpression().accept(this);
148-
if (inExpression.getOldOracleJoinSyntax() == SupportsOldOracleJoinSyntax.ORACLE_JOIN_RIGHT) {
149-
buffer.append("(+)");
150-
}
148+
if (inExpression.getOldOracleJoinSyntax() == SupportsOldOracleJoinSyntax.ORACLE_JOIN_RIGHT) {
149+
buffer.append("(+)");
150+
}
151151
}
152152
if (inExpression.isNot()) {
153153
buffer.append(" NOT");
@@ -206,13 +206,13 @@ public void visit(LongValue longValue) {
206206

207207
@Override
208208
public void visit(MinorThan minorThan) {
209-
visitOldOracleJoinBinaryExpression(minorThan, " < ");
209+
visitOldOracleJoinBinaryExpression(minorThan, " < ");
210210

211211
}
212212

213213
@Override
214214
public void visit(MinorThanEquals minorThanEquals) {
215-
visitOldOracleJoinBinaryExpression(minorThanEquals, " <= ");
215+
visitOldOracleJoinBinaryExpression(minorThanEquals, " <= ");
216216

217217
}
218218

@@ -224,7 +224,7 @@ public void visit(Multiplication multiplication) {
224224

225225
@Override
226226
public void visit(NotEqualsTo notEqualsTo) {
227-
visitOldOracleJoinBinaryExpression(notEqualsTo, " <> ");
227+
visitOldOracleJoinBinaryExpression(notEqualsTo, " <> ");
228228

229229
}
230230

@@ -373,9 +373,9 @@ public void visit(CaseExpression caseExpression) {
373373
buffer.append(" ");
374374
}
375375

376-
for (Expression exp : caseExpression.getWhenClauses()) {
377-
exp.accept(this);
378-
}
376+
for (Expression exp : caseExpression.getWhenClauses()) {
377+
exp.accept(this);
378+
}
379379

380380
Expression elseExp = caseExpression.getElseExpression();
381381
if (elseExp != null) {
@@ -415,7 +415,7 @@ public void visit(Concat concat) {
415415

416416
@Override
417417
public void visit(Matches matches) {
418-
visitOldOracleJoinBinaryExpression(matches, " @@ ");
418+
visitOldOracleJoinBinaryExpression(matches, " @@ ");
419419
}
420420

421421
@Override
@@ -478,8 +478,8 @@ public void visit(IntervalExpression iexpr) {
478478
buffer.append(iexpr.toString());
479479
}
480480

481-
@Override
482-
public void visit(JdbcNamedParameter jdbcNamedParameter) {
483-
buffer.append(jdbcNamedParameter.toString());
484-
}
481+
@Override
482+
public void visit(JdbcNamedParameter jdbcNamedParameter) {
483+
buffer.append(jdbcNamedParameter.toString());
484+
}
485485
}

src/main/javacc/net/sf/jsqlparser/parser/JSqlParserCC.jj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1675,11 +1675,11 @@ Expression PrimaryExpression():
16751675

16761676
<K_NULL> { retval = new NullValue(); }
16771677

1678-
| retval=CaseWhenExpression()
1678+
| retval=CaseWhenExpression()
16791679

1680-
| "?" { retval = new JdbcParameter(); }
1680+
| "?" { retval = new JdbcParameter(); }
16811681

1682-
| LOOKAHEAD(JdbcNamedParameter()) retval=JdbcNamedParameter()
1682+
| retval=JdbcNamedParameter()
16831683

16841684
| LOOKAHEAD(AnalyticExpression()) retval=AnalyticExpression()
16851685

0 commit comments

Comments
 (0)