Merge pull request #372 from dhlin/master

fixed NPE in SubSelect without withItemsList in ExpressionVisitorAdapter

Author: wumpz

src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java

@@ -213,8 +213,10 @@ public void visit(Column column) {
     @Override
     public void visit(SubSelect subSelect) {
         if (selectVisitor != null) {
-            for (WithItem item : subSelect.getWithItemsList()) {
-                item.accept(selectVisitor);
+            if (subSelect.getWithItemsList() != null) {
+                for (WithItem item : subSelect.getWithItemsList()) {
+                    item.accept(selectVisitor);
+                }
             }
             subSelect.getSelectBody().accept(selectVisitor);
         }

src/test/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapterTest.java

@@ -27,13 +27,15 @@
 import net.sf.jsqlparser.schema.Column;
 import net.sf.jsqlparser.statement.select.PlainSelect;
 import net.sf.jsqlparser.statement.select.Select;
+import net.sf.jsqlparser.statement.select.SelectVisitorAdapter;
 import org.junit.After;
 import org.junit.AfterClass;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
 import org.junit.Before;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -169,4 +171,19 @@ public void visit(Column column) {
         assertEquals(1, columnList.size());
         assertEquals("bar", columnList.get(0));
     }
+
+    @Test
+    public void testSubSelectExpressionProblem() throws JSQLParserException {
+        Select select = (Select) CCJSqlParserUtil.parse( "SELECT * FROM t1 WHERE EXISTS (SELECT * FROM t2 WHERE t2.col2 = t1.col1)" );
+        PlainSelect plainSelect = (PlainSelect) select.getSelectBody();
+        Expression where = plainSelect.getWhere();
+        ExpressionVisitorAdapter adapter = new ExpressionVisitorAdapter();
+        adapter.setSelectVisitor(new SelectVisitorAdapter());
+        try {
+            where.accept(adapter);
+        } catch (NullPointerException npe){
+            fail();
+        }
+    }
+
 }