Skip to content

Commit 994e6c6

Browse files
fix: ExpressionList of Expressions in Values
1 parent 30498d0 commit 994e6c6

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/main/java/net/sf/jsqlparser/statement/select/Values.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,22 @@
1818

1919
public class Values extends Select {
2020

21-
private ExpressionList expressions;
21+
private ExpressionList<Expression> expressions;
2222

2323
public Values() {
2424
// empty constructor
2525
}
2626

27-
public Values(ExpressionList expressions) {
27+
public Values(ExpressionList<Expression> expressions) {
2828
this.expressions = expressions;
2929
}
3030

31-
public ExpressionList getExpressions() {
31+
public ExpressionList<?> getExpressions() {
3232
return expressions;
3333
}
3434

3535

36-
public void setExpressions(ExpressionList expressions) {
36+
public void setExpressions(ExpressionList<Expression> expressions) {
3737
this.expressions = expressions;
3838
}
3939

@@ -49,7 +49,7 @@ public void accept(SelectVisitor selectVisitor) {
4949
selectVisitor.visit(this);
5050
}
5151

52-
public Values withExpressions(ExpressionList expressions) {
52+
public Values withExpressions(ExpressionList<Expression> expressions) {
5353
this.setExpressions(expressions);
5454
return this;
5555
}
@@ -60,7 +60,7 @@ public Values addExpressions(Expression... expressions) {
6060

6161
public Values addExpressions(Collection<? extends Expression> expressions) {
6262
if (this.expressions == null) {
63-
this.expressions = new ParenthesedExpressionList();
63+
this.expressions = new ParenthesedExpressionList<>();
6464
}
6565
this.expressions.addAll(expressions);
6666
return this;

src/test/java/net/sf/jsqlparser/statement/insert/InsertTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,11 @@ public void testInsertMultiRowValue() throws JSQLParserException {
203203
String statement = "INSERT INTO mytable (col1, col2) VALUES (a, b), (d, e)";
204204
assertSqlCanBeParsedAndDeparsed(statement);
205205

206-
ExpressionList<Column> multiExpressionList = new ExpressionList<>()
206+
ExpressionList<Expression> multiExpressionList = new ExpressionList<>()
207207
.addExpression(
208-
new ParenthesedExpressionList<Column>(new Column("a"), new Column("b")))
208+
new ParenthesedExpressionList<Expression>(new Column("a"), new Column("b")))
209209
.addExpression(
210-
new ParenthesedExpressionList<Column>(new Column("d"), new Column("e")));
210+
new ParenthesedExpressionList<Expression>(new Column("d"), new Column("e")));
211211

212212
Select select = new Values().withExpressions(multiExpressionList);
213213

0 commit comments

Comments
 (0)