feat: normalised backtick quotes

Signed-off-by: Andreas Reichel <[email protected]>

Author: manticore-projects

src/main/java/net/sf/jsqlparser/schema/Column.java

@@ -53,7 +53,8 @@ public Column(List<String> nameParts, List<String> delimiters) {
     }
 
     public Column(String columnName) {
-        this(null, columnName);
+        this();
+        setColumnName(columnName);
     }
 
     public ArrayConstructor getArrayConstructor() {
@@ -131,8 +132,56 @@ public String getUnquotedColumnName() {
         return MultiPartName.unquote(columnName);
     }
 
-    public void setColumnName(String string) {
-        columnName = string;
+    public void setColumnName(String name) {
+        // BigQuery seems to allow things like: `catalogName.schemaName.tableName` in only one pair
+        // of quotes
+        // however, some people believe that Dots in Names are a good idea, so provide a switch-off
+        boolean splitNamesOnDelimiter = System.getProperty("SPLIT_NAMES_ON_DELIMITER") == null ||
+                !List
+                        .of("0", "N", "n", "FALSE", "false", "OFF", "off")
+                        .contains(System.getProperty("SPLIT_NAMES_ON_DELIMITER"));
+
+        setName(name, splitNamesOnDelimiter);
+    }
+
+    public void setName(String name, boolean splitNamesOnDelimiter) {
+        if (MultiPartName.isQuoted(name) && name.contains(".") && splitNamesOnDelimiter) {
+            String[] parts = MultiPartName.unquote(name).split("\\.");
+            switch (parts.length) {
+                case 3:
+                    this.table = new Table("\"" + parts[0] + "\".\"" + parts[1] + "\"");
+                    this.columnName = "\"" + parts[2] + "\"";
+                    break;
+                case 2:
+                    this.table = new Table("\"" + parts[0] + "\"");
+                    this.columnName = "\"" + parts[1] + "\"";
+                    break;
+                case 1:
+                    this.columnName = "\"" + parts[0] + "\"";
+                    break;
+                default:
+                    throw new RuntimeException("Invalid column name: " + name);
+            }
+        } else if (name.contains(".") && splitNamesOnDelimiter) {
+            String[] parts = MultiPartName.unquote(name).split("\\.");
+            switch (parts.length) {
+                case 3:
+                    this.table = new Table(parts[0] + "." + parts[1]);
+                    this.columnName = parts[2];
+                    break;
+                case 2:
+                    this.table = new Table(parts[0]);
+                    this.columnName = parts[1];
+                    break;
+                case 1:
+                    this.columnName = parts[0];
+                    break;
+                default:
+                    throw new RuntimeException("Invalid column name: " + name);
+            }
+        } else {
+            this.columnName = name;
+        }
     }
 
     public String getTableDelimiter() {

src/main/java/net/sf/jsqlparser/schema/MultiPartName.java

@@ -29,29 +29,32 @@ static String unquote(String quotedIdentifier) {
     }
 
     static boolean isQuoted(String identifier) {
-        return identifier!=null && LEADING_TRAILING_QUOTES_PATTERN.matcher(identifier).find();
+        return identifier != null && LEADING_TRAILING_QUOTES_PATTERN.matcher(identifier).find();
     }
 
     String getFullyQualifiedName();
 
     String getUnquotedName();
 
+
     static String replaceBackticksWithDoubleQuotes(String input) {
         if (input == null || input.isEmpty()) {
             return input;
         }
 
         Matcher matcher = BACKTICK_PATTERN.matcher(input);
         StringBuilder sb = new StringBuilder();
+        int lastEnd = 0;
 
         while (matcher.find()) {
-            // Replace each backtick-quoted part with double-quoted equivalent
-            String content = matcher.group(1);
-            matcher.appendReplacement(sb, "\"" + Matcher.quoteReplacement(content) + "\"");
+            sb.append(input, lastEnd, matcher.start()); // text before match
+            sb.append('"').append(matcher.group(1)).append('"'); // replace with double quotes
+            lastEnd = matcher.end();
         }
-        matcher.appendTail(sb);
 
+        sb.append(input.substring(lastEnd)); // append remaining text
         return sb.toString();
     }
 
+
 }

src/main/java/net/sf/jsqlparser/schema/Table.java

@@ -302,6 +302,10 @@ public Table setTimeTravelStrAfterAlias(String timeTravelStrAfterAlias) {
         return this;
     }
 
+    public void setNameParts(List<String> nameParts) {
+        this.partItems = nameParts;
+    }
+
     private void setIndex(int idx, String value) {
         int size = partItems.size();
         for (int i = 0; i < idx - size + 1; i++) {

src/test/java/net/sf/jsqlparser/schema/MultiPartNameTest.java

@@ -0,0 +1,15 @@
+package net.sf.jsqlparser.schema;
+
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class MultiPartNameTest {
+
+    @Test
+    void replaceBackticksWithDoubleQuotes() {
+        Assertions.assertThat("\"starbake\".\"customers\"").isEqualToIgnoringCase(
+                MultiPartName.replaceBackticksWithDoubleQuotes("`starbake`.`customers`"));
+    }
+}

src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java

@@ -1798,10 +1798,14 @@ public void testCount3() throws JSQLParserException {
 
     @Test
     public void testMysqlQuote() throws JSQLParserException {
-        String statement = "SELECT `a.OWNERLASTNAME`, `OWNERFIRSTNAME` "
+        String sqlStr = "SELECT `a.OWNERLASTNAME`, `OWNERFIRSTNAME` "
                 + "FROM `ANTIQUEOWNERS` AS a, ANTIQUES AS b "
                 + "WHERE b.BUYERID = a.OWNERID AND b.ITEM = 'Chair'";
-        assertSqlCanBeParsedAndDeparsed(statement);
+
+        String expected =
+                "SELECT \"a\".\"OWNERLASTNAME\", `OWNERFIRSTNAME` FROM `ANTIQUEOWNERS` AS a, ANTIQUES AS b WHERE b.BUYERID = a.OWNERID AND b.ITEM = 'Chair'";
+
+        assertStatementCanBeDeparsedAs(CCJSqlParserUtil.parse(sqlStr), expected);
     }
 
     @Test