NPE in JSQLResolver in 5.4-SNAPSHOT

[stbischof]

java.lang.NullPointerException: Cannot invoke "java.util.Collection.toArray()" because "c" is null
	at java.base/java.util.ArrayList.addAll(ArrayList.java:752)
	at ai.starlake.transpiler.JSQLResolver.visit(JSQLResolver.java:256)
	at ai.starlake.transpiler.JSQLColumResolver.visit(JSQLColumResolver.java:507)
	at ai.starlake.transpiler.JSQLColumResolver.visit(JSQLColumResolver.java:66)
	at net.sf.jsqlparser.statement.select.PlainSelect.accept(PlainSelect.java:319)
	at ai.starlake.transpiler.JSQLResolver.resolve(JSQLResolver.java:463)
	at org.eclipse.daanse.sql.guard.jsqltranspiler.TranspilerSqlGuard.guard(TranspilerSqlGuard.java:90)
	at org.eclipse.daanse.sql.guard.jsqltranspiler.SqlGuardTest.testAdditionalColumn(SqlGuardTest.java:254)

we test

select *, 5 as testColumn from foo where foo.id  = 10

should be parsed as

SELECT sch.foo.id, sch.foo.name, 5 AS testColumn FROM sch.foo WHERE foo.id = 10

[davyboyhayes]

http://jsqlformatter.manticore-projects.com/jsqlformatter/demo.html?args=-c%20MoUQMiDCAqAEsCoBQ9WoDSwKywILFgBcBTAZ0IGMB7AGwFcBbAOyQDEAlAeQFlYAzKlSQB1ABIh2IfoIB0ASwAmsALywAjAAYkAbiA$$

The latest 5.4-SNAPSHOT appears to parse this.

Have you tried CCJSqlParserUtil.parse(sqlStr, AbstractJSqlParser::withUnsupportedStatements);?

[manticore-projects]

@stbischof:

Sorry for late response, this is actually the wrong repository and so it slipped my mind.

1. Unfortunately you do not provide schema information (but I have tried to figure the schema out from the information given)
2. your input query does not state the schema and so I assume that CURRENT_SCHEMA=sch

Based on those assumptions, the following test passes with lastest JSQLTranspiler:

  @Test
  void testIssue2291NPE() throws JSQLParserException {
    String sqlStr = "select *, 5 as testColumn from foo where foo.id  = 10";
    String expected="SELECT foo.id, foo.name, 5 AS testColumn FROM foo WHERE foo.id = 10";

    JdbcMetaData metaData = new JdbcMetaData("", "sch",
            new String[][]{
                    {"foo", "id", "name"}
            }
    );

    JSQLResolver resolver = new JSQLResolver(metaData);
    Set<JdbcColumn> resolved = resolver.resolve(sqlStr);
    Assertions.assertThat(resolved).hasSize(3);

    String rewritten = resolver.getResolvedStatementText(sqlStr);
    Assertions.assertThat(rewritten).isEqualToNormalizingUnicode(expected);
  }

Please see: https://github.com/starlake-ai/jsqltranspiler/blob/d6e76c27a3860aee56cb8ab857128a0362128853/src/test/java/ai/starlake/transpiler/JSQLResolverTest.java#L542

If this was not sufficient, then please provide a self-containing reproducer, especially including the schema/table information.
Thanks a lot and cheers!

[stbischof]

@manticore-projects here the debug video

Screencast.From.2025-08-14.11-41-05.webm

ends with the null here

JSqlParser/src/main/java/net/sf/jsqlparser/expression/ExpressionVisitorAdapter.java

Line 494 in 12489af

return null;

hope this helps a bit. for seperate testdata i will need some time