Skip to content

Commit a7ed769

Browse files
committed
upgrade zkclient to 0.10 fix log4j2 bug
1 parent 5ba01e2 commit a7ed769

File tree

15 files changed

+29
-16
lines changed

15 files changed

+29
-16
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,7 +605,7 @@ compile "skyeye:skyeye-client-log4j:1.0.0"
605605
使用自己打包的dubbox([dubbox](https://github.com/JThink/dubbox/tree/skyeye-trace-1.1.0)),在soa中间件dubbox中封装了rpc的跟踪
606606
607607
``` shell
608-
compile "com.101tec:zkclient:0.9.1-up"
608+
compile "com.101tec:zkclient:0.10"
609609
compile ("com.alibaba:dubbo:2.8.4-skyeye-trace-1.1.0") {
610610
exclude group: 'org.springframework', module: 'spring'
611611
}

skyeye-benchmark/dubbo-service/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ subprojects {
4040
dataVersion = '1.1.0'
4141
clientVersion = '1.1.0'
4242
zookeeperVerison = '3.4.6'
43-
zkClientVersion = '0.9.1-up'
43+
zkClientVersion = '0.10'
4444
}
4545

4646
[compileJava, compileTestJava]*.options*.encoding = 'UTF-8'

skyeye-benchmark/hi-log/hi-log-log4j2/src/main/java/com/jthink/skyeye/benchmark/hi/log/log4j2/launcher/Launcher.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import org.springframework.boot.builder.SpringApplicationBuilder;
88
import org.springframework.boot.logging.LoggingApplicationListener;
99
import org.springframework.context.ApplicationListener;
10-
import org.springframework.context.annotation.ComponentScan;
1110

1211
import java.util.Iterator;
1312
import java.util.Set;
@@ -27,7 +26,7 @@ public class Launcher {
2726
private static volatile boolean RUNNING = true;
2827
private static final Logger LOGGER = LoggerFactory.getLogger(Launcher.class);
2928

30-
public static void main(String[] args) {
29+
public static void main(String[] args) throws InterruptedException {
3130
SpringApplicationBuilder builder = new SpringApplicationBuilder(Launcher.class);
3231
Set<ApplicationListener<?>> listeners = builder.application().getListeners();
3332
for (Iterator<ApplicationListener<?>> it = listeners.iterator(); it.hasNext();) {
@@ -44,6 +43,7 @@ public static void main(String[] args) {
4443
String a = "哈哈";
4544
while (true) {
4645
LOGGER.info("i am test, {}", a);
46+
Thread.sleep(1000);
4747
}
4848
}
4949
}

skyeye-benchmark/hi-log/hi-log-log4j2/src/main/resources/log4j2.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,12 @@
3030
</Policies>
3131
</RollingFile>
3232

33-
3433
<!-- kafka appender -->
35-
<KafkaCustomize name="kafkaAppender" topic="app-log" zkServers="riot01.jthink.com:2181,riot02.jthink.com:2181,riot03.jthink.com:2181"
34+
<KafkaCustomize name="KafkaCustomize" topic="app-log" zkServers="riot01.jthink.com:2181,riot02.jthink.com:2181,riot03.jthink.com:2181"
3635
mail="qianjc@unionpaysmart.com" rpc="none" app="${APP_NAME}" host="${hostName}">
3736
<ThresholdFilter level="info" onMatch="ACCEPT" onMismatch="DENY"/>
3837
<PatternLayout pattern="%d{yyyy-MM-dd HH:mm:ss.SSS};${APP_NAME};${hostName};%t;%-5level;%logger{96};%line;%msg%n"/>
39-
<Property name="bootstrap.servers">riot01.jthink.com:9092,riot02.jthink.com:9092,riot03.jthink.com:9092</Property>
38+
<Property name="bootstrap.servers">riot01.jthink.com:909,riot02.jthink.com:909,riot03.jthink.com:909</Property>
4039
<Property name="acks">0</Property>
4140
<Property name="linger.ms">100</Property>
4241
<Property name="client.id">${APP_NAME}-${hostName}-log4j2</Property>
@@ -48,6 +47,7 @@
4847
<AppenderRef ref="Console"/>
4948
<AppenderRef ref="RollingInfoFile"/>
5049
<AppenderRef ref="RollingErrorFile"/>
50+
<AppenderRef ref="KafkaCustomize"/>
5151
</Root>
5252
</Loggers>
5353
</Configuration>

skyeye-client/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ compile "skyeye:skyeye-client-log4j:1.0.0"
7777
使用自己打包的dubbox([dubbox](https://github.com/JThink/dubbox/tree/skyeye-trace-1.0.0)),在soa中间件dubbox中封装了rpc的跟踪
7878

7979
``` shell
80-
compile "com.101tec:zkclient:0.9.1-up"
80+
compile "com.101tec:zkclient:0.10"
8181
compile ("com.alibaba:dubbo:2.8.4-skyeye-trace-1.0.0") {
8282
exclude group: 'org.springframework', module: 'spring'
8383
}

skyeye-client/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ subprojects {
5656
ext {
5757
kafkaVersion = '0.10.0.1'
5858
zookeeperVersion = '3.4.6'
59-
zkclientVersion = '0.9.1-up'
59+
zkclientVersion = '0.10'
6060
baseVersion = '1.1.0'
6161
traceVersion = '1.1.0'
6262
}

skyeye-client/skyeye-client-log4j2/build.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,8 @@ dependencies {
1515
compile project(':skyeye-client-core')
1616
compile "org.apache.logging.log4j:log4j-core:$log4j2Version"
1717
}
18+
19+
configurations {
20+
compile.exclude group: "log4j", module: "log4j"
21+
compile.exclude group: "org.slf4j", module: "slf4j-log4j12"
22+
}

skyeye-client/skyeye-client-log4j2/src/main/java/com/jthink/skyeye/client/log4j2/appender/KafkaAppender.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,14 @@ public void onCompletion(RecordMetadata recordMetadata, Exception e) {
121121
public void start() {
122122
super.start();
123123

124+
// 添加hook
125+
Runtime.getRuntime().addShutdownHook(new Thread() {
126+
@Override
127+
public void run() {
128+
KafkaAppender.this.manager.closeResources();
129+
}
130+
});
131+
124132
this.manager.startup();
125133
}
126134

skyeye-client/skyeye-client-log4j2/src/main/java/com/jthink/skyeye/client/log4j2/appender/KafkaManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public void run() {
107107
/**
108108
* 关闭zk和kafka
109109
*/
110-
private void closeResources() {
110+
public void closeResources() {
111111
if (LazySingletonProducer.isInstanced()) {
112112
LazySingletonProducer.getInstance(KafkaManager.this.config).close();
113113
}

skyeye-collector/skyeye-collector-metrics/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ apply plugin: 'application'
66

77
ext {
88
dataVersion = '1.1.0'
9-
zkclientVersion = '0.9.1-up'
9+
zkclientVersion = '0.10'
1010
}
1111

1212
dependencies {

0 commit comments

Comments
 (0)