Merge pull request ckan#9263 from ckan/9232-default-change-warning

include_users new False default warning text

Author: wardi

changes/9232.misc

@@ -0,0 +1,3 @@
+After CKAN 2.12 the include_users parameter to organization_show and group_show
+actions will default to False regardless of the ckan.auth.public_user_details
+configuration setting.

ckan/logic/action/get.py

@@ -1221,6 +1221,8 @@ def group_show(context: Context, data_dict: DataDict) -> ActionResult.GroupShow:
     :param include_users: include the group's users
          (optional, default: ``True`` if ``ckan.auth.public_user_details``
          is ``True`` otherwise ``False``)
+         NOTE: after CKAN 2.12 this parameter will default to ``False``
+         regardless of the ``ckan.auth.public_user_details`` setting
     :type include_users: bool
     :param include_groups: include the group's sub groups
          (optional, default: ``True``)
@@ -1254,6 +1256,8 @@ def organization_show(context: Context, data_dict: DataDict) -> ActionResult.Org
     :param include_users: include the organization's users
          (optional, default: ``True`` if ``ckan.auth.public_user_details``
          is ``True`` otherwise ``False``)
+         NOTE: after CKAN 2.12 this parameter will default to ``False``
+         regardless of the ``ckan.auth.public_user_details`` setting
     :type include_users: bool
     :param include_groups: include the organization's sub groups
          (optional, default: ``True``)

ckan/tests/logic/action/test_get.py

@@ -2059,7 +2059,7 @@ def test_autocomplete_limit(self):
         result = helpers.call_action("user_autocomplete", q="compl", limit=1)
         assert len(result) == 1
 
-    def test_autcomplete_email(self):
+    def test_autocomplete_email(self):
         user = factories.Sysadmin()
         context = {"user": user["name"]}
         factories.User(name="user1234", email="joe@doe.com")
@@ -2069,7 +2069,7 @@ def test_autcomplete_email(self):
         assert result[0]["name"] == "user1234"
 
         # test when user is not sysadmin
-        result = helpers.call_action("user_autocomplete", q="joe")
+        result = helpers.call_action("user_autocomplete", q="joe@doe.com")
         assert len(result) == 0