Feature/datatables view enhance#2
Open
wardi wants to merge 9 commits intoJVickery-TBS:feature/datatables-view-enhancefrom
Open
Feature/datatables view enhance#2wardi wants to merge 9 commits intoJVickery-TBS:feature/datatables-view-enhancefrom
wardi wants to merge 9 commits intoJVickery-TBS:feature/datatables-view-enhancefrom
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Author
|
I'm on the fence about including the results from Maybe I'll add an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my version of the histogram API. I'm returning the buckets and edges in the "fields" value instead of as a separate dict.
I haven't updated the frond-end to match, but you can see the expected values in the tests provided.
We'll need a helper function to turn edges and bucket array values into histogram bar heights and widths. With discrete values like ints or dates some bars will be different widths, and the heights need to be scaled by the relative widths for accuracy.doneOther future work:
redis cache for bucket calculations(use Faster datastore_search row counts (cache version) ckan/ckan#9260 instead), only cache when no filters applied, delete individual cache values on any change to the datastore table