Skip to content

Commit 1d58114

Browse files
yang-ruoxitschaume
andauthored
* Small fix for phonon component * Use disabled attribute directly in Button * Update pull-request.yml --------- Co-authored-by: Patrick Huck <[email protected]>
1 parent 4726297 commit 1d58114

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

crystal_toolkit/components/phonon.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,18 @@ def _get_data_list_dict(
364364
"Number of bands": f"{bs.nb_bands:,}",
365365
"Number of q-points": f"{bs.nb_qpoints:,}",
366366
# for NAC see https://phonopy.github.io/phonopy/formulation.html#non-analytical-term-correction
367-
"Has NAC (see phonopy docs)": bs.has_nac,
368-
"Has imaginary frequencies": bs.has_imaginary_freq(),
369-
"Has eigen-displacements": bs.has_eigendisplacements,
367+
Label(
368+
[
369+
"Has ",
370+
html.A(
371+
"NAC",
372+
href="https://phonopy.github.io/phonopy/formulation.html#non-analytical-term-correction",
373+
target="blank",
374+
),
375+
]
376+
): "Yes" if bs.has_nac else "No",
377+
"Has imaginary frequencies": "Yes" if bs.has_imaginary_freq() else "No",
378+
"Has eigen-displacements": "Yes" if bs.has_eigendisplacements else "No",
370379
"Min frequency": min_freq_report,
371380
"max frequency": f"{max(dos.frequencies):.2f} THz",
372381
}

crystal_toolkit/helpers/layouts.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ def __init__(
244244
rounded: bool = False,
245245
loading: bool = False,
246246
static: bool = False,
247-
disabled: bool = False,
248247
**kwargs,
249248
) -> None:
250249
"""The button is an essential element of any design. It's meant to look and behave as an interactive element of your page.
@@ -261,7 +260,6 @@ def __init__(
261260
_update_css_class(kwargs, "is-rounded", rounded)
262261
_update_css_class(kwargs, "is-loading", loading)
263262
_update_css_class(kwargs, "is-static", static)
264-
_update_css_class(kwargs, "is-disabled", disabled)
265263
super().__init__(*args, **kwargs)
266264

267265

0 commit comments

Comments
 (0)