First set fetcherWorker properties, then start the worker

Author: koppor

src/main/java/org/jabref/gui/EntryTypeViewModel.java

@@ -142,10 +142,10 @@ protected Optional<BibEntry> call() throws FetcherException {
     }
 
     public void runFetcherWorker() {
-        searchSuccesfulProperty.set(false);
-        searchingProperty().setValue(true);
-        taskExecutor.execute(fetcherWorker);
+        fetcherWorker.setOnRunning(event -> searchingProperty().setValue(true));
+
         fetcherWorker.setOnFailed(event -> {
+            searchSuccesfulProperty.set(false);
             Throwable exception = fetcherWorker.getException();
             String fetcherExceptionMessage = exception.getMessage();
             String fetcher = selectedItemProperty().getValue().getName();
@@ -159,7 +159,7 @@ public void runFetcherWorker() {
                 dialogService.showInformationDialogAndWait(Localization.lang("Failed to import by ID"), Localization.lang("Error message %0", fetcherExceptionMessage));
             }
 
-            LOGGER.error(String.format("Exception during fetching when using fetcher '%s' with entry id '%s'.", fetcher, searchId), exception);
+            LOGGER.error("Exception during fetching when using fetcher '{}' with entry id '{}'.", fetcher, searchId, exception);
 
             searchingProperty.set(false);
             fetcherWorker = new FetcherWorker();
@@ -204,10 +204,11 @@ public void runFetcherWorker() {
                     searchSuccesfulProperty.set(true);
                 }
             }
-            fetcherWorker = new FetcherWorker();
 
             focusAndSelectAllProperty.set(true);
-            searchingProperty().setValue(false);
+            searchingProperty().set(false);
+            fetcherWorker = new FetcherWorker();
         });
+        taskExecutor.execute(fetcherWorker);
     }
 }