Add options to choose groups during import (#13977)

* Add options to choose groups during import

* Remove unused import

Author: paudelritij

CHANGELOG.md

@@ -41,6 +41,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We added more supported formats of CAYW endpoint of HTTP server. [#13578](https://github.com/JabRef/jabref/issues/13578)
 - We added chronological navigation for entries in each library. [#6352](https://github.com/JabRef/jabref/issues/6352)
 - We added support for using Medline/Pubmed fetcher with an API key. [#11296](https://github.com/JabRef/jabref/issues/11296#issuecomment-3289005011)
+- We added an option to choose the group during import of the entry(s). [#9191](https://github.com/JabRef/jabref/issues/9191)
 
 ### Changed
 

jabgui/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java

@@ -1,5 +1,7 @@
 package org.jabref.gui.importer;
 
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Optional;
 
 import javax.swing.undo.UndoManager;
@@ -49,6 +51,8 @@
 import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.BibEntryTypesManager;
+import org.jabref.model.groups.AllEntriesGroup;
+import org.jabref.model.groups.GroupTreeNode;
 import org.jabref.model.util.FileUpdateMonitor;
 
 import com.airhacks.afterburner.views.ViewLoader;
@@ -62,6 +66,7 @@ public class ImportEntriesDialog extends BaseDialog<Boolean> {
     @FXML private Label pageNumberLabel;
     @FXML private CheckListView<BibEntry> entriesListView;
     @FXML private ComboBox<BibDatabaseContext> libraryListView;
+    @FXML private ComboBox<GroupTreeNode> groupListView;
     @FXML private ButtonType importButton;
     @FXML private Label totalItems;
     @FXML private Label selectedItems;
@@ -146,6 +151,7 @@ private void initialize() {
         });
 
         libraryListView.setEditable(false);
+        groupListView.setEditable(false);
         libraryListView.getItems().addAll(stateManager.getOpenDatabases());
         new ViewModelListCellFactory<BibDatabaseContext>()
                 .withText(database -> {
@@ -162,6 +168,7 @@ private void initialize() {
                 .install(libraryListView);
         viewModel.selectedDbProperty().bind(libraryListView.getSelectionModel().selectedItemProperty());
         stateManager.getActiveDatabase().ifPresent(database1 -> libraryListView.getSelectionModel().select(database1));
+        setupGroupListView();
 
         PseudoClass entrySelected = PseudoClass.getPseudoClass("selected");
         new ViewModelListCellFactory<BibEntry>()
@@ -220,6 +227,48 @@ private void initialize() {
         }
     }
 
+    private void setupGroupListView() {
+        groupListView.setVisibleRowCount(5);
+        updateGroupList();
+        libraryListView.getSelectionModel().selectedItemProperty()
+                       .addListener((_, _, _) -> {
+                           updateGroupList();
+                       });
+
+        new ViewModelListCellFactory<GroupTreeNode>()
+                .withText(group -> group != null ? group.getName() : Localization.lang("No group"))
+                .install(groupListView);
+    }
+
+    private void updateGroupList() {
+        groupListView.getItems().clear();
+
+        BibDatabaseContext selectedDb = libraryListView.getSelectionModel().getSelectedItem();
+        if (selectedDb.getMetaData().getGroups().isPresent()) {
+            GroupTreeNode rootGroup = selectedDb.getMetaData().getGroups().get();
+            groupListView.getItems().add(rootGroup);
+
+            List<GroupTreeNode> allGroups = new ArrayList<>();
+            collectGroupsFromTree(rootGroup, allGroups);
+            allGroups.sort((g1, g2) -> g1.getName().compareToIgnoreCase(g2.getName()));
+
+            groupListView.getItems().addAll(allGroups);
+            groupListView.getSelectionModel().select(stateManager.getSelectedGroups(selectedDb).getFirst());
+        } else {
+            // No groups defined -> only "All entries"
+            GroupTreeNode noGroup = new GroupTreeNode(new AllEntriesGroup(Localization.lang("All entries")));
+            groupListView.getItems().add(noGroup);
+            groupListView.getSelectionModel().select(noGroup);
+        }
+    }
+
+    private void collectGroupsFromTree(GroupTreeNode parent, List<GroupTreeNode> groupList) {
+        for (GroupTreeNode child : parent.getChildren()) {
+            groupList.add(child);
+            collectGroupsFromTree(child, groupList);
+        }
+    }
+
     private void initializeDialog() {
         ViewLoader.view(this)
                   .load()
@@ -236,7 +285,15 @@ private void initializeDialog() {
 
         setResultConverter(button -> {
             if (button == importButton) {
-                viewModel.importEntries(viewModel.getCheckedEntries().stream().toList(), downloadLinkedOnlineFiles.isSelected());
+                if (groupListView.getItems().size() > 1) {
+                    // 1 is the "All entries" group, so if more than 1, we have groups defined
+                    GroupTreeNode prevSelectedGroup = stateManager.getSelectedGroups(stateManager.getActiveDatabase().orElse(null)).getFirst();
+                    stateManager.setSelectedGroups(libraryListView.getSelectionModel().getSelectedItem(), List.of(groupListView.getSelectionModel().getSelectedItem()));
+                    viewModel.importEntries(viewModel.getCheckedEntries().stream().toList(), downloadLinkedOnlineFiles.isSelected());
+                    stateManager.setSelectedGroups(stateManager.getActiveDatabase().orElse(null), List.of(prevSelectedGroup));
+                } else {
+                    viewModel.importEntries(viewModel.getCheckedEntries().stream().toList(), downloadLinkedOnlineFiles.isSelected());
+                }
             } else {
                 dialogService.notify(Localization.lang("Import canceled"));
             }

jabgui/src/main/resources/org/jabref/gui/importer/ImportEntriesDialog.fxml

@@ -44,6 +44,7 @@
                     <HBox spacing="4" alignment="CENTER_LEFT">
                         <Label text="%Library to import into"/>
                         <ComboBox fx:id="libraryListView" layoutX="16.0" layoutY="52.0"/>
+                        <ComboBox fx:id="groupListView" layoutX="16.0" layoutY="52.0"/>
                     </HBox>
                 </VBox>
                 <HBox HBox.hgrow="ALWAYS"/>

jablib/src/main/resources/l10n/JabRef_en.properties

@@ -682,6 +682,7 @@ Possible\ duplicate\ entries=Possible duplicate entries
 Possible\ duplicate\ of\ existing\ entry.\ Will\ be\ resolved\ on\ import.=Possible duplicate of existing entry. Will be resolved on import.
 
 Import\ canceled=Import canceled
+No\ group=No group
 An\ error\ occurred\ while\ fetching\ entries\ from\ %0\:\ %1=An error occurred while fetching entries from %0: %1
 Error\ fetching\ entries=Error fetching entries
 %0\ of\ %1=%0 of %1