Fix string util package and methods (#14158)

* Move StringUtil to package org.jabref.logic.util.strings.

* solve check style problem

* let model layer uses methods in logic layer

* accidently optimized by the IDEA function ”optimized import“

* Move org.jabref.logic.database.DuplicateCheck#correlateByWords to org.jabref.logic.util.strings.StringSimilarity. Adapt tests and code accordingly.

Author: YuKiAndrew

jabgui/src/main/java/org/jabref/cli/ArgumentProcessor.java

@@ -9,7 +9,7 @@
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.shared.prefs.SharedDatabasePreferences;
 import org.jabref.logic.util.BuildInfo;
-import org.jabref.model.strings.StringUtil;
+import org.jabref.logic.util.strings.StringUtil;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;

jabgui/src/main/java/org/jabref/gui/JabRefGUI.java

@@ -52,8 +52,8 @@
 import org.jabref.logic.util.FallbackExceptionHandler;
 import org.jabref.logic.util.HeadlessExecutorService;
 import org.jabref.logic.util.TaskExecutor;
+import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.entry.BibEntryTypesManager;
-import org.jabref.model.strings.StringUtil;
 import org.jabref.model.util.FileUpdateMonitor;
 
 import com.airhacks.afterburner.injection.Injector;

jabgui/src/main/java/org/jabref/gui/actions/ActionFactory.java

@@ -14,7 +14,7 @@
 import javafx.scene.control.Tooltip;
 
 import org.jabref.gui.keyboard.KeyBindingRepository;
-import org.jabref.model.strings.StringUtil;
+import org.jabref.logic.util.strings.StringUtil;
 
 import com.airhacks.afterburner.injection.Injector;
 import com.sun.javafx.scene.control.ContextMenuContent;

jabgui/src/main/java/org/jabref/gui/autocompleter/BibEntrySuggestionProvider.java

@@ -4,10 +4,10 @@
 import java.util.stream.Stream;
 
 import org.jabref.logic.bibtex.comparator.EntryComparator;
+import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.database.BibDatabase;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.InternalField;
-import org.jabref.model.strings.StringUtil;
 
 import com.google.common.base.Equivalence;
 import org.controlsfx.control.textfield.AutoCompletionBinding;

jabgui/src/main/java/org/jabref/gui/autocompleter/PersonNameSuggestionProvider.java

@@ -6,12 +6,12 @@
 import java.util.Map;
 import java.util.stream.Stream;
 
+import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.database.BibDatabase;
 import org.jabref.model.entry.Author;
 import org.jabref.model.entry.AuthorList;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.Field;
-import org.jabref.model.strings.StringUtil;
 
 import com.google.common.base.Equivalence;
 import org.controlsfx.control.textfield.AutoCompletionBinding;

jabgui/src/main/java/org/jabref/gui/autocompleter/StringSuggestionProvider.java

@@ -3,7 +3,7 @@
 import java.util.Comparator;
 import java.util.stream.Stream;
 
-import org.jabref.model.strings.StringUtil;
+import org.jabref.logic.util.strings.StringUtil;
 
 import com.google.common.base.Equivalence;
 import org.controlsfx.control.textfield.AutoCompletionBinding;

jabgui/src/main/java/org/jabref/gui/collab/entrychange/PreviewWithSourceTab.java

@@ -14,11 +14,11 @@
 import org.jabref.logic.exporter.BibWriter;
 import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.os.OS;
+import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.database.BibDatabaseMode;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.BibEntryTypesManager;
-import org.jabref.model.strings.StringUtil;
 
 import org.fxmisc.richtext.CodeArea;
 import org.slf4j.Logger;

jabgui/src/main/java/org/jabref/gui/collab/preamblechange/PreambleChangeDetailsView.java

@@ -6,7 +6,7 @@
 import org.jabref.gui.collab.DatabaseChangeDetailsView;
 import org.jabref.logic.bibtex.comparator.PreambleDiff;
 import org.jabref.logic.l10n.Localization;
-import org.jabref.model.strings.StringUtil;
+import org.jabref.logic.util.strings.StringUtil;
 
 public final class PreambleChangeDetailsView extends DatabaseChangeDetailsView {
 

jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/MoveFieldValueAction.java

@@ -5,9 +5,9 @@
 import org.jabref.gui.actions.SimpleCommand;
 import org.jabref.gui.undo.NamedCompoundEdit;
 import org.jabref.gui.undo.UndoableFieldChange;
+import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.Field;
-import org.jabref.model.strings.StringUtil;
 
 public class MoveFieldValueAction extends SimpleCommand {
     private final Field fromField;

jabgui/src/main/java/org/jabref/gui/edit/automaticfiededitor/copyormovecontent/CopyOrMoveFieldContentTabViewModel.java

@@ -15,11 +15,11 @@
 import org.jabref.gui.edit.automaticfiededitor.MoveFieldValueAction;
 import org.jabref.gui.undo.NamedCompoundEdit;
 import org.jabref.gui.undo.UndoableFieldChange;
+import org.jabref.logic.util.strings.StringUtil;
 import org.jabref.model.database.BibDatabase;
 import org.jabref.model.entry.BibEntry;
 import org.jabref.model.entry.field.Field;
 import org.jabref.model.entry.field.StandardField;
-import org.jabref.model.strings.StringUtil;
 
 import de.saxsys.mvvmfx.utils.validation.FunctionBasedValidator;
 import de.saxsys.mvvmfx.utils.validation.ValidationMessage;