test: ensure search history is shared and ordered correctly across database contexts (#13119)

* test: add unit tests for StateManager's search history behavior

* test: add unit test for search history across databases

Co-authored-by: Lydia Yan <[email protected]>
Co-authored-by: Yo Asaaa <[email protected]>
Co-authored-by: Brandon Lau <[email protected]>

---------

Co-authored-by: Lydia Yan <[email protected]>
Co-authored-by: Yo Asaaa <[email protected]>
Co-authored-by: Brandon Lau <[email protected]>

Author: 4 people

jabgui/src/test/java/org/jabref/gui/search/GetLastSearchHistoryTest.java

@@ -5,6 +5,7 @@
 import javafx.stage.Stage;
 
 import org.jabref.gui.StateManager;
+import org.jabref.model.database.BibDatabaseContext;
 
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -15,6 +16,10 @@
 
 @ExtendWith(ApplicationExtension.class)
 class GetLastSearchHistoryTest {
+    private final StateManager stateManager = new StateManager();
+    private final BibDatabaseContext dbContext1 = new BibDatabaseContext();
+    private final BibDatabaseContext dbContext2 = new BibDatabaseContext();
+
     @Start
     void onStart(Stage stage) {
         // Needed to init JavaFX thread
@@ -23,7 +28,7 @@ void onStart(Stage stage) {
 
     @Test
     void getLastSearchHistory() {
-        StateManager stateManager = new StateManager();
+        stateManager.clearSearchHistory();
         stateManager.addSearchHistory("test1");
         stateManager.addSearchHistory("test2");
         stateManager.addSearchHistory("test3");
@@ -35,7 +40,7 @@ void getLastSearchHistory() {
 
     @Test
     void duplicateSearchHistory() {
-        StateManager stateManager = new StateManager();
+        stateManager.clearSearchHistory();
         stateManager.addSearchHistory("test1");
         stateManager.addSearchHistory("test2");
         stateManager.addSearchHistory("test3");
@@ -48,7 +53,7 @@ void duplicateSearchHistory() {
 
     @Test
     void clearSearchHistory() {
-        StateManager stateManager = new StateManager();
+        stateManager.clearSearchHistory();
         stateManager.addSearchHistory("test1");
         stateManager.addSearchHistory("test2");
         stateManager.addSearchHistory("test3");
@@ -60,4 +65,20 @@ void clearSearchHistory() {
         expected = List.of();
         assertEquals(expected, lastSearchHistory);
     }
+
+    @Test
+    void searchHistory_isSharedAcrossMultipleDatabasesAndMaintainsCorrectOrder() {
+        stateManager.clearSearchHistory();
+        stateManager.setActiveDatabase(dbContext1);
+        stateManager.addSearchHistory("queryA");
+
+        stateManager.setActiveDatabase(dbContext2);
+        stateManager.addSearchHistory("queryB");
+
+        stateManager.setActiveDatabase(dbContext1);
+        stateManager.addSearchHistory("queryC");
+
+        List<String> expected = List.of("queryA", "queryB", "queryC");
+        assertEquals(expected, stateManager.getWholeSearchHistory());
+    }
 }