Endnote XML Exporter: Move factory initialization to constructor (#13321)

* Move factory initialization to constructor, rearrange as per Checkstyle, use javadoc

Signed-off-by: subhramit <[email protected]>

* Use int

Signed-off-by: subhramit <[email protected]>

---------

Signed-off-by: subhramit <[email protected]>

Author: subhramit

jablib/src/main/java/org/jabref/logic/exporter/EndnoteXmlExporter.java

@@ -39,11 +39,6 @@
 
 public class EndnoteXmlExporter extends Exporter {
 
-    private static final DocumentBuilderFactory DOCUMENT_BUILDER_FACTORY = DocumentBuilderFactory.newInstance();
-
-    private record EndNoteType(String name, Integer number) {
-    }
-
     private static final Map<EntryType, EndNoteType> ENTRY_TYPE_MAPPING = new HashMap<>();
 
     static {
@@ -64,8 +59,10 @@ private record EndNoteType(String name, Integer number) {
         ENTRY_TYPE_MAPPING.put(StandardEntryType.Misc, new EndNoteType("Generic", 15));
     }
 
-    // Contains the mapping of all fields not explicitly handled by mapX methods
-    // We need a fixed order here, so we use a SequencedMap
+    /**
+     * Contains the mapping of all fields not explicitly handled by mapX methods.
+     * We need a fixed order here, so we use a SequencedMap
+     */
     private static final SequencedMap<Field, String> STANDARD_FIELD_MAPPING = new LinkedHashMap<>();
 
     static {
@@ -95,11 +92,17 @@ private record EndNoteType(String name, Integer number) {
 
     private static final EndNoteType DEFAULT_TYPE = new EndNoteType("Generic", 15);
 
+    private final DocumentBuilderFactory documentBuilderFactory;
+
+    private record EndNoteType(String name, int number) {
+    }
+
     private final BibEntryPreferences bibEntryPreferences;
 
     public EndnoteXmlExporter(BibEntryPreferences bibEntryPreferences) {
         super("endnote", "EndNote XML", StandardFileType.XML);
         this.bibEntryPreferences = bibEntryPreferences;
+        this.documentBuilderFactory = DocumentBuilderFactory.newInstance();
     }
 
     @Override
@@ -112,7 +115,7 @@ public void export(BibDatabaseContext databaseContext, Path file, List<BibEntry>
             return;
         }
 
-        DocumentBuilder dBuilder = DOCUMENT_BUILDER_FACTORY.newDocumentBuilder();
+        DocumentBuilder dBuilder = documentBuilderFactory.newDocumentBuilder();
         Document document = dBuilder.newDocument();
 
         Element rootElement = document.createElement("xml");
@@ -187,7 +190,7 @@ private static void mapJournalTitle(BibEntry entry, Document document, Element r
     }
 
     private void mapKeywords(BibDatabase bibDatabase, BibEntry entry, Document document, Element recordElement) {
-        entry.getFieldOrAlias(StandardField.KEYWORDS).ifPresent(keywords -> {
+        entry.getFieldOrAlias(StandardField.KEYWORDS).ifPresent(_ -> {
             Element keywordsElement = document.createElement("keywords");
             entry.getResolvedKeywords(bibEntryPreferences.getKeywordSeparator(), bibDatabase).forEach(keyword -> {
                 Element keywordElement = document.createElement("keyword");
@@ -258,7 +261,7 @@ private static void mapEntryType(BibEntry entry, Document document, Element reco
         EndNoteType endNoteType = ENTRY_TYPE_MAPPING.getOrDefault(entryType, DEFAULT_TYPE);
         Element refTypeElement = document.createElement("ref-type");
         refTypeElement.setAttribute("name", endNoteType.name());
-        refTypeElement.setTextContent(endNoteType.number().toString());
+        refTypeElement.setTextContent(String.valueOf(endNoteType.number()));
         recordElement.appendChild(refTypeElement);
     }