Add test for title format (#13507)

Co-authored-by: Subhramit Basu <[email protected]>

Author: koppor

.github/ghprcomment.yml

@@ -141,6 +141,12 @@
 
 # PR text
 
+- jobName: 'PR title must not start with "Fix for issue <number>"'
+  always: true
+  message: >
+    The title of the pull request must not start with "Fix for issue xyz".
+    Please use a concise one-line summary that explains what the fix or change actually does.
+    Example of a good title: "Prevent crash when importing malformed BibTeX entries".
 - jobName: 'Mandatory Checks present'
   always: true
   message: >

.github/workflows/tests-fetchers.yml renamed to .github/workflows/tests-code-fetchers.yml

@@ -1,4 +1,4 @@
-name: Tests
+name: Source Code Tests
 
 on:
   push:
@@ -25,6 +25,16 @@ permissions:
   pull-requests: write
 
 jobs:
+  upload-pr-number:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Create pr_number.txt
+        run: echo "${{ github.event.number }}" > pr_number.txt
+      - uses: actions/upload-artifact@v4
+        with:
+          name: pr_number
+          path: pr_number.txt
+
   checkstyle:
     name: Checkstyle
     runs-on: ubuntu-latest
@@ -441,204 +451,3 @@ jobs:
         with:
           show-progress: 'false'
       - uses: gradle/actions/wrapper-validation@v4
-
-  mandatory-checks-section-exists:
-    if: >
-      github.event_name == 'pull_request' && !(
-        (github.actor == 'dependabot[bot]') ||
-        (
-          startsWith(github.event.pull_request.title, '[Bot] ') ||
-          startsWith(github.event.pull_request.title, 'Bump ') ||
-          startsWith(github.event.pull_request.title, 'New Crowdin updates') ||
-          startsWith(github.event.pull_request.title, 'Update Gradle Wrapper from')
-        )
-      )
-    name: Mandatory Checks present
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout source
-        uses: actions/checkout@v4
-        with:
-          submodules: 'false'
-          show-progress: 'false'
-
-      - name: Check for existence of Mandatory Checks section
-        id: check_mandatory_section
-        run: |
-          set -e
-
-          BODY=$(gh pr view "${{ github.event.number }}" --json body --template '{{.body}}')
-
-          if echo "$BODY" | grep -q "### Mandatory checks"; then
-            echo "✅ '### Mandatory checks' section found."
-          else
-            echo "❌ '### Mandatory checks' section is missing!"
-            exit 1
-          fi
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-  checklist-checked:
-    if: >
-      (github.repository_owner != 'JabRef') &&
-      (github.event_name == 'pull_request') && !(
-        (github.actor == 'dependabot[bot]') ||
-        (
-          startsWith(github.event.pull_request.title, '[Bot] ') ||
-          startsWith(github.event.pull_request.title, 'Bump ') ||
-          startsWith(github.event.pull_request.title, 'New Crowdin updates') ||
-          startsWith(github.event.pull_request.title, 'Update Gradle Wrapper from')
-        )
-      )
-    name: PR checklist OK
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout source
-        uses: actions/checkout@v4
-        with:
-          submodules: 'false'
-          show-progress: 'false'
-      - name: Check for PR checklist
-        id: check_changelog_modification
-        run: |
-          set -e
-
-          BODY=$(gh pr view "${{ github.event.number }}" --json body --template '{{.body}}' | grep -A5000 '### Mandatory checks')
-          echo "Found body: $BODY"
-
-          # Ensure the section exists
-          if ! printf '%s\n' "$BODY" | grep -q "### Mandatory checks"; then
-              echo "❌ '### Mandatory checks' section is missing!"
-              exit 1
-          fi
-
-          BOXES=$(printf '%s\n' "$BODY" | grep "^- \[")
-          echo "Found boxes: $BOXES"
-
-          while IFS= read -r line; do
-              if ! printf '%s\n' "$line" | grep -Eq "^- \[(x|/| )\] "; then
-                  echo "❌ Found improperly formatted checkbox: '$line'"
-                  exit 1
-              fi
-          done <<< "$BOXES"
-
-          LINE_COUNT=$(echo "$BOXES" | wc -l)
-
-          if [ "$LINE_COUNT" -ne 7 ]; then
-            echo "❌ Found $LINE_COUNT lines instead of 7 required lines"
-            exit 1
-          fi
-
-          echo "✅ All checkboxes are present and in the correct format."
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-
-  # This ensures that no git merge conflict markers (<<<, ...) are contained
-  merge_conflict_job:
-    name: Find merge conflicts
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          show-progress: 'false'
-      - name: Merge Conflict finder
-        uses: olivernybroe/[email protected]
-
-  no-force-push:
-    if: github.event_name == 'pull_request'
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-      - name: Check force push
-        id: force_push_check
-        run: |
-          if [[ -z "${{ github.event.before }}" ]]; then
-            echo "✅ New PR created."
-            exit 0
-          fi
-          if git cat-file -e ${{ github.event.before }} 2>/dev/null; then
-            echo "✅ Regular push detected."
-            exit 0
-          else
-            echo "❌ Force push detected"
-            exit 1
-          fi
-
-  unmodified_submodules:
-    name: Submodules not modified
-    if: (github.actor != 'dependabot[bot]' && github.event_name == 'pull_request')
-    runs-on: ubuntu-latest
-    steps:
-      # No checkout -> the action uses GitHub's API (which is more reliable for submodule changes due to our submodule settings)
-      - name: Get all submodule changes
-        id: changes
-        uses: tj-actions/changed-files@v46
-        with:
-          files: |
-            jablib/src/main/abbrv.jabref.org
-            jablib/src/main/resources/csl-styles
-            jablib/src/main/resources/csl-locales
-      - name: Submodules modified
-        if: steps.changes.outputs.any_changed == 'true'
-        run: |
-          echo "❌ Submodule modifications detected"
-          exit 1
-
-  other_than_main:
-    if: github.event_name == 'pull_request'
-    name: Source branch is other than "main"
-    runs-on: ubuntu-latest
-    steps:
-      - if: github.head_ref == 'main'
-        uses: actions/github-script@v7
-        with:
-          script: |
-              core.setFailed('Pull requests should come from a branch other than "main"\n\n👉 Please read [the CONTRIBUTING guide](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md#contributing) carefully again. 👈')
-
-  upload-pr-number:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Create pr_number.txt
-        run: echo "${{ github.event.number }}" > pr_number.txt
-      - uses: actions/upload-artifact@v4
-        with:
-          name: pr_number
-          path: pr_number.txt
-
-  changelog_modified:
-    name: CHANGELOG.md needs to be modified
-    if: github.actor != 'dependabot[bot]' && github.event_name == 'pull_request'
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-      - name: Check PR body for changelog note
-        id: changelog_check
-        run: |
-          BODY=$(gh pr view "${{ github.event.number }}" --json body --template '{{.body}}')
-          echo "Body: $BODY"
-
-          if echo "$BODY" | grep -q '\- \[x\] Change in `CHANGELOG.md`'; then
-            echo "found"
-            echo "found=yes" >> $GITHUB_OUTPUT
-          else
-            echo "not found"
-            echo "found=no" >> $GITHUB_OUTPUT
-          fi
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      - name: Check for CHANGELOG.md modifications
-        id: check_changelog_modification
-        if: steps.changelog_check.outputs.found == 'yes'
-        run: |
-          git fetch origin ${{ github.base_ref }}
-          if git diff --name-only origin/${{ github.base_ref }}...HEAD | grep -q '^CHANGELOG\.md$'; then
-            echo "✅ CHANGELOG.md was modified"
-          else
-            echo "❌ CHANGELOG.md was NOT modified"
-            exit 1
-          fi