Skip to content

Commit 796b419

Browse files
ankamdekoppor
andauthored
Issue 13619 Make Citation relations text more clear. (#13620)
* Issue 13619 Make Citation relations text more clear. * Add missing CHANGELOG.md entry. * Improve javadoc. * Addressing PR comments * Addressing PR comments. * Update jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java * Fix language file --------- Co-authored-by: Oliver Kopp <[email protected]>
1 parent 0c1bf9c commit 796b419

File tree

3 files changed

+17
-9
lines changed

3 files changed

+17
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
2626

2727
### Changed
2828

29+
- We changed Citation Relations tab and gave tab panes more descriptive titles and tooltips. [#13619](https://github.com/JabRef/jabref/issues/13619)
2930
- We changed the name from Open AI Provider to Open AI (or API compatible). [#13585](https://github.com/JabRef/jabref/issues/13585)
3031
- We improved the citations relations caching by implementing an offline storage. [#11189](https://github.com/JabRef/jabref/issues/11189)
3132
- We added a tooltip to keywords that resemble Math Subject Classification (MSC) codes. [#12944](https://github.com/JabRef/jabref/issues/12944)

jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -149,11 +149,14 @@ private SplitPane getPaneAndStartSearch(BibEntry entry) {
149149
AnchorPane citedByHBox = new AnchorPane();
150150
citedByHBox.setPrefHeight(40);
151151

152-
// Create Heading Lab
153-
Label citingLabel = new Label(Localization.lang("Cites"));
154-
styleLabel(citingLabel);
155-
Label citedByLabel = new Label(Localization.lang("Cited By"));
156-
styleLabel(citedByLabel);
152+
// Create Headings
153+
// See ADR-0047
154+
String citationKey = entry.getCitationKey().orElse("this entry");
155+
156+
Label citingLabel = new Label(Localization.lang("References cited in %0", citationKey));
157+
styleLabel(citingLabel, Localization.lang("Also called \"backward citations\""));
158+
Label citedByLabel = new Label(Localization.lang("References that cite %0", citationKey));
159+
styleLabel(citedByLabel, Localization.lang("Also called \"forward citations\""));
157160

158161
// Create ListViews
159162
CheckListView<CitationRelationItem> citingListView = new CheckListView<>();
@@ -372,11 +375,13 @@ private void showEntrySourceDialog(BibEntry entry) {
372375
/**
373376
* Method to style heading labels
374377
*
375-
* @param label label to style
378+
* @param label label to style
379+
* @param tooltipText tooltip text
376380
*/
377-
private void styleLabel(Label label) {
381+
private void styleLabel(Label label, String tooltipText) {
378382
label.setStyle("-fx-padding: 5px");
379383
label.setAlignment(Pos.CENTER);
384+
label.setTooltip(new Tooltip(tooltipText));
380385
AnchorPane.setTopAnchor(label, 0.0);
381386
AnchorPane.setLeftAnchor(label, 0.0);
382387
AnchorPane.setBottomAnchor(label, 0.0);

jablib/src/main/resources/l10n/JabRef_en.properties

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2813,13 +2813,15 @@ The\ selected\ entry\ doesn't\ have\ a\ DOI\ linked\ to\ it.=The selected entry
28132813
Look\ up\ a\ DOI\ and\ try\ again.=Look up a DOI and try again.
28142814
Looking\ up\ DOI...=Looking up DOI...
28152815
No\ DOI\ found.=No DOI found.
2816-
Cited\ By=Cited By
2817-
Cites=Cites
2816+
References\ that\ cite\ %0=References that cite %0
2817+
References\ cited\ in\ %0=References cited in %0
28182818
No\ articles\ found=No articles found
28192819
Restart\ search=Restart search
28202820
Cancel\ search=Cancel search
28212821
Select\ entry=Select entry
28222822
Search\ aborted.=Search aborted.
2823+
Also\ called\ "backward\ citations"=Also called "backward citations"
2824+
Also\ called\ "forward\ citations"=Also called "forward citations"
28232825
28242826
Help\ on\ external\ applications=Help on external applications
28252827
Identifier-based\ Web\ Search=Identifier-based Web Search

0 commit comments

Comments
 (0)