Merge remote-tracking branch 'upstream/jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b' into jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b

* upstream/jetbrains-junie-issue-13623-run-c23b1a88-5c29-46a2-a007-701edd344b9b:
  Streamline code for getTabTitle() (#13781)
  Add missing variables
  Reformat BibTex in Show BibTex Source (#13761)
  Auto publish before JBang tests (#13779)
  Hotfix: calling of publish.yml
  Support BibLaTeX datamodel validations (#13693)
  Auto add and remove of "status: changes-required" label (#13778)
  New Crowdin updates (#13777)
  Restore local-only Git behavior for SLR to fix repository initialization error (#13775)
  Use vanilla hashset (#13771)
  Fix Springer Fetcher names (#13770)
  Fix condition
  Publish SNAPSHOT on jablib change (#13774)
  Adapt as per new set of checks (#13772)
  Bump jablib/src/main/resources/csl-styles from `1194364` to `17cfa60` (#13750)
  Fix path (#13769)
  Mode aware consistency check (#13584)
  Refine JBang check (#13765)
  Add Language Server to the UI and add the integrity/consistency check (#13697)
  Fix/remove comment code (#13763)

Author: Siedlerchr

.github/workflows/on-pr-changes-requested.yml

@@ -0,0 +1,18 @@
+name: Adapt PR status labels
+
+on:
+  pull_request_review:
+    types: [submitted]
+
+jobs:
+  label-changes-required:
+    if: github.event.review.state == 'changes_requested'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Adapt labels
+        run: |
+          gh issue --repo ${{ github.repository }} edit ${{ github.event.pull_request.number }} --remove-label "status: ready-for-review"
+          gh issue --repo ${{ github.repository }} edit ${{ github.event.pull_request.number }} --remove-label "status: awaiting-second-review"
+          gh issue --repo ${{ github.repository }} edit ${{ github.event.pull_request.number }} --add-label "status: changes-required"
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/on-pr-opened-updated.yml

@@ -160,6 +160,12 @@ jobs:
           echo "✅ No merge conflicts"
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+  remove_label:
+    if: github.repository == 'JabRef/jabref'
+    name: Remove label "status: changes-required"
+    runs-on: ubuntu-latest
+    steps:
+      - run: gh issue --repo ${{ github.repository }} edit ${{ github.event.pull_request.number }} --remove-label "status: changes-required"
   upload-pr-number:
     if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest

.github/workflows/publish.yml

@@ -1,17 +1,25 @@
 name: Publish to maven central
 
 on:
-  pull_request:
-    paths:
-     - .github/workflows/publish.yml
+  # On releases
   push:
-    paths:
-     - .github/workflows/publish.yml
     tags:
-      - '*'
-  schedule:
-    # run on each Monday
-    - cron: '2 3 * * 1'
+      - '**'
+
+  # Called by the JBang testing jobs to ensure that SNAPSHOT is uptodate
+  workflow_call:
+    secrets:
+      KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64:
+        required: true
+      KOPPOR_SIGNING_KEYID:
+        required: true
+      KOPPOR_SIGNING_PASSWORD:
+        required: true
+      KOPPOR_MAVENCENTRALUSERNAME:
+        required: true
+      KOPPOR_MAVENCENTRALPASSWORD:
+        required: true
+
   workflow_dispatch:
     inputs:
       tagbuild:
@@ -20,6 +28,11 @@ on:
         default: false
         type: boolean
 
+  # Additional run in addition to the other events, because some resources could have changes
+  schedule:
+    # Run on each Monday
+    - cron: '2 3 * * 1'
+
 permissions:
   actions: write
   contents: read
@@ -34,9 +47,33 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  detect_changes:
+    runs-on: ubuntu-latest
+    outputs:
+      changed: ${{ steps.changed.outputs.any_changed }}
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+      - name: Detect changed jablib classes or workflow
+        id: changed
+        uses: tj-actions/changed-files@v45
+        with:
+          files: |
+            jablib/src/main/java/**/*.java
+            .github/workflows/publish.yml
+
   publish:
     name: jablib
-    if: github.repository == 'JabRef/jabref'
+    needs: detect_changes
+    if: >
+      github.event_name == 'schedule' ||
+      github.event_name == 'workflow_dispatch' ||
+      (needs.detect_changes.outputs.changed == 'true' &&
+        ((github.event_name == 'workflow_call' && github.repository == 'JabRef/jabref') ||
+         (github.event_name == 'push' && github.repository == 'JabRef/jabref') ||
+         (github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == 'JabRef/jabref'))
+      )
     runs-on: ubuntu-latest
     steps:
       - name: Fetch all history for all tags and branches

.github/workflows/tests-code.yml

@@ -22,6 +22,9 @@ concurrency:
   cancel-in-progress: true
 
 permissions:
+  # required for publish.yml
+  actions: write
+  contents: read
   pull-requests: write
 
 jobs:
@@ -393,10 +396,20 @@ jobs:
           CI: "true"
           DBMS: "postgresql"
 
+  publish:
+    if: github.ref == 'refs/heads/main'
+    uses: ./.github/workflows/publish.yml
+    secrets:
+      KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64: ${{ secrets.KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64 }}
+      KOPPOR_SIGNING_KEYID: ${{ secrets.KOPPOR_SIGNING_KEYID }}
+      KOPPOR_SIGNING_PASSWORD: ${{ secrets.KOPPOR_SIGNING_PASSWORD }}
+      KOPPOR_MAVENCENTRALUSERNAME: ${{ secrets.KOPPOR_MAVENCENTRALUSERNAME }}
+      KOPPOR_MAVENCENTRALPASSWORD: ${{ secrets.KOPPOR_MAVENCENTRALPASSWORD }}
+
   jbang:
-    name: JBang
+    name: JBang (main)
     runs-on: ubuntu-latest
-    # JBang scripts depend on main-SNAPSHOT; thus, we can only test fully when main is updated
+    needs: publish
     if: github.ref == 'refs/heads/main'
     steps:
       - name: Checkout source
@@ -426,8 +439,61 @@ jobs:
       - run: jbang build .jbang/CheckoutPR.java
       - run: jbang build .jbang/CloneJabRef.java
       - run: jbang build --fresh .jbang/JabKitLauncher.java
+      - run: jbang build --fresh .jbang/JabLsLauncher.java
       - run: jbang build --fresh .jbang/JabSrvLauncher.java
 
+  jbang-pr:
+    name: JBang (PR)
+    runs-on: ubuntu-latest
+    # does not need publish, because the JBang scripts are modified
+    if: github.ref != 'refs/heads/main'
+    strategy:
+      fail-fast: false
+      matrix:
+        launcher: [JabKitLauncher, JabLsLauncher, JabSrvLauncher]
+    steps:
+      - name: Checkout source
+        uses: actions/checkout@v5
+        with:
+          submodules: 'false'
+          show-progress: 'false'
+      - name: Set up JDK
+        uses: actions/setup-java@v5
+        with:
+          java-version: 24
+          distribution: 'corretto'
+      - name: Generate JBang cache key
+        id: cache-key
+        shell: bash
+        run: |
+          echo "cache_key=jbang-$(date +%F)" >> $GITHUB_OUTPUT
+      - name: Use cache
+        uses: actions/cache@v4
+        with:
+          path: ~/.jbang
+          key: ${{ steps.cache-key.outputs.cache_key }}
+          restore-keys:
+            jbang-
+      - name: Setup JBang
+        uses: jbangdev/setup-jbang@main
+
+      - name: Detect changed jablib classes
+        id: changed-jablib-files
+        uses: tj-actions/changed-files@v45
+        with:
+          files: |
+            jablib/src/main/java/**/*.java
+
+      - name: Build ${{ matrix.launcher }} launcher including changed classes
+        shell: bash
+        # We always run, because changes in jabls, jabsrv also could cause JBang to fail
+        run: |
+          # We modify the JBang scripts directly to avoid issues with relative paths
+          for f in ${{ steps.changed-jablib-files.outputs.all_changed_files }}; do
+            echo "//SOURCES ../$f" >> ".jbang/${{ matrix.launcher }}.java"
+          done
+          jbang build --fresh ".jbang/${{ matrix.launcher }}.java"
+
   codecoverage:
     if: false
     name: Code coverage

.github/workflows/tests-pr.yml

@@ -127,8 +127,8 @@ jobs:
 
           LINE_COUNT=$(echo "$BOXES" | wc -l)
 
-          if [ "$LINE_COUNT" -ne 7 ]; then
-            echo "❌ Found $LINE_COUNT lines instead of 7 required lines"
+          if [ "$LINE_COUNT" -ne 6 ]; then
+            echo "❌ Found $LINE_COUNT lines instead of 6 required lines"
             exit 1
           fi
 

.jbang/JabLsLauncher.java

@@ -10,8 +10,14 @@
 
 //SOURCES ../jabls/src/main/java/org/jabref/languageserver/BibtexTextDocumentService.java
 //SOURCES ../jabls/src/main/java/org/jabref/languageserver/BibtexWorkspaceService.java
-//SOURCES ../jabls/src/main/java/org/jabref/languageserver/LSPLauncher.java
-//SOURCES ../jabls/src/main/java/org/jabref/languageserver/LSPServer.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/controller/LanguageServerController.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/ExtensionSettings.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/LspClientHandler.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/LspLauncher.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/util/LspConsistencyCheck.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/util/LspDiagnosticBuilder.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/util/LspDiagnosticHandler.java
+//SOURCES ../jabls/src/main/java/org/jabref/languageserver/util/LspIntegrityCheck.java
 
 // REPOS mavencentral,snapshots=https://central.sonatype.com/repository/maven-snapshots/
 // REPOS mavencentral,mavencentralsnapshots=https://central.sonatype.com/repository/maven-snapshots/,s01oss=https://s01.oss.sonatype.org/content/repositories/snapshots/,oss=https://oss.sonatype.org/content/repositories,jitpack=https://jitpack.io,oss2=https://oss.sonatype.org/content/groups/public,ossrh=https://oss.sonatype.org/content/repositories/snapshots

CHANGELOG.md

@@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Added
 
+- We added the option to enable the language server in the preferences. [#13697](https://github.com/JabRef/jabref/pull/13697)
 - We introduced an option in Preferences under (under Linked files -> Linked file name conventions) to automatically rename linked files when an entry data changes. [#11316](https://github.com/JabRef/jabref/issues/11316)
 - We added tooltips (on hover) for 'Library-specific file directory', 'User-specific file directory' and 'LaTeX file directory' fields of the library properties window. [#12269](https://github.com/JabRef/jabref/issues/12269)
 - A space is now added by default after citations inserted via the Libre/OpenOffice integration. [#13559](https://github.com/JabRef/jabref/issues/13559)
@@ -31,6 +32,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - When relativizing file names, symlinks are now taken into account. [#12995](https://github.com/JabRef/jabref/issues/12995)
 - We added a new button for shortening the DOI near the DOI field in the general tab when viewing an entry. [#13639](https://github.com/JabRef/jabref/issues/13639)
 - We added support for finding CSL-Styles based on their short title (e.g. apa instead of "american psychological association"). [#13728](https://github.com/JabRef/jabref/pull/13728)
+- We added BibLaTeX datamodel validation support in order to improve error message quality in entries' fields validation. [#13318](https://github.com/JabRef/jabref/issues/13318)
 
 ### Changed
 
@@ -71,6 +73,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We improved JabRef's internal document viewer. It now allows text section, searching and highlighting of search terms and page rotation [#13193](https://github.com/JabRef/jabref/pull/13193).
 - When importing a PDF, there is no empty entry column shown in the multi merge dialog. [#13132](https://github.com/JabRef/jabref/issues/13132)
 - We added a progress dialog to the "Check consistency" action and progress output to the corresponding cli command. [#12487](https://github.com/JabRef/jabref/issues/12487)
+- The BibTeX source is now formatted using the JabRef style at the import inspection dialog. [#13015](https://github.com/JabRef/jabref/issues/13015)
 - We made the `check-consistency` command of the toolkit always return an exit code; 0 means no issues found, a non-zero exit code reflects any issues, which allows CI to fail in these cases [#13328](https://github.com/JabRef/jabref/issues/13328).
 - We changed the validation error dialog for overriding the default file directories to a confirmation dialog for saving other preferences under the library properties. [#13488](https://github.com/JabRef/jabref/pull/13488)
 - We made the copy sub menu on the context menu consistent with the copy sub menu at "Edit". [#13280](https://github.com/JabRef/jabref/pull/13280)
@@ -107,8 +110,9 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 - We fixed an issue showing an empty tooltip in maintable. [#11681](https://github.com/JabRef/jabref/issues/11681)
 - We fixed an issue displaying a warning if a file to open is not found. [#13430](https://github.com/JabRef/jabref/pull/13430)
 - We fixed an issue where Document Viewer showed technical exceptions when opening entries with non-PDF files. [#13198](https://github.com/JabRef/jabref/issues/13198)
+- We fixed an issue with double display of the library filename in the tab tooltip in the case of a changed library. [#13781](https://github.com/JabRef/jabref/pull/13781)
 - When creating a library, if you drag a PDF file containing only a single column, the dialog will now automatically close. [#13262](https://github.com/JabRef/jabref/issues/13262)
-- We fixed an issue where the tab showing the fulltext search results would appear blank after switching library. [#13241](https://github.com/JabRef/jabref/issues/13241)
+- We fixed an issue where the tab showing the fulltext search results would appear blank after switching libraries. [#13241](https://github.com/JabRef/jabref/issues/13241)
 - We fixed an issue where "Copy to" was enabled even if no other library was opened. [#13280](https://github.com/JabRef/jabref/pull/13280)
 - We fixed an issue where the groups were still displayed after closing all libraries. [#13382](https://github.com/JabRef/jabref/issues/13382)
 - Enhanced field selection logic in the Merge Entries dialog when fetching from DOI to prefer valid years and entry types. [#12549](https://github.com/JabRef/jabref/issues/12549)

docs/decisions/0048-jbang-script-modification-for-testing-in-ci.md

@@ -0,0 +1,61 @@
+---
+nav_order: 48
+parent: Decision Records
+---
+
+# JBang script modification for testing in CI
+
+## Context and Problem Statement
+
+All JBang scripts on `main` should always compile.
+
+Example:
+
+```terminal
+gg.cmd  https://github.com/JabRef/jabref/blob/main/.jbang/JabLsLauncher.java
+```
+
+- JBang scripts link to `org.jabref:jablib:6.0-SNAPSHOT`.
+- JBang scripts include java files from the respective `-cli` repository and the sources of the respective server project. E.g., `JabLsLauncher.java` includes `ServerCli.java` from `jabls-cli` and all sources from `jabls`.
+- Code changes might change a) things inside the server project and b) things in JabRef's logic.
+
+As a consequence, the JBang script might break.
+
+Case a) can be detected when running the JBang check in the respective PR.
+Case b) can be detected when running the JBang check in the main branch, because `org.jabref:jablib:6.0-SNAPSHOT` is updated there.
+
+We aim for checking JBang scripts in PRs and on `main`.
+
+## Decision Drivers
+
+- Fast detection of issues at all JBang files
+- Easy CI pipeline
+
+## Considered Options
+
+- Have JBang script have all changed classes of `jablib` included directly
+- Use jitpack
+-Temporary `-SNAPSHOT.jar`
+
+## Decision Outcome
+
+Chosen option: "Have JBang script have all changed classes of `jablib` included directly.", because comes out best (see below).
+
+## Pros and Cons of the Options
+
+### Have JBang script have all changed classes of `jablib` included directly
+
+- `org.jabref:jablib:6.0-SNAPSHOT` provides non-modified classes
+- modified classes are included using JBang's `//SOURCES` directive.
+
+[tj-actions/changed-files](https://github.com/marketplace/actions/changed-files) can be used.
+
+- Good, because least effort
+
+### Use jitpack
+
+- Bad, because jitpack is unreliable
+
+### Temporary `-SNAPSHOT.jar`
+
+- Bad, because setting up a temporary maven repository is effort.

jabgui/build.gradle.kts

@@ -20,11 +20,12 @@ dependencies {
     // implementation("org.openjfx:javafx-fxml")
     // implementation("org.openjfx:javafx-graphics")
 
+    implementation(project(":jabls"))
+    implementation(project(":jabsrv"))
+
     implementation("org.openjfx:javafx-swing")
     implementation("org.openjfx:javafx-web")
 
-    implementation(project(":jabsrv"))
-
     implementation("com.pixelduke:fxthemes")
 
     // From JavaFX25 onwards

jabgui/src/main/java/module-info.java

@@ -1,6 +1,6 @@
 open module org.jabref {
     requires org.jabref.jablib;
-
+    requires org.jabref.jabls;
     requires org.jabref.jabsrv;
 
     // Swing