Skip to content

Commit 919b203

Browse files
authored
Merge branch 'main' into jetbrains-junie/issue-12186-run-fd7e881f-15c2-437d-a291-ced0190b26f1
2 parents 89c3019 + a83029a commit 919b203

File tree

239 files changed

+6986
-1940
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

239 files changed

+6986
-1940
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,8 @@ Keep ALL the items. Replace the dots inside [.] and mark them as follows:
2525
-->
2626

2727
- [x] I own the copyright of the code submitted and I license it under the [MIT license](https://github.com/JabRef/jabref/blob/main/LICENSE)
28-
- [.] Change in `CHANGELOG.md` described in a way that is understandable for the average user (if change is visible to the user)
29-
- [.] Tests created for changes (if applicable)
30-
- [.] Manually tested changed features in running JabRef (always required)
31-
- [.] Screenshots added in PR description (if change is visible to the user)
32-
- [.] [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.
33-
- [.] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request to the documentation repository.
28+
- [.] I manually tested my changes in running JabRef (always required)
29+
- [.] I added JUnit tests for changes (if applicable)
30+
- [.] I added screenshots in the PR description (if change is visible to the user)
31+
- [.] I described the change in `CHANGELOG.md` in a way that is understandable for the average user (if change is visible to the user)
32+
- [.] I checked the [user documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at <https://github.com/JabRef/user-documentation/issues> or, even better, I submitted a pull request updating file(s) in <https://github.com/JabRef/user-documentation/tree/main/en>.

.github/ghprcomment.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,10 @@
130130
Hey, we noticed that you **force-pushed** your changes.
131131
Force pushing is a bad practice when working together on a project (mainly because it is [not supported well by GitHub itself](https://github.com/orgs/community/discussions/3478)).
132132
Commits are lost and comments on commits lose their context, thus making it harder to review changes.
133-
At the end, all commits will be [squashed](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) anyway before being merged into the `main` branch.
133+
134+
135+
When the pull request is getting integrated into `main`, all commits will be [squashed](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) anyway.
136+
Thus, your individual commit history will not be visible in `main`.
134137
135138
136139
In future, **please avoid that**. For now, you can continue working.

.github/workflows/binaries.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ jobs:
174174
name: ${{ matrix.displayName }} installer and portable version
175175
steps:
176176
- name: Fetch all history for all tags and branches
177-
uses: actions/checkout@v4
177+
uses: actions/checkout@v5
178178
with:
179179
fetch-depth: 0
180180
submodules: 'true'
@@ -193,7 +193,7 @@ jobs:
193193
id: gitversion
194194
uses: gittools/actions/gitversion/[email protected]
195195
- name: Setup JDK
196-
uses: actions/setup-java@v4
196+
uses: actions/setup-java@v5
197197
with:
198198
java-version: '24'
199199
distribution: 'corretto'
@@ -362,7 +362,7 @@ jobs:
362362
runs-on: ${{ matrix.os }}
363363
steps:
364364
- name: Download from GitHub workflow artifacts store (macOS)
365-
uses: actions/download-artifact@v4
365+
uses: actions/download-artifact@v5
366366
with:
367367
name: JabRef-${{ matrix.os }}-tbn
368368
- name: Notarize dmg

.github/workflows/check-links.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
if: github.repository == 'JabRef/jabref'
2121
runs-on: ubuntu-latest
2222
steps:
23-
- uses: actions/checkout@v4
23+
- uses: actions/checkout@v5
2424
with:
2525
show-progress: 'false'
2626
- name: Run linkspector

.github/workflows/cleanup-pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
with:
2323
ignore_sha: true
2424
workflow_id: 160969125
25-
- uses: actions/checkout@v4
25+
- uses: actions/checkout@v5
2626
- name: "Check for 'dev: binaries' label"
2727
id: check_label
2828
run: |

.github/workflows/dockerimages.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
- name: Set up Docker Buildx
5454
uses: docker/setup-buildx-action@v3
5555
- name: Fetch all history for all tags and branches
56-
uses: actions/checkout@v4
56+
uses: actions/checkout@v5
5757
with:
5858
fetch-depth: 0
5959
submodules: 'true'

.github/workflows/gource.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151

5252
steps:
5353
- name: Checkout
54-
uses: actions/checkout@v4
54+
uses: actions/checkout@v5
5555
with:
5656
fetch-depth: 0
5757
show-progress: 'false'

.github/workflows/latex.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
runs-on: ubuntu-latest
2828
steps:
2929
- name: Check out code
30-
uses: actions/checkout@v4
30+
uses: actions/checkout@v5
3131
- name: Install TeX Live
3232
uses: zauguin/install-texlive@v4
3333
with:
@@ -80,7 +80,7 @@ jobs:
8080
bibengine: biber
8181
steps:
8282
- name: Check out code
83-
uses: actions/checkout@v4
83+
uses: actions/checkout@v5
8484

8585
- name: Install TeX Live
8686
uses: zauguin/install-texlive@v4

.github/workflows/on-issue-comment.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ jobs:
1717
uses: takanome-dev/assign-issue-action@edge
1818
with:
1919
github_token: '${{ secrets.GITHUB_TOKEN }}'
20-
days_until_unassign: 14
20+
# If this is updated, also update the number at unassign-issues.yml
21+
days_until_unassign: 21
2122
maintainers: 'koppor,Siedlerchr,ThiloteE,calixtus,HoussemNasri,subhramit,InAnYan,LinusDietz'
2223
assigned_comment: |
2324
👋 Hey @{{ handle }}, thank you for your interest in this issue! 🎉
@@ -32,9 +33,10 @@ jobs:
3233
3334
Happy coding! 🚀
3435
assignment_suggestion_comment: >
35-
👋 Hey @{{ handle }}, looks like you’re eager to work on this issue—great! 🎉
36-
It also looks like you skipped reading our [CONTRIBUTING.md](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md), which explains exactly how to participate. No worries, it happens to the best of us.
37-
Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀
36+
👋 Hey @{{ handle }}, looks like you’re eager to work on this issue — great! 🎉
37+
It also looks like you don't know how to assign issues to yourself.
38+
Please read our [CONTRIBUTING.md](https://github.com/JabRef/jabref/blob/main/CONTRIBUTING.md) to find out how.
39+
It will also guide you in other aspects of contributing to JabRef.
3840
- name: Move issue corresponding column in "Candidates for University Projects"
3941
uses: m7kvqbe1/github-action-move-issues@main
4042
if: ${{ steps.assign.outputs.assigned == 'yes' || steps.assign.outputs.unassigned == 'yes' }}

.github/workflows/on-issue-labeled.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,11 @@ jobs:
7878
ignored-columns: ""
7979
default-column: "Free to take"
8080
skip-if-not-in-project: true
81+
- name: Remove label
82+
run: |
83+
gh issue edit ${{ github.event.issue.number }} --remove-label "FirstTimeCodeContribution"
84+
env:
85+
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
8186
good-first-issue:
8287
name: "good first issue"
8388
if: "${{ github.event.label.name == 'good first issue' && github.repository_owner == 'JabRef' }}"
@@ -128,7 +133,7 @@ jobs:
128133
comment-tag:
129134
wisdom
130135
mode: recreate
131-
- uses: actions/checkout@v4
136+
- uses: actions/checkout@v5
132137
- name: Remove label
133138
run: |
134139
gh issue edit ${{ github.event.issue.number }} --remove-label "dev: wisdom"

0 commit comments

Comments
 (0)