Improve table layout and address review feedback

Author: OfficialArpitNege

CHANGELOG.md

@@ -38,7 +38,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Fixed
 
-- We fixed an issue where the Websearch table had extra space, to improve the layout. [#14556](https://github.com/JabRef/jabref/issues/14556)
+- We fixed an issue where the Web search table had extra space, to improve the layout. [#14556](https://github.com/JabRef/jabref/issues/14556)
 - We fixed PDF import to prefer the content extracted title over filename like XMP metadata titles. [#11999](https://github.com/JabRef/jabref/issues/11999)
 - We fixed RIS export writing the full page range into both start page and end page fields instead of splitting them correctly. [#15106](https://github.com/JabRef/jabref/issues/15106)
 - We fixed an issue where shortcut keys did not work for linked files in the entry editor. [#12564](https://github.com/JabRef/jabref/issues/12564)

jabgui/src/main/java/org/jabref/gui/preferences/websearch/WebSearchTab.java

@@ -4,6 +4,8 @@
 import java.util.Optional;
 
 import javafx.beans.InvalidationListener;
+import javafx.beans.binding.Bindings;
+import javafx.beans.binding.DoubleBinding;
 import javafx.beans.property.ReadOnlyBooleanProperty;
 import javafx.fxml.FXML;
 import javafx.geometry.Pos;
@@ -81,14 +83,9 @@ public String getTabName() {
         return Localization.lang("Web search");
     }
 
-    private static final double TABLE_ROW_HEIGHT = 30.0;
-    private static final double TABLE_HEADER_HEIGHT = 32.0;
-
     public void initialize() {
         this.viewModel = new WebSearchTabViewModel(preferences, refAiEnabled, taskExecutor);
 
-        searchEngineTable.setFixedCellSize(TABLE_ROW_HEIGHT);
-
         searchEngineName.setCellValueFactory(param -> param.getValue().nameProperty());
         searchEngineName.setCellFactory(TextFieldTableCell.forTableColumn());
         searchEngineName.setEditable(false);
@@ -98,8 +95,16 @@ public void initialize() {
         searchEngineUrlTemplate.setEditable(true);
 
         searchEngineTable.setItems(viewModel.getSearchEngines());
-        adjustTableHeight();
-        searchEngineTable.getItems().addListener((InvalidationListener) _ -> adjustTableHeight());
+
+        // Dynamic height based on font size and number of items
+        DoubleBinding rowHeight = Bindings.createDoubleBinding(
+                () -> enableWebSearch.getFont() != null ? enableWebSearch.getFont().getSize() * 2.5 : 30.0,
+                enableWebSearch.fontProperty());
+        searchEngineTable.fixedCellSizeProperty().bind(rowHeight);
+        searchEngineTable.prefHeightProperty().bind(
+                Bindings.size(searchEngineTable.getItems())
+                        .add(1.1) // Estimate for header height
+                        .multiply(rowHeight));
 
         enableWebSearch.selectedProperty().bindBidirectional(viewModel.enableWebSearchProperty());
         warnAboutDuplicatesOnImport.selectedProperty().bindBidirectional(viewModel.warnAboutDuplicatesOnImportProperty());
@@ -183,13 +188,6 @@ private Node createFetcherNode(WebSearchTabViewModel.FetcherViewModel item) {
         return container;
     }
 
-    private void adjustTableHeight() {
-        double height = TABLE_HEADER_HEIGHT + (searchEngineTable.getItems().size() * TABLE_ROW_HEIGHT) + 2.0;
-        searchEngineTable.setPrefHeight(height);
-        searchEngineTable.setMinHeight(height);
-        searchEngineTable.setMaxHeight(height);
-    }
-
     private void showApiKeyDialog(WebSearchTabViewModel.FetcherViewModel fetcherViewModel) {
         dialogService.showCustomDialogAndWait(new ApiKeyDialog(viewModel, fetcherViewModel));
     }

jabgui/src/main/resources/org/jabref/gui/preferences/websearch/WebSearchTab.fxml

@@ -53,7 +53,6 @@
     <Label text="%( Note: Press return to commit changes in the table! )"/>
     <TableView
             fx:id="searchEngineTable"
-            VBox.vgrow="ALWAYS"
             editable="true">
         <columns>
             <TableColumn minWidth="120"